From owner-freebsd-multimedia Sun Sep 17 17:20:55 2000 Delivered-To: freebsd-multimedia@freebsd.org Received: from mailhub.teliauk.com (mailhub.teliauk.com [195.12.225.36]) by hub.freebsd.org (Postfix) with ESMTP id B2BCD37B422 for ; Sun, 17 Sep 2000 17:20:52 -0700 (PDT) Received: from d1o314.teliauk.com (root@d1o314.teliauk.com [195.12.237.81]) by mailhub.teliauk.com (8.10.1/8.10.1) with ESMTP id e8I0ZgA05580; Mon, 18 Sep 2000 01:35:42 +0100 (BST) Received: from vilnya.demon.co.uk (t1o316p234.teliauk.com [195.12.246.234]) by d1o314.teliauk.com (8.8.8/8.8.8) with ESMTP id BAA05069; Mon, 18 Sep 2000 01:20:38 +0100 (GMT/BST) Received: from haveblue (haveblue.rings [10.2.4.5]) by vilnya.demon.co.uk (Postfix) with SMTP id 1D0DAD908; Mon, 18 Sep 2000 01:20:36 +0100 (BST) Message-ID: <006e01c02106$33389340$0504020a@haveblue> From: "Cameron Grant" To: "Doug Ambrisko" , "Taku YAMAMOTO" Cc: "Doug Ambrisko" , References: <200009161948.MAA43474@whistle.com> Subject: Re: AC97_MIXER_MONO (was Re: Anyone with i810 hardware?) Date: Mon, 18 Sep 2000 01:20:07 +0100 MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit X-Priority: 3 X-MSMail-Priority: Normal X-Mailer: Microsoft Outlook Express 5.50.4133.2400 X-MimeOLE: Produced By Microsoft MimeOLE V5.50.4133.2400 Sender: owner-freebsd-multimedia@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.org > | How about mapping SOUND_MIXER_PHONEOUT to AC97_MIX_MONO? > | With having SOUND_MIXER_PHONEOUT initial value in > | snd_mixerdefaults[] (/sys/dev/sound/pcm/mixer.c) will work. > > Actually I have done that, and should work however it would require > application level support, for example "mixer" doesn't support > modifying that parameter: please see ac97.c rev 1.11. support is added for all channels handled by the codec. AC97_MIX_MONO is mapped to SOUND_MIXER_PHONEOUT, AC97_MIX_PHONE to SOUND_MIXER_PHONEIN, anD AC97_MIX_PHONES to SOUND_MIXER_MONITOR. 'mixer' does support all of these. > It is something that I considered and may do however it requires application > changes. Just mapping AC97_MIX_MONO to SOUND_MIXER_VOLUME then lets > me adjust things via "mixer vol" and requires no application changes > (but does require a small kernel change). > > Also the reason that I like the idea of using ac97mixtable_entry for > everything is that it gives a clean consistant point of reference. > I found in ac97.c that uses both the AC97_MIX_MASTER and > ac97mixtable_entry[SOUND_MIXER_VOLUME]. It was a trivial change > to switch AC97_MIX_MASTER to be ac97mixtable_entry[SOUND_MIXER_VOLUME].reg > and then get rid of AC97_MIX_MASTER in the code. drivers should only be using the functions listed in ac97.h to control the codec, never writing directly to it. -cg To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-multimedia" in the body of the message