From owner-svn-src-user@FreeBSD.ORG Mon Dec 2 17:15:25 2013 Return-Path: Delivered-To: svn-src-user@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 84EB62FB; Mon, 2 Dec 2013 17:15:25 +0000 (UTC) Received: from mail.allbsd.org (gatekeeper.allbsd.org [IPv6:2001:2f0:104:e001::32]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 765C01597; Mon, 2 Dec 2013 17:15:24 +0000 (UTC) Received: from alph.d.allbsd.org (p4181-ipbf1307funabasi.chiba.ocn.ne.jp [123.225.173.181]) (authenticated bits=128) by mail.allbsd.org (8.14.5/8.14.5) with ESMTP id rB2HF6QR004158 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Tue, 3 Dec 2013 02:15:16 +0900 (JST) (envelope-from hrs@FreeBSD.org) Received: from localhost (localhost [IPv6:::1]) (authenticated bits=0) by alph.d.allbsd.org (8.14.7/8.14.5) with ESMTP id rB2HF4dg073007; Tue, 3 Dec 2013 02:15:05 +0900 (JST) (envelope-from hrs@FreeBSD.org) Date: Tue, 03 Dec 2013 02:14:39 +0900 (JST) Message-Id: <20131203.021439.505942678651568262.hrs@allbsd.org> To: gjb@FreeBSD.org Subject: Re: svn commit: r258848 - user/hrs/releng/release From: Hiroki Sato In-Reply-To: <20131202160333.GI1839@glenbarber.us> References: <20131202152054.GH1839@glenbarber.us> <20131203.005247.163975247035953783.hrs@allbsd.org> <20131202160333.GI1839@glenbarber.us> X-PGPkey-fingerprint: BDB3 443F A5DD B3D0 A530 FFD7 4F2C D3D8 2793 CF2D X-Mailer: Mew version 6.5 on Emacs 24.3 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Multipart/Signed; protocol="application/pgp-signature"; micalg=pgp-sha1; boundary="--Security_Multipart(Tue_Dec__3_02_14_39_2013_992)--" Content-Transfer-Encoding: 7bit X-Virus-Scanned: clamav-milter 0.97.4 at gatekeeper.allbsd.org X-Virus-Status: Clean X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.7 (mail.allbsd.org [133.31.130.32]); Tue, 03 Dec 2013 02:15:17 +0900 (JST) X-Spam-Status: No, score=-99.1 required=13.0 tests=CONTENT_TYPE_PRESENT, SPF_SOFTFAIL,USER_IN_WHITELIST autolearn=no version=3.3.2 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on gatekeeper.allbsd.org Cc: src-committers@FreeBSD.org, svn-src-user@FreeBSD.org X-BeenThere: svn-src-user@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: "SVN commit messages for the experimental " user" src tree" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 02 Dec 2013 17:15:25 -0000 ----Security_Multipart(Tue_Dec__3_02_14_39_2013_992)-- Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Glen Barber wrote in <20131202160333.GI1839@glenbarber.us>: gj> > - In the current release.sh, variables unintentionally set in the gj> > builder's environment still pollutes commands which run in gj> > release.sh when the variables are not set in the script but gj> > accepted by make or other utilities. Catching all of the variables gj> > is quite difficult. gj> > gj> gj> Do you have an example? If you are referring to a previous problem with gj> 10.x builds, the actual problem was a race in the build toolchain, and gj> not variable pollution. I was able to confirm this was the case there. One of the surprising examples I experienced was that svn co sometimes fails with LC_ALL=C. Subversion stores repo data in UTF-8, so iconv conversion happens when LC_ALL is not UTF-8 compatible (and it broke "svn co head/" a while ago). Besides, TARGET, TARGET_ARCH, MAKEOBJDIR, MAKEOBJDIRPREFIX, and OBJDIR are also dangerous and unprotected variables for make(1). An empty TARGET caused an infinite loop in libc build, so I fixed it in Makefile yesterday. All of them are examples of "unintentional" variables, so being careful is enough to avoid them, though. gj> > Anyway, I do not have a strong opinion if using FOO=A or : ${FOO:=A}. gj> > I agree that the latter assumes all of the envvars must be under gj> > control and it needs one more step than just invoking the script, and gj> > a leaked variable can break the build. If you do not like it, I will gj> > change them with FOO=A. gj> > gj> gj> Yes, please. Will do. I will not merge the changes before 10.0R is out in any case. -- Hiroki ----Security_Multipart(Tue_Dec__3_02_14_39_2013_992)-- Content-Type: application/pgp-signature Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.13 (FreeBSD) iEYEABECAAYFAlKcv/8ACgkQTyzT2CeTzy0KPgCfaXp+xOndbt78S0S8uT8oL62x 5/IAoNkkakGKkK3QkqFmm18vBaICwdXM =DizG -----END PGP SIGNATURE----- ----Security_Multipart(Tue_Dec__3_02_14_39_2013_992)----