From owner-svn-ports-all@FreeBSD.ORG  Fri Aug  1 06:20:47 2014
Return-Path: <owner-svn-ports-all@FreeBSD.ORG>
Delivered-To: svn-ports-all@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 1033)
 id 3EF56F4A; Fri,  1 Aug 2014 06:20:47 +0000 (UTC)
Date: Fri, 1 Aug 2014 06:20:47 +0000
From: Alexey Dokuchaev <danfe@FreeBSD.org>
To: marino@freebsd.org
Subject: Re: svn commit: r363361 - in head/editors/fte: . files
Message-ID: <20140801062047.GC71116@FreeBSD.org>
References: <2D24420529C9ECAEABB9A791@atuin.in.mat.cc>
 <53D8A2BB.7090704@marino.st>
 <6270029E710D3C52B60B6224@atuin.in.mat.cc>
 <20140730081413.GA29876@FreeBSD.org>
 <20140730160843.GA2688@FreeBSD.org> <53D919BC.6010307@marino.st>
 <20140801051652.GA59625@FreeBSD.org>
 <CAALwa8=R2i9PA7R8VXHStZCDGy_ZFaYcBtRmY-_ZFq9k=toJ+w@mail.gmail.com>
 <20140801060506.GA71116@FreeBSD.org> <53DB3021.7010909@marino.st>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <53DB3021.7010909@marino.st>
User-Agent: Mutt/1.5.23 (2014-03-12)
Cc: "svn-ports-head@freebsd.org" <svn-ports-head@freebsd.org>,
 Max Brazhnikov <makc@freebsd.org>, Antoine Brodin <antoine@FreeBSD.org>,
 "svn-ports-all@freebsd.org" <svn-ports-all@freebsd.org>,
 William Grzybowski <wg@freebsd.org>,
 "ports-committers@freebsd.org" <ports-committers@freebsd.org>,
 Mathieu Arnold <mat@freebsd.org>, Adam Weinberger <adamw@adamw.org>
X-BeenThere: svn-ports-all@freebsd.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: SVN commit messages for the ports tree <svn-ports-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-all/>
List-Post: <mailto:svn-ports-all@freebsd.org>
List-Help: <mailto:svn-ports-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 01 Aug 2014 06:20:47 -0000

On Fri, Aug 01, 2014 at 08:13:53AM +0200, John Marino wrote:
> logic flaw: You can't just replace "/" with "-" or "_" without altering
> "-" or "_" in the filename.
> 
> example, given these files:
>   ${WRKSRC}/alpha-bravo
>   ${WRKSRC}/alpha/bravo
> 
> if you replace "/" with "-", both have the same suggested patch name.
> You need to alter the hyphen in alpha-bravo first.

Basically right now one patch will overwrite another conflicting one, which
ever comes first.  I think I can add a check beforea > $${OUT} and issue an
error and refuse to overwrite a file, or maybe just warn.  Which you prefer?

./danfe