Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 8 Aug 2005 15:46:48 -0400
From:      Ed Maste <emaste@phaedrus.sandvine.ca>
To:        freebsd-net@freebsd.org
Subject:   [PATCH] Minor cleanup of inline declaration for netgraph.h
Message-ID:  <20050808194648.GB4843@sandvine.com>

next in thread | raw e-mail | index | archive | help

--s/l3CgOIzMHHjg/5
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

We build one of our netgraph modules with -W, which causes GCC
to emit "warning: `inline' is not at beginning of declaration" for
netgraph.h.  It's pretty trivial, but the attached patch cleans this
up so it's consistent across all of the functions in netgraph.h.

--
Ed Maste, Sandvine Incorporated

--s/l3CgOIzMHHjg/5
Content-Type: text/plain; charset=us-ascii
Content-Disposition: attachment; filename="netgraph.h.patch"

Index: sys/netgraph/netgraph.h
===================================================================
RCS file: /usr/cvs/src/sys/netgraph/netgraph.h,v
retrieving revision 1.58
diff -u -3 -r1.58 netgraph.h
--- sys/netgraph/netgraph.h	2 Aug 2005 20:06:48 -0000	1.58
+++ sys/netgraph/netgraph.h	8 Aug 2005 19:31:07 -0000
@@ -175,7 +175,7 @@
 					int line);
 static __inline void	_ng_hook_force_queue(hook_p hook, char * file, int line);
 
-static void __inline 
+static __inline void
 _chkhook(hook_p hook, char *file, int line)
 {
 	if (hook->hk_magic != HK_MAGIC) {
@@ -407,7 +407,7 @@
 
 #ifdef	NETGRAPH_DEBUG /*----------------------------------------------*/
 void	dumpnode(node_p node, char *file, int line);
-static void __inline _chknode(node_p node, char *file, int line);
+static __inline void _chknode(node_p node, char *file, int line);
 static __inline char * _ng_node_name(node_p node, char *file, int line);
 static __inline int _ng_node_has_name(node_p node, char *file, int line);
 static __inline ng_ID_t _ng_node_id(node_p node, char *file, int line);
@@ -425,7 +425,7 @@
 			ng_fn_eachhook *fn, void *arg, char *file, int line);
 static __inline void _ng_node_revive(node_p node, char *file, int line);
 
-static void __inline 
+static __inline void
 _chknode(node_p node, char *file, int line)
 {
 	if (node->nd_magic != ND_MAGIC) {

--s/l3CgOIzMHHjg/5--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20050808194648.GB4843>