From nobody Tue Aug 27 01:06:43 2024 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Wt8Wm1WfGz5TjLt; Tue, 27 Aug 2024 01:06:44 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Wt8Wm0Lwqz4lrd; Tue, 27 Aug 2024 01:06:44 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1724720804; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=WQc3iMd6zy+1GhZH/TrDw8AsbPKbs7oIH3hLpk2DDfc=; b=buzDEzdqxG+yTQ5+cQfWJ1btsU25LtajmjEJpZThNO83kJlb58bO3ZPyw6iykDvvPqccxJ N72tONNeXDt1SLb+PMeu8iuawCUtOTfNe4jRirVjG9SMm7rhZnekxJQkHwGSawfTotFD5P dgDckG3L3+R8J9+SeJOGfJp2/LOAHz8vdW8aYAMWymWhgxHd85S7HnnT7wZ/gQkbQikpXN y0E3KokmBRI6ijfpV9vgZ7mKAn3IQD01YV9CszkKOKicYXbuhXafdavTTzK0Yu5Ktl9cqj Z/DqkYmMNhO9ZEt0Hx+V4I4D2kHKGKh+aQgtsMN6JxXWrTTIyzYmo7ws1WLZPQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1724720804; a=rsa-sha256; cv=none; b=KkHX/LTWrw4KONXFghxy69eLj2T975yrbFJ/Fo6X92kny70b4bFsGS8b0mtCYxXa3XxyeI OhMy5KCx0yud05AJDL2/j3O6xsYm8FUtnABhoqDq+UTbAtNcB+ZiK2Yp4du1skMKbrF67a Z0F6uXdrfOLqPjxzFXlkdIrY/HrURmzJ/EFZKUV3fjLy828TZoAahqvcRjmqpCO9Mm2b3a CbDfVlHrELVjJg0Ar1H8GOSJpzsgWMB0K54G5FnCe3EWH9qY43JXbFNhvn5Qllcxrnk/Ug sYvDXANNmNkIzfj3CTyuyKu/627M7NYec6mxaxSIGyjA2ZKm8P3y2tnK6zAADQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1724720804; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=WQc3iMd6zy+1GhZH/TrDw8AsbPKbs7oIH3hLpk2DDfc=; b=ymPx4SlxCJZWUuVBL9b4iyEdrslbodzaHmmD7tQE0iolZePd79O3xeitdgfXMMn1bKq+/R b7ikRbO2ST/qtUuHiMtgo0Gzy4FmFgizvd1asCzrr6uCBFDptvrPCcrPbZyrS6TbRvZNE/ 0E7rYkMmuEYemJdn23c3MNimxtxglS1/K5Q87XTr+WDiUU4oIIWMTHxPVDPler44fBVr/h uHyQItOI27OOI/UTJJav9ZfCJdKudBlbjbhQWDM/nnSL6EIsowJQxlJ3BO94X4gICoPP3+ r1CdcgbVEc9Fo+pfd4VMdsm5t4Uq6OZq5xd5K7J2jq3eTHlLswjD4TLVKuFaMw== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4Wt8Wl5zMjzSkL; Tue, 27 Aug 2024 01:06:43 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 47R16h85057323; Tue, 27 Aug 2024 01:06:43 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 47R16hag057320; Tue, 27 Aug 2024 01:06:43 GMT (envelope-from git) Date: Tue, 27 Aug 2024 01:06:43 GMT Message-Id: <202408270106.47R16hag057320@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: John Baldwin Subject: git: 71484bbbfff3 - stable/14 - nvmecontrol: Move command effeccts page printing to little endian orderinng List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: jhb X-Git-Repository: src X-Git-Refname: refs/heads/stable/14 X-Git-Reftype: branch X-Git-Commit: 71484bbbfff3cb93be026749cde3af55ab885c2f Auto-Submitted: auto-generated The branch stable/14 has been updated by jhb: URL: https://cgit.FreeBSD.org/src/commit/?id=71484bbbfff3cb93be026749cde3af55ab885c2f commit 71484bbbfff3cb93be026749cde3af55ab885c2f Author: Warner Losh AuthorDate: 2024-04-16 22:36:25 +0000 Commit: John Baldwin CommitDate: 2024-08-26 18:31:03 +0000 nvmecontrol: Move command effeccts page printing to little endian orderinng Sponsored by: Netflix Reviewed by: chuck Differential Revision: https://reviews.freebsd.org/D44655 (cherry picked from commit b850caf7b7099636fd4323cb47a82f5201309fed) --- sbin/nvmecontrol/logpage.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/sbin/nvmecontrol/logpage.c b/sbin/nvmecontrol/logpage.c index 897bb7a59118..67d296df6afb 100644 --- a/sbin/nvmecontrol/logpage.c +++ b/sbin/nvmecontrol/logpage.c @@ -220,10 +220,6 @@ read_logpage(int fd, uint8_t log_page, uint32_t nsid, uint8_t lsp, /* Convert data to host endian */ switch (log_page) { - case NVME_LOG_COMMAND_EFFECT: - nvme_command_effects_page_swapbytes( - (struct nvme_command_effects_page *)payload); - break; case NVME_LOG_RES_NOTIFICATION: nvme_res_notification_page_swapbytes( (struct nvme_res_notification_page *)payload); @@ -442,7 +438,7 @@ print_log_command_effects(const struct nvme_controller_data *cdata __unused, printf(" Command\tLBCC\tNCC\tNIC\tCCC\tCSE\tUUID\n"); for (i = 0; i < 255; i++) { - s = ce->acs[i]; + s = letoh(ce->acs[i]); if (NVMEV(NVME_CE_PAGE_CSUP, s) == 0) continue; printf("Admin\t%02x\t%s\t%s\t%s\t%s\t%u\t%s\n", i, @@ -454,7 +450,7 @@ print_log_command_effects(const struct nvme_controller_data *cdata __unused, NVMEV(NVME_CE_PAGE_UUID, s) != 0 ? "Yes" : "No"); } for (i = 0; i < 255; i++) { - s = ce->iocs[i]; + s = letoh(ce->iocs[i]); if (NVMEV(NVME_CE_PAGE_CSUP, s) == 0) continue; printf("I/O\t%02x\t%s\t%s\t%s\t%s\t%u\t%s\n", i,