From owner-svn-src-head@freebsd.org Wed Mar 30 15:55:42 2016 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id AE853AE370F for ; Wed, 30 Mar 2016 15:55:42 +0000 (UTC) (envelope-from zbb@semihalf.com) Received: from mail-lf0-x235.google.com (mail-lf0-x235.google.com [IPv6:2a00:1450:4010:c07::235]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 22F3010BB for ; Wed, 30 Mar 2016 15:55:42 +0000 (UTC) (envelope-from zbb@semihalf.com) Received: by mail-lf0-x235.google.com with SMTP id k79so39566789lfb.2 for ; Wed, 30 Mar 2016 08:55:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=semihalf-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=GkQbpZay0/dzzLZnNsUtvv5aLyVBCWfGzTJcxaLCZ3I=; b=s7vPmuyoUCYprcQn3zsuC794yqdblWU2e7sCdKLzkOG+ZFKemH77AKrv0kVgQssMLI JoMglvfj86zBbrgSxNEKZC1RpD6kNs0NeScVPyEDH/vSRovozc2VRRSwskb7SxVudGhx nuEFz60i/K1QJgwm7RtbA8P4M3kv9i9iviAciK4g5aP0VxkIA+UOVt88DJTCJFkDOv9+ /9fy/9eHIgFxo7qhfHfNvYng8aBlKBHM32Lv2LjcfAPSH5BooZE8AzjS/4SPmqw6VPhg ED8WpJrwr0T///5cOOi9DYwdTt0YWjNaGdoQk6eHWVZg7Qg3rPARBylc+dO8HI9NABqo z5VQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=GkQbpZay0/dzzLZnNsUtvv5aLyVBCWfGzTJcxaLCZ3I=; b=fQCREYxW9WWJeEnwYoo6sGCkK1lBp/YNc3fZYU/pn6k9fHdKqxj77t5ZfUW/uLKdqP k9XgaRDo9XP7JSZ4ZFWcEc94v2sbH0DDI3vLIK8TDLsMnQgDBp4n7/kq5STR2ZnAPdA9 K2Cq5zwexKjQmIxwRZiLX4CplLzxpqdNDZ/ttFyEKKhcyQDAuJI1q/0V+t97LUc2r/GG q/+ATU2MQcLrmHuBt6uVZDO7y2Eujj/6UtgKXsVnRZxBvDTF7QuKJi3n2m4tjD2DRynk pAJhauT1LnnIua6a272uwym4M4/rVF5tuiNk8/2Ns9zFj8qPzhxkgJI3S9wMWGDAppnC LsOA== X-Gm-Message-State: AD7BkJKhF/ROoTDQ/zgOHgfm6UFzZ0Xlv2+DpoFAfCODvJzgg2JbLUJAdHzFZo3Bi7ruFjLoWnbE5gAVTNOXcA== X-Received: by 10.25.30.206 with SMTP id e197mr4341954lfe.144.1459353340288; Wed, 30 Mar 2016 08:55:40 -0700 (PDT) MIME-Version: 1.0 Received: by 10.25.77.202 with HTTP; Wed, 30 Mar 2016 08:55:20 -0700 (PDT) In-Reply-To: <56FBE3D6.9050205@freebsd.org> References: <201603291519.u2TFJuXW051571@repo.freebsd.org> <56FBE3D6.9050205@freebsd.org> From: Zbigniew Bodek Date: Wed, 30 Mar 2016 17:55:20 +0200 Message-ID: Subject: Re: svn commit: r297392 - in head/sys: conf dev/ofw powerpc/mpc85xx powerpc/powermac powerpc/pseries To: Nathan Whitehorn Cc: Ed Maste , Zbigniew Bodek , "svn-src-head@freebsd.org" , "svn-src-all@freebsd.org" , "src-committers@freebsd.org" Content-Type: multipart/mixed; boundary=001a11401b0e734be0052f462d17 X-Content-Filtered-By: Mailman/MimeDel 2.1.21 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 30 Mar 2016 15:55:42 -0000 --001a11401b0e734be0052f462d17 Content-Type: text/plain; charset=UTF-8 Thank you Nathan. Please check out new patch in the attachment. Best regards zbb 2016-03-30 16:33 GMT+02:00 Nathan Whitehorn : > PowerPC (and SPARC) can have real OFW without FDT support. Adding FDT to > LINT is the wrong solution: rather, it should switch on fdt | aim like the > rest of the Open Firmware code. > -Nathan > > > On 03/30/16 01:54, Zbigniew Bodek wrote: > > Hello Ed, > > Please check out the attached patch. For powerpc we should compile-in > ofwpci.c regardless of FDT option. > However, it seems that LINT for powerpc does not have FDT. What do you > thing about adding it (as can be seen in the attached patch)?. This would > be done in a separate commit. > > Best regards > zbb > > 2016-03-30 1:53 GMT+02:00 Ed Maste : > >> On 29 March 2016 at 15:19, Zbigniew Bodek < >> zbb@freebsd.org> wrote: >> > Author: zbb >> > Date: Tue Mar 29 15:19:56 2016 >> > New Revision: 297392 >> > URL: https://svnweb.freebsd.org/changeset/base/297392 >> > >> > Log: >> > Reduce OFW PCI code duplication - involves ARM, PPC and SPARC64 >> >> My 'make tinderbox' build is now failing (powerpc LINT) with: >> >> linking kernel >> cpcht.o: In function `cpcht_attach': >> cpcht.c:(.text+0x17dc): undefined reference to `ofw_pci_attach' >> cpcht.o:(.data.rel+0x0): undefined reference to `ofw_pci_driver' >> grackle.o: In function `grackle_attach': >> grackle.c:(.text+0x2dc): undefined reference to `ofw_pci_attach' >> grackle.o:(.data.rel+0x0): undefined reference to `ofw_pci_driver' >> uninorthpci.o: In function `uninorth_attach': >> uninorthpci.c:(.text+0x68c): undefined reference to `ofw_pci_attach' >> uninorthpci.o:(.data.rel+0x0): undefined reference to `ofw_pci_driver' >> *** [kernel] Error code 1 >> _______________________________________________ >> svn-src-all@freebsd.org mailing list >> https://lists.freebsd.org/mailman/listinfo/svn-src-all >> To unsubscribe, send any mail to " >> svn-src-all-unsubscribe@freebsd.org" >> > > > --001a11401b0e734be0052f462d17 Content-Type: text/plain; charset=US-ASCII; name="ppc_lint_fix.diff" Content-Disposition: attachment; filename="ppc_lint_fix.diff" Content-Transfer-Encoding: base64 X-Attachment-Id: f_imf1a71n0 ZGlmZiAtLWdpdCBhL3N5cy9jb25mL2ZpbGVzLnBvd2VycGMgYi9zeXMvY29uZi9maWxlcy5wb3dl cnBjCmluZGV4IGUzOTM0M2IuLjU2Nzc2ZGMgMTAwNjQ0Ci0tLSBhL3N5cy9jb25mL2ZpbGVzLnBv d2VycGMKKysrIGIvc3lzL2NvbmYvZmlsZXMucG93ZXJwYwpAQCAtNTcsNyArNTcsNyBAQCBkZXYv b2Z3L29md19jb25zb2xlLmMJCW9wdGlvbmFsCWFpbQogZGV2L29mdy9vZndfZGlzay5jCQlvcHRp b25hbAlvZndkIGFpbQogZGV2L29mdy9vZndfaWljYnVzLmMJCW9wdGlvbmFsCWlpY2J1cyBhaW0K IGRldi9vZncvb2Z3YnVzLmMJCW9wdGlvbmFsCWFpbSB8IGZkdAotZGV2L29mdy9vZndwY2kuYwkJ b3B0aW9uYWwgCWZkdCBwY2kKK2Rldi9vZncvb2Z3cGNpLmMJCW9wdGlvbmFsIAlwY2kgYWltIHwg cGNpIGZkdAogZGV2L29mdy9vZndfc3RhbmRhcmQuYwkJb3B0aW9uYWwJYWltIHBvd2VycGMKIGRl di9vZncvb2Z3X3N1YnIuYwkJb3B0aW9uYWwJYWltIHBvd2VycGMKIGRldi9wb3dlcm1hY19udnJh bS9wb3dlcm1hY19udnJhbS5jIG9wdGlvbmFsCXBvd2VybWFjX252cmFtIHBvd2VybWFjCg== --001a11401b0e734be0052f462d17--