From owner-freebsd-bugs@FreeBSD.ORG Wed Jul 13 07:30:11 2005 Return-Path: X-Original-To: freebsd-bugs@hub.freebsd.org Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 1A6AD16A41C for ; Wed, 13 Jul 2005 07:30:11 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id 9817643D46 for ; Wed, 13 Jul 2005 07:30:10 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.13.3/8.13.3) with ESMTP id j6D7UANx097136 for ; Wed, 13 Jul 2005 07:30:10 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.13.3/8.13.1/Submit) id j6D7UAoa097135; Wed, 13 Jul 2005 07:30:10 GMT (envelope-from gnats) Resent-Date: Wed, 13 Jul 2005 07:30:10 GMT Resent-Message-Id: <200507130730.j6D7UAoa097135@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Dan Lukes Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id A89B116A41C for ; Wed, 13 Jul 2005 07:22:59 +0000 (GMT) (envelope-from dan@kulesh.obluda.cz) Received: from kulesh.obluda.cz (kulesh.obluda.cz [193.179.22.243]) by mx1.FreeBSD.org (Postfix) with ESMTP id 87EEB43D46 for ; Wed, 13 Jul 2005 07:22:58 +0000 (GMT) (envelope-from dan@kulesh.obluda.cz) Received: from kulesh.obluda.cz (localhost.eunet.cz [127.0.0.1]) by kulesh.obluda.cz (8.13.3/8.13.3) with ESMTP id j6D7MumC023062 for ; Wed, 13 Jul 2005 09:22:57 +0200 (CEST) (envelope-from dan@kulesh.obluda.cz) Received: (from root@localhost) by kulesh.obluda.cz (8.13.3/8.13.1/Submit) id j6D7Mu0u023061; Wed, 13 Jul 2005 09:22:56 +0200 (CEST) (envelope-from dan) Message-Id: <200507130722.j6D7Mu0u023061@kulesh.obluda.cz> Date: Wed, 13 Jul 2005 09:22:56 +0200 (CEST) From: Dan Lukes To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 Cc: Subject: bin/83369: [ PATCH ] incorrect handling of malloc failures within librpcsvc's xencrypt()/xdecrypt() X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Dan Lukes List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 13 Jul 2005 07:30:11 -0000 >Number: 83369 >Category: bin >Synopsis: [ PATCH ] incorrect handling of malloc failures within librpcsvc's xencrypt()/xdecrypt() >Confidential: no >Severity: serious >Priority: low >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Wed Jul 13 07:30:09 GMT 2005 >Closed-Date: >Last-Modified: >Originator: Dan Lukes >Release: FreeBSD 5.4-STABLE i386 >Organization: Obludarium >Environment: System: FreeBSD 5.4-STABLE #8: Sat Jul 9 16:31:08 CEST 2005 i386 lib/librpcsvc/xcrypt.c,v 1.4 2002/03/21 23:53:40 obrien lib/librpcsvc/Makefile,v 1.16.8.2 2005/02/13 07:23:14 obrien >Description: Incorrect handling of malloc failures within librpcsvc's xencrypt()/xdecrypt() >How-To-Repeat: >Fix: --- patch begins here --- --- lib/librpcsvc/xcrypt.c.ORIG Mon Jul 1 22:53:53 2002 +++ lib/librpcsvc/xcrypt.c Wed Jul 13 09:17:19 2005 @@ -63,7 +63,9 @@ int len; len = strlen(secret) / 2; - buf = malloc((unsigned)len); + if ((buf = malloc((unsigned)len)) == NULL) { + return(0); + } hex2bin(len, secret, buf); passwd2des(passwd, key); @@ -96,7 +98,9 @@ int len; len = strlen(secret) / 2; - buf = malloc((unsigned)len); + if ((buf = malloc((unsigned)len)) == NULL) { + return(0); + } hex2bin(len, secret, buf); passwd2des(passwd, key); --- lib/librpcsvc/Makefile.ORIG Mon Feb 14 12:33:34 2005 +++ lib/librpcsvc/Makefile Wed Jul 13 09:19:51 2005 @@ -29,6 +29,8 @@ NOMAN= +WARNS+= 2 + .include .SUFFIXES: .x _xdr.c --- patch ends here --- >Release-Note: >Audit-Trail: >Unformatted: