Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 3 Jun 2012 08:30:00 +0000 (UTC)
From:      Andriy Gapon <avg@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r236504 - head/usr.sbin/cpucontrol
Message-ID:  <201206030830.q538U0ZY045098@svn.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: avg
Date: Sun Jun  3 08:30:00 2012
New Revision: 236504
URL: http://svn.freebsd.org/changeset/base/236504

Log:
  cpucontrol: use CPUCTL_UPDATE ioctl on correct file descriptor
  
  I guess that means that microcode update has never worked for AMD CPUs.
  Please also note that only older AMD CPUs and micrcode file format are
  supported anyway (pre 10h family).
  
  MFC after:	1 week

Modified:
  head/usr.sbin/cpucontrol/amd.c

Modified: head/usr.sbin/cpucontrol/amd.c
==============================================================================
--- head/usr.sbin/cpucontrol/amd.c	Sun Jun  3 08:01:12 2012	(r236503)
+++ head/usr.sbin/cpucontrol/amd.c	Sun Jun  3 08:30:00 2012	(r236504)
@@ -160,7 +160,7 @@ amd_update(const char *dev, const char *
 
 		args.data = fw_image;
 		args.size = st.st_size;
-		error = ioctl(fd, CPUCTL_UPDATE, &args);
+		error = ioctl(devfd, CPUCTL_UPDATE, &args);
 		if (error < 0) {
 			fprintf(stderr, "failed.\n");
 			warn("ioctl()");



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201206030830.q538U0ZY045098>