From owner-svn-src-head@freebsd.org Tue Nov 21 05:30:19 2017 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 6A877DE22C0 for ; Tue, 21 Nov 2017 05:30:19 +0000 (UTC) (envelope-from markmi@dsl-only.net) Received: from asp.reflexion.net (outbound-mail-210-121.reflexion.net [208.70.210.121]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 1BD707FE45 for ; Tue, 21 Nov 2017 05:30:18 +0000 (UTC) (envelope-from markmi@dsl-only.net) Received: (qmail 16124 invoked from network); 21 Nov 2017 05:30:12 -0000 Received: from unknown (HELO mail-cs-01.app.dca.reflexion.local) (10.81.19.1) by 0 (rfx-qmail) with SMTP; 21 Nov 2017 05:30:12 -0000 Received: by mail-cs-01.app.dca.reflexion.local (Reflexion email security v8.40.3) with SMTP; Tue, 21 Nov 2017 00:30:12 -0500 (EST) Received: (qmail 22641 invoked from network); 21 Nov 2017 05:30:12 -0000 Received: from unknown (HELO iron2.pdx.net) (69.64.224.71) by 0 (rfx-qmail) with (AES256-SHA encrypted) SMTP; 21 Nov 2017 05:30:12 -0000 Received: from [192.168.1.25] (c-76-115-7-162.hsd1.or.comcast.net [76.115.7.162]) by iron2.pdx.net (Postfix) with ESMTPSA id C1C47EC8B7B; Mon, 20 Nov 2017 21:30:11 -0800 (PST) From: Mark Millard Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Mime-Version: 1.0 (Mac OS X Mail 10.3 \(3273\)) Subject: Re: svn commit: r326038 - in head/stand: . arm/uboot efi efi/fdt fdt i386 mips/beri mips/beri/boot2 mips/beri/loader mips/uboot ofw/libofw powerpc/boot1.chrp powerpc/kboot powerpc/ofw powerpc/ps3 power... Message-Id: <2434FC04-1FF3-48B0-8743-78412673616F@dsl-only.net> Date: Mon, 20 Nov 2017 21:30:11 -0800 To: Warner Losh , svn-src-head@freebsd.org X-Mailer: Apple Mail (2.3273) X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 21 Nov 2017 05:30:19 -0000 It looks to me like head/stand/powerpc/boot1.chrp/Makefile might have +=3D vs. =3D issues compared to the other examples: Warner Losh imp at FreeBSD.org wrote on Mon Nov 20 22:42:21 UTC 2017 : Modified: head/stand/powerpc/boot1.chrp/Makefile = =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D --- head/stand/powerpc/boot1.chrp/Makefile Mon Nov 20 22:41:22 2017 = (r326037) +++ head/stand/powerpc/boot1.chrp/Makefile Mon Nov 20 22:42:17 2017 = (r326038) @@ -13,9 +13,7 @@ SRCS=3D boot1.c ashldi3.c syncicache.c =20 MAN=3D =20 -CFLAGS=3D -ffreestanding -msoft-float \ - -I${LDRSRC} -I${SYSDIR} -I${SASRC} \ - -D_STANDALONE +CFLAGS=3D -I${LDRSRC} -I${SYSDIR} -I${SASRC} -D_STANDALONE LDFLAGS=3D-nostdlib -static -Wl,-N =20 .PATH: ${SYSDIR}/libkern ${SRCTOP}/lib/libc/powerpc/gen ${.CURDIR} but the other files tend to use +=3D for at least CFLAGS. In one case you converted an =3D into only using +=3D locally: -CFLAGS=3D -ffreestanding \ - -I${.CURDIR} \ +CFLAGS+=3D -I${.CURDIR} \ (Generally the mix seems to be as it was before the changes but it likely looked odd before the changes when the files were view together.) There are also examples like: LDFLAGS=3D -nostdlib -static -T = ${.CURDIR}/ldscript.${MACHINE_CPUARCH} LDFLAGS+=3D -Wl,-znotext and others with just =3D . But some files seem to always use +=3D for LDFLAGS. May be a round of =3D vs. +=3D checking is appropriate for the involved files? =3D=3D=3D Mark Millard markmi at dsl-only.net