From owner-freebsd-net@FreeBSD.ORG Mon Dec 6 11:48:43 2010 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 8098B1065672 for ; Mon, 6 Dec 2010 11:48:43 +0000 (UTC) (envelope-from egrosbein@rdtc.ru) Received: from eg.sd.rdtc.ru (eg.sd.rdtc.ru [62.231.161.221]) by mx1.freebsd.org (Postfix) with ESMTP id C37168FC19 for ; Mon, 6 Dec 2010 11:48:42 +0000 (UTC) Received: from eg.sd.rdtc.ru (localhost [127.0.0.1]) by eg.sd.rdtc.ru (8.14.4/8.14.4) with ESMTP id oB6Bmam8048631; Mon, 6 Dec 2010 17:48:36 +0600 (NOVT) (envelope-from egrosbein@rdtc.ru) Message-ID: <4CFCCD94.60100@rdtc.ru> Date: Mon, 06 Dec 2010 17:48:36 +0600 From: Eugene Grosbein User-Agent: Mozilla/5.0 (X11; U; FreeBSD i386; ru-RU; rv:1.9.1.10) Gecko/20100712 Thunderbird/3.0.5 MIME-Version: 1.0 To: Jack Vogel References: <201011270946271408828@yahoo.com.cn> <20101128081617.GA90332@zibbi.meraka.csir.co.za> <4CF73A2C.7000802@rdtc.ru> <4CF89EE7.8020807@rdtc.ru> <4CF93A77.30804@rdtc.ru> <4CF9470F.4020709@sentex.net> <4CF947D4.10504@rdtc.ru> <4CFA0435.7020100@rdtc.ru> In-Reply-To: Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: bzeeb-lists@lists.zabbadoz.net, freebsd-net , Jack Vogel , Mike Tancsa Subject: [patch] Bring link down when interface goes down X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 06 Dec 2010 11:48:43 -0000 On 04.12.2010 15:08, Jack Vogel wrote: > This isn't some simple 'go change this line or parameter', > there were some problematic issues that my Linux coworkers > faced, I have to go look into it before I even decide... > > so...patience friend. For igb(4) the change seems pretty short. At least, it works for my 82576-based dual-port copper card. --- if_igb.h.orig 2010-12-06 12:27:54.000000000 +0600 +++ if_igb.h 2010-12-06 12:29:47.000000000 +0600 @@ -450,6 +450,8 @@ #endif void *stats; + /* Bring link down when interface goes down */ + int down_disables_link; }; /* ****************************************************************************** --- if_igb.c.orig 2010-11-30 11:14:42.000000000 +0600 +++ if_igb.c 2010-12-06 12:37:10.000000000 +0600 @@ -432,6 +432,13 @@ OID_AUTO, "enable_aim", CTLTYPE_INT|CTLFLAG_RW, &igb_enable_aim, 1, "Interrupt Moderation"); + adapter->down_disables_link = 0; + SYSCTL_ADD_INT(device_get_sysctl_ctx(dev), + SYSCTL_CHILDREN(device_get_sysctl_tree(dev)), + OID_AUTO, "down_disables_link", CTLTYPE_INT|CTLFLAG_RW, + &adapter->down_disables_link, adapter->down_disables_link, + "Bring link down when interface goes down"); + callout_init_mtx(&adapter->timer, &adapter->core_mtx, 0); /* Determine hardware and mac info */ @@ -2070,6 +2077,13 @@ e1000_led_off(&adapter->hw); e1000_cleanup_led(&adapter->hw); + + if(adapter->down_disables_link) { + e1000_power_down_phy(&adapter->hw); + igb_handle_link(adapter, 0); + /* Reset the phy next time init gets called */ + adapter->hw.phy.reset_disable = FALSE; + } } However, similar patch applied to em(4) does not work for my on-board 82574L-based cards: e1000_power_down_phy() thanslates to e1000_power_down_phy_copper_82571() that does nothing because mac->ops.check_mng_mode(hw) returns true value and, therefore, e1000_power_down_phy_copper(hw) is not even called. Still trying to find a way... Eugene Grosbein