From owner-svn-ports-all@FreeBSD.ORG Fri Nov 8 22:08:37 2013 Return-Path: Delivered-To: svn-ports-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id 46183B78; Fri, 8 Nov 2013 22:08:37 +0000 (UTC) (envelope-from vg.freebsd@gmail.com) Received: from mail-lb0-x22a.google.com (mail-lb0-x22a.google.com [IPv6:2a00:1450:4010:c04::22a]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 40FFE23A1; Fri, 8 Nov 2013 22:08:36 +0000 (UTC) Received: by mail-lb0-f170.google.com with SMTP id u14so1813819lbd.15 for ; Fri, 08 Nov 2013 14:08:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:content-type:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=QuLn3Z1ozm4J3/C0+cPx4P3IOPiCa+wvwChSreUaBS4=; b=h8ys1JuSvN4hsM/j8x8kfYmu1NKo7Nf8eTWS4QRQVF7omjd7MRnjvmnRDv1ae9fD9S OXqkqupyouP3KhgOmwaZgW58Q+LyERTKMQsXmhHlTuVRrHmU0JGHtPfl+hHNERsFCwN5 GemdvVXgSaOvSIEbRKNRMvUP8wBUz8ZOFgesFVqGXKAaT107YEwPkpq9thKbTK19ITjs xS8HuTMX7h/IfVKOuevU6WL5m4YjDyegh4SIqy9ofyw5fJtziXDZhs1RJ3b1ktnFZ7yy 9ZOUJBjdDvE9vsdEldlXXV9eiL31gruDV0F1zJ0PHNvbSqC7qNYjDm6VfYoBrludllmZ /BzQ== X-Received: by 10.112.205.34 with SMTP id ld2mr12254137lbc.27.1383948514276; Fri, 08 Nov 2013 14:08:34 -0800 (PST) Received: from [10.10.40.207] ([77.50.191.3]) by mx.google.com with ESMTPSA id l10sm7758379lbh.13.2013.11.08.14.08.33 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Fri, 08 Nov 2013 14:08:33 -0800 (PST) Sender: Veniamin Gvozdikov Content-Type: text/plain; charset=windows-1252 Mime-Version: 1.0 (Mac OS X Mail 7.0 \(1822\)) Subject: Re: svn commit: r332677 - in head/sysutils: . dunst From: Veniamin Gvozdikov In-Reply-To: <20131106074425.GH60770@FreeBSD.org> Date: Sat, 9 Nov 2013 02:08:32 +0400 Content-Transfer-Encoding: quoted-printable Message-Id: References: <201311040941.rA49fEMj003374@svn.freebsd.org> <20131106074425.GH60770@FreeBSD.org> To: Alexey Dokuchaev X-Mailer: Apple Mail (2.1822) Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 08 Nov 2013 22:08:37 -0000 I=92ve just done all recommendations. Thank you. On Nov 6, 2013, at 11:44 AM, Alexey Dokuchaev wrote: > On Mon, Nov 04, 2013 at 09:41:14AM +0000, Veniamin Gvozdikov wrote: >> New Revision: 332677 >> URL: http://svnweb.freebsd.org/changeset/ports/332677 >>=20 >> +CATEGORIES=3D sysutils >> +MASTER_SITES=3D http://www.knopwob.org/public/dunst-release/ >> + >> +MAINTAINER=3D rodperson@rodperson.com >> +COMMENT=3D Lightweight notification deamon >=20 > s/deamon/daemon/ perhaps? You could've added LICENSE=3DBSD, by the = way. >=20 >> +LIB_DEPENDS=3D cairo:${PORTSDIR}/graphics/cairo \ >> + dbus:${PORTSDIR}/devel/dbus \ >> + execinfo:${PORTSDIR}/devel/libexecinfo \ >> + freetype:${PORTSDIR}/print/freetype2 \ >> + notify:${PORTSDIR}/devel/libnotify \ >> + pango:${PORTSDIR}/x11-toolkits/pango \ >> + xdg-basedir:${PORTSDIR}/x11/libxdg-basedir >=20 > You could've also used modern syntax for LIB_DEPENDS. >=20 >> +MAKE_ARGS+=3D MANPREFIX=3D"${PREFIX}/man" >> + >> +ALL_TARGET=3D dunst dunstify dunst.1 >> +INSTALL_TARGET=3D install >> + >> +LDFLAGS+=3D -O3 -g -Wall -rdynamic -lexecinfo >=20 > -O3 -g? Really? We usually try hard to get rid of this upstream = shit, not > to add it. In rare cases when something obnoxious like this is = actually > *required* for software's proper operation, it should be accompanied = by the > explanatory comment. >=20 >> +CFLAGS+=3D -I${LOCALBASE}/include >=20 > Polluting CFLAGS with preprocessor option should only be done if = software > does not support CPPFLAGS, I hope it was verified that it indeed does = not. >=20 >> @@ -0,0 +1,6 @@ >> +Dunst is a lightweight replacement for the notification-daemons = provided >> +by most desktop environments. It's very customizable, doesn't depend = on >> +any toolkits and therefore fits in those windowmanager centric = setups we >> +all love to customize to perfection. >> + >> +WWW: http://www.knopwob.org/dunst >=20 > Nicely written description. Using double space after the full stop = would > make it even better at the right side. ;-) I would rather not = discuss > the necessity of comma before "and" and if "window manager" ought to = be > spelled separately, but would mention that terminating WWW line (per = PH, > section 3.2.1) would be nice. >=20 > ./danfe