Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 09 Feb 2013 20:52:47 +0400
From:      Andrey Zonov <zont@FreeBSD.org>
To:        Ian Lepore <ian@FreeBSD.org>
Cc:        svn-src-stable@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org, svn-src-stable-9@FreeBSD.org
Subject:   Re: svn commit: r246402 - stable/9/usr.sbin/inetd
Message-ID:  <51167EDF.5010808@FreeBSD.org>
In-Reply-To: <1360159920.93359.594.camel@revolution.hippie.lan>
References:  <201302061316.r16DGh6m024337@svn.freebsd.org> <1360159920.93359.594.camel@revolution.hippie.lan>

next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
------enig2OANEGRQWNNVVETRRIOCV
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable

On 2/6/13 6:12 PM, Ian Lepore wrote:
> On Wed, 2013-02-06 at 13:16 +0000, Andrey Zonov wrote:
>> Author: zont
>> Date: Wed Feb  6 13:16:43 2013
>> New Revision: 246402
>> URL: http://svnweb.freebsd.org/changeset/base/246402
>>
>> Log:
>>   MFC r245696:
>>   - Force inetd to have listen queue size to be set to the value of
>>     kern.ipc.somaxconn instead of hardcoded value 64.
>>
>> Modified:
>>   stable/9/usr.sbin/inetd/inetd.c
>> Directory Properties:
>>   stable/9/usr.sbin/inetd/   (props changed)
>>
>> Modified: stable/9/usr.sbin/inetd/inetd.c
>> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D
>> --- stable/9/usr.sbin/inetd/inetd.c	Wed Feb  6 13:14:30 2013	(r246401)=

>> +++ stable/9/usr.sbin/inetd/inetd.c	Wed Feb  6 13:16:43 2013	(r246402)=

>> @@ -1387,7 +1387,7 @@ setsockopt(fd, SOL_SOCKET, opt, (char *)
>>                  }
>>          }
>>  	if (sep->se_socktype =3D=3D SOCK_STREAM)
>> -		listen(sep->se_fd, 64);
>> +		listen(sep->se_fd, -1);
>>  	enable(sep);
>>  	if (debug) {
>>  		warnx("registered %s on %d",
>=20
> I recently discovered that the posix documentation for listen(2) states=

> that a queue depth less than zero is to be treated as if zero were
> specified, and the behavior for zero is to minimize the length of the
> queue to the smallest value the implementation supports (with words tha=
t
> imply the desired (but not required) effect is to stop listening if
> possible).
>=20

Hm, I could not imagine that POSIX creates new shiny bike for that.

> Given that, perhaps it's unwise to expand the amount of code we've got
> that relies on this freebsd-specific non-conformance?
>=20

I think it is BSD-specific and I like -1 more than INT_MAX here.

Note that Linux is going crazy when you set backlog more than system limi=
t.

--=20
Andrey Zonov


------enig2OANEGRQWNNVVETRRIOCV
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG/MacGPG2 v2.0.18 (Darwin)
Comment: GPGTools - http://gpgtools.org

iQEcBAEBAgAGBQJRFn7iAAoJEBWLemxX/CvTczYH/jQn5WpJ6xWG6gTuUp0/HtLy
qtoFeEb4D4G+cqx1SXYSgo6WinFdqx71daBCT18u1a0fPs4SBgMfMirLYW1Q1AeS
FoPPaTsuoXo9I8ObmdJXyc1JLHUF0eDKp1So9qFUc6KWa+nDwrbnMRlp9B9rYzSo
+kub1Hg8WmRpLsauNorfHsxEhsvq2NLIRwO6tEaeMy/YF0lX71nM7dY/esCFdeDU
0OajrNmmXA7tjrkyWGP95K2tMumQI3QRXGuBhjwgCRcGnEK8aXFY7zXs0EPpuxqd
ANoIFOTAwQwjWtwOJVCfvkEIM+Bt6gGT4kPoB1DMT2o0P/0xyyRjLnP4LYcJLUw=
=hmBk
-----END PGP SIGNATURE-----

------enig2OANEGRQWNNVVETRRIOCV--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?51167EDF.5010808>