From owner-freebsd-hackers@FreeBSD.ORG  Fri Nov 16 18:36:08 2012
Return-Path: <owner-freebsd-hackers@FreeBSD.ORG>
Delivered-To: freebsd-hackers@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
 by hub.freebsd.org (Postfix) with ESMTP id 2633BAE4;
 Fri, 16 Nov 2012 18:36:08 +0000 (UTC) (envelope-from bright@mu.org)
Received: from elvis.mu.org (elvis.mu.org [192.203.228.196])
 by mx1.freebsd.org (Postfix) with ESMTP id F2FE28FC08;
 Fri, 16 Nov 2012 18:36:07 +0000 (UTC)
Received: from Alfreds-MacBook-Pro-5.local
 (c-67-180-208-218.hsd1.ca.comcast.net [67.180.208.218])
 by elvis.mu.org (Postfix) with ESMTPSA id F05911A3DB3;
 Fri, 16 Nov 2012 10:36:06 -0800 (PST)
Message-ID: <50A68796.60603@mu.org>
Date: Fri, 16 Nov 2012 10:36:06 -0800
From: Alfred Perlstein <bright@mu.org>
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.7;
 rv:16.0) Gecko/20121026 Thunderbird/16.0.2
MIME-Version: 1.0
To: Adrian Chadd <adrian@freebsd.org>
Subject: Re: [RFQ] make witness panic an option
References: <CAJ-Vmo=i=Amo_QqHi4GnGie0Gc0YnK3XaRKjvBO-=SFboFYPmA@mail.gmail.com>
 <1353001175.1217.153.camel@revolution.hippie.lan>
 <CAJ-FndBP5Pi=SCpyBLK3b=HM_gQ9u8M4+1tLk9tA5X-gqismVA@mail.gmail.com>
 <1353009310.1217.172.camel@revolution.hippie.lan>
 <CAJ-Vmo=S3a1pyLHOe+SayVNDe=mAogQnkNpnSTakpOm56EdOUQ@mail.gmail.com>
 <50A555BD.1010105@FreeBSD.org> <50A578A6.1030005@mu.org>
 <50A5E9B4.5040807@FreeBSD.org> <50A5F8C1.6010700@mu.org>
 <CAJ-Vmomp0WM7cCEnxu2m83TYJG7tEtysCRtyD_=eH=i5PeAOCg@mail.gmail.com>
In-Reply-To: <CAJ-Vmomp0WM7cCEnxu2m83TYJG7tEtysCRtyD_=eH=i5PeAOCg@mail.gmail.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: attilio@freebsd.org, Ian Lepore <freebsd@damnhippie.dyndns.org>,
 freebsd-arch@freebsd.org, Andriy Gapon <avg@freebsd.org>,
 freebsd-hackers@freebsd.org
X-BeenThere: freebsd-hackers@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: Technical Discussions relating to FreeBSD
 <freebsd-hackers.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-hackers>, 
 <mailto:freebsd-hackers-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-hackers>
List-Post: <mailto:freebsd-hackers@freebsd.org>
List-Help: <mailto:freebsd-hackers-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-hackers>,
 <mailto:freebsd-hackers-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 16 Nov 2012 18:36:08 -0000

On 11/16/12 10:18 AM, Adrian Chadd wrote:
> On 16 November 2012 00:26, Alfred Perlstein <bright@mu.org> wrote:
>
>> Adding another option to tag asserts so that it was sort of like:
>>
>> KASSERT((cond, section, "string")); would be interesting, then you could
>> turn KASSERTS on based on "vfs" or possibly file by file.
> That's orthogonal to my developer-focused request. I'm also a big fan
> of correctly using asserts/panics - ie, asserts shouldn't replace
> correct error handling.
> (Yes, I'm guilty of this in ath(4), but I have plans soon to rectify this.)
>
>
>
> Adrian
I apologize if you took a wishlist item for me as a request for you to 
take on/augment your patch.

It was not my intention.

Back to your work, I like your patch quite a bit, I am wondering though 
if it can be worked into something under witness_kdb though.

-Alfred