Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 16 Nov 2012 10:36:06 -0800
From:      Alfred Perlstein <bright@mu.org>
To:        Adrian Chadd <adrian@freebsd.org>
Cc:        attilio@freebsd.org, Ian Lepore <freebsd@damnhippie.dyndns.org>, freebsd-arch@freebsd.org, Andriy Gapon <avg@freebsd.org>, freebsd-hackers@freebsd.org
Subject:   Re: [RFQ] make witness panic an option
Message-ID:  <50A68796.60603@mu.org>
In-Reply-To: <CAJ-Vmomp0WM7cCEnxu2m83TYJG7tEtysCRtyD_=eH=i5PeAOCg@mail.gmail.com>
References:  <CAJ-Vmo=i=Amo_QqHi4GnGie0Gc0YnK3XaRKjvBO-=SFboFYPmA@mail.gmail.com> <1353001175.1217.153.camel@revolution.hippie.lan> <CAJ-FndBP5Pi=SCpyBLK3b=HM_gQ9u8M4%2B1tLk9tA5X-gqismVA@mail.gmail.com> <1353009310.1217.172.camel@revolution.hippie.lan> <CAJ-Vmo=S3a1pyLHOe%2BSayVNDe=mAogQnkNpnSTakpOm56EdOUQ@mail.gmail.com> <50A555BD.1010105@FreeBSD.org> <50A578A6.1030005@mu.org> <50A5E9B4.5040807@FreeBSD.org> <50A5F8C1.6010700@mu.org> <CAJ-Vmomp0WM7cCEnxu2m83TYJG7tEtysCRtyD_=eH=i5PeAOCg@mail.gmail.com>

next in thread | previous in thread | raw e-mail | index | archive | help
On 11/16/12 10:18 AM, Adrian Chadd wrote:
> On 16 November 2012 00:26, Alfred Perlstein <bright@mu.org> wrote:
>
>> Adding another option to tag asserts so that it was sort of like:
>>
>> KASSERT((cond, section, "string")); would be interesting, then you could
>> turn KASSERTS on based on "vfs" or possibly file by file.
> That's orthogonal to my developer-focused request. I'm also a big fan
> of correctly using asserts/panics - ie, asserts shouldn't replace
> correct error handling.
> (Yes, I'm guilty of this in ath(4), but I have plans soon to rectify this.)
>
>
>
> Adrian
I apologize if you took a wishlist item for me as a request for you to 
take on/augment your patch.

It was not my intention.

Back to your work, I like your patch quite a bit, I am wondering though 
if it can be worked into something under witness_kdb though.

-Alfred



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?50A68796.60603>