Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 28 Jul 2010 21:58:18 GMT
From:      "Bjoern A. Zeeb" <bz@FreeBSD.org>
To:        Perforce Change Reviews <perforce@freebsd.org>
Subject:   PERFORCE change 181537 for review
Message-ID:  <201007282158.o6SLwIgB041794@repoman.freebsd.org>

next in thread | raw e-mail | index | archive | help
http://p4web.freebsd.org/@@181537?ac=10

Change 181537 by bz@bz_dumpster on 2010/07/28 21:57:43

	Move a standalone comment further up to SeND related code and adjust
	the wording.
	
	Reviewed by:	anchie

Affected files ...

.. //depot/projects/soc2009/anchie_send/src/sys/netinet6/nd6.c#38 edit

Differences ...

==== //depot/projects/soc2009/anchie_send/src/sys/netinet6/nd6.c#38 (text+ko) ====

@@ -1947,7 +1947,13 @@
 	mac_netinet6_nd6_send(ifp, m);
 #endif
 
-	/* Send outgoing NS/NA/REDIRECT packet to sendd. */
+	/*
+	 * If called from nd6_ns_output() (NS), nd6_na_output() (NA),
+	 * icmp6_redirect_output() (REDIRECT) or from rip6_output() (RS, RA
+	 * as handled by rtsol and rtadvd), mbufs will be tagged for SeND
+	 * to be diverted to user space.  When re-injected into the kernel,
+	 * send_output() will directly dispatch them to the outgoing interface.
+	 */
 	if (send_sendso_input_hook != NULL) {
 		mtag = m_tag_find(m, PACKET_TAG_ND_OUTGOING, NULL);
 		if (mtag != NULL) {
@@ -1985,16 +1991,6 @@
 		return (error);
 	}
 
-	/*
-	 * In case of NS, NA and Redirect, we end-up here after calling
-	 * nd6_ns_output()/nd6_na_output()/icmp6_redirect_output().
-	 * RS and RA do not have such output routines. They are handled
-	 * instead by rtadvd and rtsol daemons.
-	 *
-	 * if_output() routines together with previous chaining will be called
-	 * from input hook.
-	 */
-
 	if ((ifp->if_flags & IFF_LOOPBACK) != 0) {
 		return ((*ifp->if_output)(origifp, m, (struct sockaddr *)dst,
 		    NULL));



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201007282158.o6SLwIgB041794>