From nobody Mon Oct 27 15:58:08 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4cwJ7m0MClz6DvPR; Mon, 27 Oct 2025 15:58:12 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Received: from omta004.cacentral1.a.cloudfilter.net (omta002.cacentral1.a.cloudfilter.net [3.97.99.33]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "Client", Issuer "CA" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4cwJ7l5FCJz3wqh; Mon, 27 Oct 2025 15:58:11 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Authentication-Results: mx1.freebsd.org; none Received: from shw-obgw-4004b.ext.cloudfilter.net ([10.228.9.230]) by cmsmtp with ESMTPS id DPASvrHpRPzKyDPbmvn5rJ; Mon, 27 Oct 2025 15:58:10 +0000 Received: from spqr.komquats.com ([70.66.136.217]) by cmsmtp with ESMTPSA id DPblvkPnJE9qcDPbmv1PBl; Mon, 27 Oct 2025 15:58:10 +0000 X-Auth-User: cschuber X-Authority-Analysis: v=2.4 cv=fPU0HJae c=1 sm=1 tr=0 ts=68ff9692 a=h7br+8Ma+Xn9xscxy5znUg==:117 a=h7br+8Ma+Xn9xscxy5znUg==:17 a=kj9zAlcOel0A:10 a=x6icFKpwvdMA:10 a=6I5d2MoRAAAA:8 a=EkcXrb_YAAAA:8 a=YxBL1-UpAAAA:8 a=ae8wBLNxA1x_4cVDYjcA:9 a=CjuIK1q_8ugA:10 a=LK5xJRSDVpKd5WXXoEvA:22 a=Ia-lj3WSrqcvXOmTRaiG:22 Received: from slippy.cwsent.com (slippy.cwsent.com [10.1.1.91]) by spqr.komquats.com (Postfix) with ESMTP id E0B557F; Mon, 27 Oct 2025 08:58:08 -0700 (PDT) Received: by slippy.cwsent.com (Postfix, from userid 1000) id A4532201; Mon, 27 Oct 2025 08:58:08 -0700 (PDT) X-Mailer: exmh version 2.9.0 11/07/2018 with nmh-1.8+dev Reply-to: Cy Schubert From: Cy Schubert X-os: FreeBSD X-Sender: cy@cwsent.com X-URL: http://www.cschubert.com/ To: Jose Luis Duran cc: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Subject: Re: git: 79e374217d69 - main - blocklist: Fix rcorder(8) In-reply-to: <202510271547.59RFlnxW096622@gitrepo.freebsd.org> References: <202510271547.59RFlnxW096622@gitrepo.freebsd.org> Comments: In-reply-to Jose Luis Duran message dated "Mon, 27 Oct 2025 15:47:49 +0000." List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Mon, 27 Oct 2025 08:58:08 -0700 Message-Id: <20251027155808.A4532201@slippy.cwsent.com> X-CMAE-Envelope: MS4xfORULRCobi2muAJcHsR7XXFingDJuQFIcP52B7o6NoVXo3YztOc1FtnAqjN75jLiTQeX1hhdkUIs4hbH23z+6x7BSbooSC3FYC26YWpFajgmVn0sGlxb 6TV60q9i3esvTkP+Pw+XqCKDz7hbEv00EwEvSg4iFrw+va8YIO581XRQVfUD30KDMpvDfAargQgj0JtJy7Rw+wgZ0AAuNFRd5LxgiGIhUTcSuKv4UX8DKw7I OPE0zQagagC6h7xbcKm7sTld6V00GRBZu9CBcPqzE39H5YHk6tneBOg1ybrCANUgLMjVI4m4zwNHpfmQpjeWfG2r8el0BvRxQgGgwK6Nf3c= X-Spamd-Bar: ---- X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:16509, ipnet:3.96.0.0/15, country:US] X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Rspamd-Queue-Id: 4cwJ7l5FCJz3wqh In message <202510271547.59RFlnxW096622@gitrepo.freebsd.org>, Jose Luis Duran w rites: > The branch main has been updated by jlduran: > > URL: https://cgit.FreeBSD.org/src/commit/?id=79e374217d69a98161fc91a286dacf1f > 78090894 > > commit 79e374217d69a98161fc91a286dacf1f78090894 > Author: Jose Luis Duran > AuthorDate: 2025-10-27 15:46:32 +0000 > Commit: Jose Luis Duran > CommitDate: 2025-10-27 15:46:32 +0000 > > blocklist: Fix rcorder(8) > > The blocklist daemon depends on a packet filter in order to block. > > Add all supported packet filters to the REQUIRE line, not just pf, to > indicate rcorder(8) that it should start after the packet filter service > has started. > > While here, change the mode of the rc file to include the executable > bit, just like the rest of the files in the rc.d source directory. > > Reviewed by: 0mp > MFC after: 2 days > Differential Revision: https://reviews.freebsd.org/D53364 > --- > libexec/rc/rc.d/blacklistd | 2 +- > libexec/rc/rc.d/blocklistd | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/libexec/rc/rc.d/blacklistd b/libexec/rc/rc.d/blacklistd > index 9157e258f43f..175e3e8c56b3 100755 > --- a/libexec/rc/rc.d/blacklistd > +++ b/libexec/rc/rc.d/blacklistd > @@ -29,7 +29,7 @@ > # > > # PROVIDE: blacklistd > -# REQUIRE: netif pf > +# REQUIRE: netif ipfilter ipfw pf This means all three, ipfilter AND ipfw AND pf, must be enabled and started. What if one uses only one of the three? > > . /etc/rc.subr > > diff --git a/libexec/rc/rc.d/blocklistd b/libexec/rc/rc.d/blocklistd > old mode 100644 > new mode 100755 > index 24cbae77fd40..f979162ec3e0 > --- a/libexec/rc/rc.d/blocklistd > +++ b/libexec/rc/rc.d/blocklistd > @@ -29,7 +29,7 @@ > # > > # PROVIDE: blocklistd > -# REQUIRE: netif pf > +# REQUIRE: netif ipfilter ipfw pf Ditto. > > . /etc/rc.subr > > -- Cheers, Cy Schubert FreeBSD UNIX: Web: https://FreeBSD.org NTP: Web: https://nwtime.org e**(i*pi)+1=0