From owner-freebsd-current  Mon Jul  3 08:29:39 1995
Return-Path: current-owner
Received: (from majordom@localhost)
          by freefall.cdrom.com (8.6.10/8.6.6) id IAA09578
          for current-outgoing; Mon, 3 Jul 1995 08:29:39 -0700
Received: from asstdc.scgt.oz.au (root@asstdc.scgt.oz.au [202.14.234.65])
          by freefall.cdrom.com (8.6.10/8.6.6) with ESMTP id IAA09567
          for <current@freebsd.org>; Mon, 3 Jul 1995 08:29:24 -0700
Received: (from imb@localhost)
	by asstdc.scgt.oz.au (8.6.12/BSD4.4)
	id BAA02503 for current@freebsd.org; Tue, 4 Jul 1995 01:29:14 +1000
From: michael butler <imb@scgt.oz.au>
Message-Id: <199507031529.BAA02503@asstdc.scgt.oz.au>
Subject: Re: spontaneous reboots ?
To: current@freebsd.org
Date: Tue, 4 Jul 1995 01:29:13 +1000 (EST)
In-Reply-To: <199507031201.WAA18182@asstdc.scgt.oz.au> from "michael butler" at Jul 3, 95 10:01:36 pm
X-Mailer: ELM [version 2.4 PL24beta]
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Content-Length: 571       
Sender: current-owner@freebsd.org
Precedence: bulk

I wrote: 

> It's in the ipfw code .. 

In ip_fw.c at about line 300:

> bad_packet:
>	if (f) {
>			/*
>			 * Do not ICMP reply to icmp
>			 * packets....:)
>			 */
>		if (f_prt==IP_FW_F_ICMP)
>			goto return_0;

*** NOTE "m" is still uninitialised here ***

>			/*
>			 * Reply to packets rejected
>			 * by entry with this flag
>			 * set only.
>			 */
>		if (!(f->fw_flg&IP_FW_F_ICMPRPL))
>			goto return_0;

*** and here ***

>		m = dtom(ip);

 : 
 :

> return_0:
>	m_freem(m);
>	return 0;
> good_packet:
>	return 1;
> }

 .. but we try m_freem(m) anyway ?

	michael