From owner-svn-src-all@freebsd.org Tue Mar 31 01:48:09 2020 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id C22142704D3; Tue, 31 Mar 2020 01:48:09 +0000 (UTC) (envelope-from lwhsu.freebsd@gmail.com) Received: from mail-yb1-f196.google.com (mail-yb1-f196.google.com [209.85.219.196]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 48rsfb0PcNz3DSp; Tue, 31 Mar 2020 01:48:06 +0000 (UTC) (envelope-from lwhsu.freebsd@gmail.com) Received: by mail-yb1-f196.google.com with SMTP id o70so10222479ybg.10; Mon, 30 Mar 2020 18:48:06 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=NOlsgGvdj8P1l/z5OHlw1qtGp4ydZ8ah/zO13iXPIpw=; b=teWhZcEp3c0CQht72bLkp7G7L/HufcP7xhy3DE70esaHMQudaIwxYVeyFC7l7hqpU8 Y9q7GWvordAMRdfKD/4pTRxdqbnk4ifebbGgOzzBXzcrXA/Jke5XRZA8frZi/7e8txWf 4ppl2YnFjKqQSoGkfACj9JRgzOv+RZrU34T+jfZJ7gmuf6qLUhaoNIi1ypVvMS/nPAX8 zhlDP3LYwJmleQbjciZbfbihomaDkbLTU357Z5mckaBlKFoRzGrTxYqeJhgwfXVxlZYp ZsUbWs2VdbO52ImkQOxv6JJLowJS/wZrpEcZQKBQvKOOfV9vcZaOCrXhviWzC9XBVbRc 5IHQ== X-Gm-Message-State: ANhLgQ0vsOLLYI8HRPzZoIGZHVIYh5yZ0Q+1yzGJhGX1CBcGkvs0NiW3 ODavpIFwfwqe9Q/McWUv2IWy2wG+R8EdFZXOkXg5UdZ1 X-Google-Smtp-Source: ADFU+vsk2ugFuPDUC6oiifflC0YGhvImLdFSXF9AQLJa/dK9z3tBu2yp+4GfYJl62uwywHFl1dtr7SZYrEO73YnxWi4= X-Received: by 2002:a25:ccce:: with SMTP id l197mr2896832ybf.127.1585618863423; Mon, 30 Mar 2020 18:41:03 -0700 (PDT) MIME-Version: 1.0 References: <202003301422.02UEMrxL059978@repo.freebsd.org> In-Reply-To: <202003301422.02UEMrxL059978@repo.freebsd.org> From: Li-Wen Hsu Date: Tue, 31 Mar 2020 09:40:51 +0800 Message-ID: Subject: Re: svn commit: r359436 - in head/sys: kern net sys To: Mark Johnston Cc: src-committers , svn-src-all , svn-src-head Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 48rsfb0PcNz3DSp X-Spamd-Bar: ----- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-6.00 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; REPLY(-4.00)[]; TAGGED_FROM(0.00)[] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 31 Mar 2020 01:48:10 -0000 On Mon, Mar 30, 2020 at 10:32 PM Mark Johnston wrote: > > Author: markj > Date: Mon Mar 30 14:22:52 2020 > New Revision: 359436 > URL: https://svnweb.freebsd.org/changeset/base/359436 > > Log: > Simplify taskqgroup inititialization. > > taskqgroup initialization was broken into two steps: > > 1. allocate the taskqgroup structure, at SI_SUB_TASKQ; > 2. initialize taskqueues, start taskqueue threads, enqueue "binder" > tasks to bind threads to specific CPUs, at SI_SUB_SMP. > > Step 2 tries to handle the case where tasks have already been attached > to a queue, by migrating them to their intended queue. In particular, > tasks can't be enqueued before step 2 has completed. This breaks NFS > mountroot on systems using an iflib-based driver when EARLY_AP_STARTUP > is not defined, since mountroot happens before SI_SUB_SMP in this case. > > Simplify initialization: do all initialization except for CPU binding at > SI_SUB_TASKQ. This means that until CPU binding is completed, group > tasks may be executed on a CPU other than that to which they were bound, > but this should not be a problem for existing users of the taskqgroup > KPIs. > > Reported by: sbruno > Tested by: bdragon, sbruno > MFC after: 1 month > Sponsored by: The FreeBSD Foundation > Differential Revision: https://reviews.freebsd.org/D24188 > > Modified: > head/sys/kern/subr_gtaskqueue.c > head/sys/net/iflib.c > head/sys/sys/gtaskqueue.h Hi Mark, I see many "panic: deadlres_td_sleep_q: possible deadlock detected" in the CI after this commit: https://ci.freebsd.org/job/FreeBSD-head-amd64-test/14738/consoleFull https://ci.freebsd.org/job/FreeBSD-head-amd64-test/14739/consoleFull https://ci.freebsd.org/job/FreeBSD-head-amd64-test/14741/consoleFull https://ci.freebsd.org/job/FreeBSD-head-amd64-test/14742/consoleFull https://ci.freebsd.org/job/FreeBSD-head-amd64-test/14743/console https://ci.freebsd.org/job/FreeBSD-head-amd64-test/14744/consoleFull It seems could be triggered by sys.netinet6.frag6.* sys.netpfil.common.* sbin.pfctl.pfctl_test.* tests, and there are lots of test cases timed out. Can you help check these? Thanks, Li-Wen