From owner-cvs-src@FreeBSD.ORG  Sat Sep 27 16:00:56 2008
Return-Path: <owner-cvs-src@FreeBSD.ORG>
Delivered-To: cvs-src@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id C29631065691;
	Sat, 27 Sep 2008 16:00:56 +0000 (UTC) (envelope-from rik@inse.ru)
Received: from mail.inse.ru (mail.inse.ru [144.206.128.1])
	by mx1.freebsd.org (Postfix) with ESMTP id 759068FC0C;
	Sat, 27 Sep 2008 16:00:56 +0000 (UTC) (envelope-from rik@inse.ru)
Received: from www.inse.ru (www.inse.ru [144.206.128.1])
	by mail.inse.ru (Postfix) with ESMTPSA id 213C733C51;
	Sat, 27 Sep 2008 20:00:55 +0400 (MSD)
Message-ID: <48DE575E.70706@localhost.inse.ru>
Date: Sat, 27 Sep 2008 19:55:10 +0400
From: Roman Kurakin <rik@inse.ru>
User-Agent: Thunderbird 2.0.0.16 (X11/20080723)
MIME-Version: 1.0
To: Ganbold <ganbold@micom.mng.net>
References: <200809271430.m8REUkDV034473@repoman.freebsd.org>	<48DE49E8.2060602@micom.mng.net>
	<48DE4C09.5050903@localhost.inse.ru>
	<48DE5409.6060704@micom.mng.net>
In-Reply-To: <48DE5409.6060704@micom.mng.net>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: Roman Kurakin <rik@FreeBSD.org>, cvs-src@FreeBSD.org,
	src-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/sbin/ipfw ipfw2.c
X-BeenThere: cvs-src@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src>
List-Post: <mailto:cvs-src@freebsd.org>
List-Help: <mailto:cvs-src-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 27 Sep 2008 16:00:56 -0000

Ganbold wrote:
> Roman,
>
> Roman Kurakin wrote:
>> Ganbold wrote:
>>> Roman Kurakin wrote:
>>>> rik         2008-09-27 14:30:34 UTC
>>>>
>>>>   FreeBSD src repository
>>>>
>>>>   Modified files:
>>>>     sbin/ipfw            ipfw2.c   Log:
>>>>   SVN rev 183407 on 2008-09-27 14:30:34Z by rik
>>>>     Add keyword all in addtion to the table number for the 'list' 
>>>> and the
>>>>   'flush' actions on tables.  Part of PR: 127058.
>>>>   
>>>
>>> Thanks a lot, Roman.
>> With the last one just committed the all parts of PR should now be done.
>> So please test all the parts (also 'table all flush' as a bonus) and 
>> I will close
>> the PR.
> ...
> cc -O2 -pipe  -fstack-protector -Wno-pointer-sign -c 
> /usr/src/sbin/ipfw/ipfw2.c
> /usr/src/sbin/ipfw/ipfw2.c: In function 'table_handler':
> /usr/src/sbin/ipfw/ipfw2.c:5969: error: too few arguments to function 
> 'table_list'
> *** Error code 1
>
> Stop in /usr/src/sbin/ipfw.
Fixed, thanks. Hate manual merge via cut & paste. Pointy hat to me.

rik
>
>
> You forgot to add is_all as argument to table_list():
> ...
>    } else if (_substrcmp(*av, "list") == 0) {
>        a = is_all ? tables_max : (ent.tbl + 1);
>        do {
>          table_list(ent, is_all);
>                                ^^^^
>        } while (++ent.tbl < a);
>    } else
> ...
>
> Corrected version works, lists all tables' IP and flushes all.
> Will check man page shortly.
>
> thanks,
>
> Ganbold
>
>>
>> rik
>>> Ganbold
>>>
>>>>     PR:             127058 (based on)
>>>>   MFC after:      1 month
>>>>     Revision  Changes    Path
>>>>   1.129     +29 -8     src/sbin/ipfw/ipfw2.c
>>>> _______________________________________________
>>>> cvs-all@freebsd.org mailing list
>>>> http://lists.freebsd.org/mailman/listinfo/cvs-all
>>>> To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
>>>>
>>>>
>>>>
>>>>   
>>>
>>
>> _______________________________________________
>> cvs-all@freebsd.org mailing list
>> http://lists.freebsd.org/mailman/listinfo/cvs-all
>> To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
>>
>>
>>
>
>