Date: Wed, 18 Sep 2024 23:10:27 -0400 From: Adam Weinberger <adamw@adamw.org> To: Po-Chuan Hsieh <sunpoet@freebsd.org> Cc: ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: c41e1ace8e98 - main - ftp/curl: Add LIBUV option Message-ID: <CAP7rwcjH5vs-eKtM8=nmfbB9nh_9YPrktfubY7Jt1FL6nMvU_g@mail.gmail.com> In-Reply-To: <202409180619.48I6J0G7032519@gitrepo.freebsd.org> References: <202409180619.48I6J0G7032519@gitrepo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--000000000000a7292506227044ed Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Wed, Sep 18, 2024 at 2:19=E2=80=AFAM Po-Chuan Hsieh <sunpoet@freebsd.org= > wrote: > The branch main has been updated by sunpoet: > > URL: > https://cgit.FreeBSD.org/ports/commit/?id=3Dc41e1ace8e986493e3fc0b22fa046= 1aa098182e0 > > commit c41e1ace8e986493e3fc0b22fa0461aa098182e0 > Author: Po-Chuan Hsieh <sunpoet@FreeBSD.org> > AuthorDate: 2024-09-18 05:55:59 +0000 > Commit: Po-Chuan Hsieh <sunpoet@FreeBSD.org> > CommitDate: 2024-09-18 06:13:08 +0000 > > ftp/curl: Add LIBUV option > --- > ftp/curl/Makefile | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/ftp/curl/Makefile b/ftp/curl/Makefile > index 0eebfd2224dd..8bacab43595b 100644 > --- a/ftp/curl/Makefile > +++ b/ftp/curl/Makefile > @@ -41,7 +41,7 @@ CPE_VENDOR=3D haxx > > SHEBANG_FILES=3D */*.pl > > -OPTIONS_DEFINE=3D ALTSVC BROTLI COOKIES CURL_DEBUG DEBUG DOCS > EXAMPLES IDN IPV6 NTLM PROXY PSL STATIC TLS_SRP ZSTD > +OPTIONS_DEFINE=3D ALTSVC BROTLI COOKIES CURL_DEBUG DEBUG DOCS > EXAMPLES IDN IPV6 LIBUV NTLM PROXY PSL STATIC TLS_SRP ZSTD > OPTIONS_GROUP=3D PROTOCOL > OPTIONS_RADIO=3D SSL > OPTIONS_SINGLE=3D GSSAPI RESOLV > @@ -123,6 +123,8 @@ LIBSSH_CONFIGURE_WITH=3D libssh > LIBSSH_LIB_DEPENDS=3D libssh.so:security/libssh > LIBSSH2_CONFIGURE_WITH=3D libssh2 > LIBSSH2_LIB_DEPENDS=3D libssh2.so:security/libssh2 > +LIBUV_CONFIGURE_WITH=3D libuv > +LIBUV_LIB_DEPENDS=3D libuv.so:devel/libuv > MQTT_CONFIGURE_ENABLE=3D mqtt > NTLM_CONFIGURE_ENABLE=3D ntlm > OPENSSL_CONFIGURE_ON=3D --with-ca-fallback > Hi, Po-Chuan! There's no description for this new LIBUV option, so I was unclear what libuv did for Curl. In upstream's configure.ac, it has this: dnl ********************************************************************** dnl libuv is only ever used for debug purposes dnl ********************************************************************** ... if test X"$want_libuv" !=3D Xno; then if test x$want_debug !=3D xyes; then AC_MSG_ERROR([Using libuv without debug support enabled is useless]) fi So, the LIBUV option *must* be used with the DEBUG option. If linking against libuv is going to be important for end-users, we probably want LIBUV_IMPLIES=3DDEBUG. # Adam --=20 Adam Weinberger adamw@adamw.org https://www.adamw.org --000000000000a7292506227044ed Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable <div dir=3D"ltr"><div dir=3D"ltr"><div class=3D"gmail_default" style=3D"fon= t-family:arial,sans-serif">On Wed, Sep 18, 2024 at 2:19=E2=80=AFAM Po-Chuan= Hsieh <<a href=3D"mailto:sunpoet@freebsd.org">sunpoet@freebsd.org</a>&g= t; wrote:</div></div><div class=3D"gmail_quote"><blockquote class=3D"gmail_= quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,= 204);padding-left:1ex">The branch main has been updated by sunpoet:<br> <br> URL: <a href=3D"https://cgit.FreeBSD.org/ports/commit/?id=3Dc41e1ace8e98649= 3e3fc0b22fa0461aa098182e0" rel=3D"noreferrer" target=3D"_blank">https://cgi= t.FreeBSD.org/ports/commit/?id=3Dc41e1ace8e986493e3fc0b22fa0461aa098182e0</= a><br> <br> commit c41e1ace8e986493e3fc0b22fa0461aa098182e0<br> Author:=C2=A0 =C2=A0 =C2=A0Po-Chuan Hsieh <sunpoet@FreeBSD.org><br> AuthorDate: 2024-09-18 05:55:59 +0000<br> Commit:=C2=A0 =C2=A0 =C2=A0Po-Chuan Hsieh <sunpoet@FreeBSD.org><br> CommitDate: 2024-09-18 06:13:08 +0000<br> <br> =C2=A0 =C2=A0 ftp/curl: Add LIBUV option<br> ---<br> =C2=A0ftp/curl/Makefile | 4 +++-<br> =C2=A01 file changed, 3 insertions(+), 1 deletion(-)<br> <br> diff --git a/ftp/curl/Makefile b/ftp/curl/Makefile<br> index 0eebfd2224dd..8bacab43595b 100644<br> --- a/ftp/curl/Makefile<br> +++ b/ftp/curl/Makefile<br> @@ -41,7 +41,7 @@ CPE_VENDOR=3D=C2=A0 =C2=A0haxx<br> <br> =C2=A0SHEBANG_FILES=3D */*.pl<br> <br> -OPTIONS_DEFINE=3D=C2=A0 =C2=A0 =C2=A0 =C2=A0 ALTSVC BROTLI COOKIES CURL_DE= BUG DEBUG DOCS EXAMPLES IDN IPV6 NTLM PROXY PSL STATIC TLS_SRP ZSTD<br> +OPTIONS_DEFINE=3D=C2=A0 =C2=A0 =C2=A0 =C2=A0 ALTSVC BROTLI COOKIES CURL_DE= BUG DEBUG DOCS EXAMPLES IDN IPV6 LIBUV NTLM PROXY PSL STATIC TLS_SRP ZSTD<b= r> =C2=A0OPTIONS_GROUP=3D PROTOCOL<br> =C2=A0OPTIONS_RADIO=3D SSL<br> =C2=A0OPTIONS_SINGLE=3D=C2=A0 =C2=A0 =C2=A0 =C2=A0 GSSAPI RESOLV<br> @@ -123,6 +123,8 @@ LIBSSH_CONFIGURE_WITH=3D=C2=A0 =C2=A0 =C2=A0 libssh<br> =C2=A0LIBSSH_LIB_DEPENDS=3D=C2=A0 =C2=A0 libssh.so:security/libssh<br> =C2=A0LIBSSH2_CONFIGURE_WITH=3D=C2=A0 =C2=A0 =C2=A0 =C2=A0 libssh2<br> =C2=A0LIBSSH2_LIB_DEPENDS=3D=C2=A0 =C2=A0libssh2.so:security/libssh2<br> +LIBUV_CONFIGURE_WITH=3D=C2=A0 libuv<br> +LIBUV_LIB_DEPENDS=3D=C2=A0 =C2=A0 =C2=A0libuv.so:devel/libuv<br> =C2=A0MQTT_CONFIGURE_ENABLE=3D mqtt<br> =C2=A0NTLM_CONFIGURE_ENABLE=3D ntlm<br> =C2=A0OPENSSL_CONFIGURE_ON=3D=C2=A0 --with-ca-fallback<br> </blockquote></div><br clear=3D"all"><div style=3D"font-family:arial,sans-s= erif" class=3D"gmail_default">Hi, Po-Chuan!</div><div style=3D"font-family:= arial,sans-serif" class=3D"gmail_default"><br></div><div style=3D"font-fami= ly:arial,sans-serif" class=3D"gmail_default">There's no description for= this new LIBUV option, so I was unclear what libuv did for Curl. In upstre= am's <a href=3D"http://configure.ac">configure.ac</a>, it has this:</di= v><div style=3D"font-family:arial,sans-serif" class=3D"gmail_default"><br><= /div><div style=3D"font-family:arial,sans-serif" class=3D"gmail_default">dn= l **********************************************************************<br= >dnl libuv is only ever used for debug purposes<br>dnl ********************= **************************************************<br></div><div><br></div>= <div><div style=3D"font-family:arial,sans-serif" class=3D"gmail_default">..= .</div><div style=3D"font-family:arial,sans-serif" class=3D"gmail_default">= <br></div><div style=3D"font-family:arial,sans-serif" class=3D"gmail_defaul= t">if test X"$want_libuv" !=3D Xno; then<br>=C2=A0 if test x$want= _debug !=3D xyes; then<br>=C2=A0 =C2=A0 AC_MSG_ERROR([Using libuv without d= ebug support enabled is useless])<br>=C2=A0 fi</div><div style=3D"font-fami= ly:arial,sans-serif" class=3D"gmail_default"><br></div><div style=3D"font-f= amily:arial,sans-serif" class=3D"gmail_default">So, the LIBUV option *must*= be used with the DEBUG option. If linking against libuv is going to be imp= ortant for end-users, we probably want LIBUV_IMPLIES=3DDEBUG.</div><div sty= le=3D"font-family:arial,sans-serif" class=3D"gmail_default"><br></div><div = style=3D"font-family:arial,sans-serif" class=3D"gmail_default"># Adam</div>= <div style=3D"font-family:arial,sans-serif" class=3D"gmail_default"><br></d= iv><br></div><span class=3D"gmail_signature_prefix">-- </span><br><div dir= =3D"ltr" class=3D"gmail_signature"><div dir=3D"ltr"><div><div dir=3D"ltr"><= div>Adam Weinberger</div><div><a href=3D"mailto:adamw@adamw.org" target=3D"= _blank">adamw@adamw.org</a></div><div><a href=3D"https://www.adamw.org" tar= get=3D"_blank">https://www.adamw.org</a></div></div></div></div></div></div= > --000000000000a7292506227044ed--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAP7rwcjH5vs-eKtM8=nmfbB9nh_9YPrktfubY7Jt1FL6nMvU_g>