From owner-svn-src-head@FreeBSD.ORG Tue Jun 15 20:40:49 2010 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id B87BA1065672; Tue, 15 Jun 2010 20:40:49 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from cyrus.watson.org (cyrus.watson.org [65.122.17.42]) by mx1.freebsd.org (Postfix) with ESMTP id 892628FC19; Tue, 15 Jun 2010 20:40:49 +0000 (UTC) Received: from bigwig.baldwin.cx (66.111.2.69.static.nyinternet.net [66.111.2.69]) by cyrus.watson.org (Postfix) with ESMTPSA id 305B946C32; Tue, 15 Jun 2010 16:40:49 -0400 (EDT) Received: from jhbbsd.localnet (smtp.hudson-trading.com [209.249.190.9]) by bigwig.baldwin.cx (Postfix) with ESMTPSA id 646558A03C; Tue, 15 Jun 2010 16:40:48 -0400 (EDT) From: John Baldwin To: Jack Vogel Date: Tue, 15 Jun 2010 16:40:43 -0400 User-Agent: KMail/1.12.1 (FreeBSD/7.3-CBSD-20100217; KDE/4.3.1; amd64; ; ) References: <201006112054.o5BKsRk8087302@svn.freebsd.org> <201006151549.09210.jhb@freebsd.org> In-Reply-To: MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Message-Id: <201006151640.43739.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.0.1 (bigwig.baldwin.cx); Tue, 15 Jun 2010 16:40:48 -0400 (EDT) X-Virus-Scanned: clamav-milter 0.95.1 at bigwig.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-2.5 required=4.2 tests=AWL,BAYES_00 autolearn=ham version=3.2.5 X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on bigwig.baldwin.cx Cc: Jack F Vogel , svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r209068 - head/sys/dev/e1000 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 15 Jun 2010 20:40:49 -0000 On Tuesday 15 June 2010 4:18:49 pm Jack Vogel wrote: > Ahhh, thanks for report John, will fix that asap. I actually just tested a patch to make it use que->tq and que->task always instead of the rxtx_task. I have some other patches to cleanup some of the taskq stuff as well, I'll send it along once I've done some testing with em(4). > Jack > > > On Tue, Jun 15, 2010 at 12:49 PM, John Baldwin wrote: > > > On Friday 11 June 2010 4:54:27 pm Jack F Vogel wrote: > > > Author: jfv > > > Date: Fri Jun 11 20:54:27 2010 > > > New Revision: 209068 > > > URL: http://svn.freebsd.org/changeset/base/209068 > > > > > > Log: > > > Add a couple fixes from Michael Tuexen. > > > Remove unneeded rxtx handler, make que handler generic. > > > Do not allocate header mbufs in rx ring if not doing hdr split. > > > Release the lock in rxeof call to stack. > > > > > > MFC for 8.1 asap > > > > This causes a panic with MSIX is disabled (boot with > > hw.pci.msix_enabled=0). > > The reason is that in the !MSIX case, the rxtx_task is queued to the > > adapter->tq queue, but in the MSIX case the task is queued to the per- queue > > que->tq queue. igb_handle_que() assumes the MSIX case, it is not generic. > > > > -- > > John Baldwin > > > -- John Baldwin