From owner-dev-commits-src-main@freebsd.org Wed Jul 28 16:37:32 2021 Return-Path: Delivered-To: dev-commits-src-main@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 60B9C65F681 for ; Wed, 28 Jul 2021 16:37:32 +0000 (UTC) (envelope-from shawn.webb@hardenedbsd.org) Received: from mail-qt1-x833.google.com (mail-qt1-x833.google.com [IPv6:2607:f8b0:4864:20::833]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4GZfTS1nGwz3RBK for ; Wed, 28 Jul 2021 16:37:32 +0000 (UTC) (envelope-from shawn.webb@hardenedbsd.org) Received: by mail-qt1-x833.google.com with SMTP id k13so1767661qth.10 for ; Wed, 28 Jul 2021 09:37:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hardenedbsd.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=kuzIqyzHrMJhalv53ocYPw4ZLYICaIWBfe2tcLntNbg=; b=L8LZ56NDeaDS4ECRIKEtIarUanJmEIPL6HFje178y5oTn9ONtEPndVCkgEKkYn1HjC mpyGH98KgVHbxYzvbh8+uCy7pnmpGlRnTnFYfDiRlEmbMzf1zeHlt15VHiKhwSOnQyt4 uyFgYudbwxpSJ8IMjvGv+QtyCNEap4N9Y874bpfgzluW2E9tlZ8Cczo3KWmos51Zx2U8 BPi11A/HJOXz3I+8cvbFCeYa38HpXunO0AjFkqQblDqM0SW8r5wEU6Ans9k4rx3S7CLz h5XVZ39f7X0Lynowiy7H1WATNB8tC8xbquZCe0FGUCjvnd5EeMqaCLzf2b7vAqIZyRSZ incg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=kuzIqyzHrMJhalv53ocYPw4ZLYICaIWBfe2tcLntNbg=; b=SdivXWOjQW4CrS6juA3oGqDt7Ys54hKObKFrGIwmwCYebXG5fEJdTjWBJDHV5dMe0m wGW4WmO9NISXpTwpSbq8dkYtfj3kqWvb1Ykcw4OYL6obgZfx70zHVU5atSc6f6pd/2AJ UCS/gaVxFUwek97l60ZvN+UMjz4rD642mxUlRF8WKA5BUa0YGF5qBwk8GGk8ZXW8gQ9t uUuM7Hh0P/8axnPAfaFQ+EVq1ywkZJ4Tg+6xcpPjh2bm7OTsIbj8uucEh4fMNglMKEtd HvN1aaDKlo0oPNXwF9GvoGIrP3RHoKqRwh+2JBDnT0+L88ZAYD9hB5vuE0MKkMefQAKX dV5Q== X-Gm-Message-State: AOAM532EO/AOf6JbKr2o4h5pzGYLyQnXfhKZ1+0t9DgJqlzWEk42SreZ ldm8SN+/+30H0kSqjqJ6bX30Ow== X-Google-Smtp-Source: ABdhPJwUk3SA08SuWTVzs2kC9wuROgDuP/uXVp0ucwIeZK1lJgjGWLvq5lFg+FMO46awJbgxKkoJ0w== X-Received: by 2002:a05:622a:1805:: with SMTP id t5mr395845qtc.340.1627490246400; Wed, 28 Jul 2021 09:37:26 -0700 (PDT) Received: from mutt-hbsd (pool-100-16-224-136.bltmmd.fios.verizon.net. [100.16.224.136]) by smtp.gmail.com with ESMTPSA id f10sm158344qto.31.2021.07.28.09.37.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 Jul 2021 09:37:25 -0700 (PDT) Date: Wed, 28 Jul 2021 12:37:25 -0400 From: Shawn Webb To: Kevin Bowling Cc: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Subject: Re: git: 7045b1603bdf - main - socket: Implement SO_RERROR Message-ID: <20210728163725.6qzqbvwynoeua2jo@mutt-hbsd> X-Operating-System: FreeBSD mutt-hbsd 14.0-CURRENT-HBSD FreeBSD 14.0-CURRENT-HBSD X-PGP-Key: https://git.hardenedbsd.org/hardenedbsd/pubkeys/-/blob/master/Shawn_Webb/03A4CBEBB82EA5A67D9F3853FF2E67A277F8E1FA.pub.asc References: <202107281635.16SGZHdx081512@gitrepo.freebsd.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="inqfsygufoaszgwn" Content-Disposition: inline In-Reply-To: <202107281635.16SGZHdx081512@gitrepo.freebsd.org> X-Rspamd-Queue-Id: 4GZfTS1nGwz3RBK X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-BeenThere: dev-commits-src-main@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commit messages for the main branch of the src repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 28 Jul 2021 16:37:32 -0000 --inqfsygufoaszgwn Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Jul 28, 2021 at 04:35:17PM +0000, Kevin Bowling wrote: > The branch main has been updated by kbowling (ports committer): >=20 > URL: https://cgit.FreeBSD.org/src/commit/?id=3D7045b1603bdf054145dd958a4a= cc17b410fb62a0 >=20 > commit 7045b1603bdf054145dd958a4acc17b410fb62a0 > Author: Roy Marples > AuthorDate: 2021-07-28 15:46:59 +0000 > Commit: Kevin Bowling > CommitDate: 2021-07-28 16:35:09 +0000 >=20 > socket: Implement SO_RERROR > =20 > SO_RERROR indicates that receive buffer overflows should be handled as > errors. Historically receive buffer overflows have been ignored and > programs could not tell if they missed messages or messages had been > truncated because of overflows. Since programs historically do not > expect to get receive overflow errors, this behavior is not the > default. > =20 > This is really really important for programs that use route(4) to keep > in sync with the system. If we loose a message then we need to reload > the full system state, otherwise the behaviour from that point is > undefined and can lead to chasing bogus bug reports. > =20 > Reviewed by: philip (network), kbowling (transport), gbe (manpages) > MFC after: 2 weeks > Differential Revision: https://reviews.freebsd.org/D26652 > --- > lib/libc/sys/getsockopt.2 | 10 +++++++- > sbin/route/route.c | 13 +++++++++- > sys/kern/uipc_sockbuf.c | 24 +++++++++++++++++ > sys/kern/uipc_socket.c | 30 ++++++++++++++++= ------ > sys/kern/uipc_usrreq.c | 2 +- > sys/net/raw_usrreq.c | 11 ++++---- > .../bluetooth/socket/ng_btsocket_hci_raw.c | 1 + > sys/netgraph/ng_socket.c | 2 +- > sys/netinet/ip_divert.c | 2 +- > sys/netinet/ip_mroute.c | 2 +- > sys/netinet/raw_ip.c | 3 +-- > sys/netinet/udp_usrreq.c | 2 +- > sys/netinet6/icmp6.c | 6 ++--- > sys/netinet6/ip6_input.c | 1 + > sys/netinet6/ip6_mroute.c | 3 ++- > sys/netinet6/raw_ip6.c | 2 ++ > sys/netinet6/send.c | 2 +- > sys/netinet6/udp6_usrreq.c | 2 +- > sys/netipsec/keysock.c | 10 ++++---- > sys/sys/socket.h | 1 + > sys/sys/socketvar.h | 6 ++++- > 21 files changed, 100 insertions(+), 35 deletions(-) Hey Kevin, Would this commit be a good candidate for bumping __FreeBSD_version? Thanks, --=20 Shawn Webb Cofounder / Security Engineer HardenedBSD https://git.hardenedbsd.org/hardenedbsd/pubkeys/-/raw/master/Shawn_Webb/03A= 4CBEBB82EA5A67D9F3853FF2E67A277F8E1FA.pub.asc --inqfsygufoaszgwn Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEA6TL67gupaZ9nzhT/y5nonf44foFAmEBh8IACgkQ/y5nonf4 4fqpvw//eEP0BDGwrWTi2EsPmYDFiffnKkMiKBn30pXgOsyLyFdu1fUkiLQ8BH7n 3P0hNidpIGparuBwdgf34S2tOuz9ZW6iMmvc/RXq3D/lfl9t7wLowfZkAhzXq1zu lt4uxt7jM82LuZ+n1401eHKlnszVHO0bXJ7DMmc8xa8TFy9caAevvWoszCIYxayX LJZ10C4fws56DchCFZyJ8cG3iPwsDuqvLsSIIxhzHtxNKaALPzg/0HwlfRn7xOGN wuj+w2O1CUos/t7Z5732PbsNvYWr6955+msm14CbW5hfzcDGlMt4H7Zf0bpoQTwZ BJlnu3nwgUwvJ4yiLUq/fYnkajqcgRG844vuU0Gdpn5wo38BU3kGNCBpT/z0FlPW nxox1+LKDeMqi7Eh9lxzy6rUeiivsCL9K/4/yyzp2B2RM8E/7fr0uv3wX1MmLe/i YgRglWUmCDEs6XHuUh5YesDyBwpxoZxNcqsRMN5QIEAcyCe+O4eNsLaOuz9CFLvB o8ZjW18twwX70EQF0fNm2tygseQftELJBalAFhg5lTpniunRj5LbWFMgFivvXsAt UHHeS9X1fX8mvCP0XsFKfE53TzymwE+lmCvmF6g2Epeyc0LCkHmIeh2u5iIGICIU lB1czd85/Xp5X7nVDdsbMaW6ltpmLNm8vbwXLuhfpErA1ORDWzU= =EiqY -----END PGP SIGNATURE----- --inqfsygufoaszgwn--