From owner-freebsd-current@FreeBSD.ORG Thu May 8 12:36:46 2008 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 19945106567A for ; Thu, 8 May 2008 12:36:46 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from elvis.mu.org (elvis.mu.org [192.203.228.196]) by mx1.freebsd.org (Postfix) with ESMTP id 06BAD8FC15 for ; Thu, 8 May 2008 12:36:45 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from zion.baldwin.cx (unknown [208.65.91.234]) by elvis.mu.org (Postfix) with ESMTP id 9ACB01A4D8F; Thu, 8 May 2008 05:36:45 -0700 (PDT) From: John Baldwin To: freebsd-current@freebsd.org, josh.carroll@gmail.com Date: Thu, 8 May 2008 08:37:11 -0400 User-Agent: KMail/1.9.7 References: <8cb6106e0805062004r681045b5ge2981ae73e777a49@mail.gmail.com> In-Reply-To: <8cb6106e0805062004r681045b5ge2981ae73e777a49@mail.gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200805080837.11744.jhb@freebsd.org> Cc: Subject: Re: panic mounting ntfs X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 08 May 2008 12:36:46 -0000 On Tuesday 06 May 2008 11:04:44 pm Josh Carroll wrote: > In doing some data recovery for my brother-in-law, I tried to mount > his win2k partition (NTFS), and the box immediately panic'd. I dd'd > the partition and was able to mount it on my 7.0-RELEASE box (via > mdconfig -t vnode ...), but trying to do that on the -CURRENT box also > panic'd. > > panic: Assertion (flags & ~LK_INIT_MASK) == 0 failed at > /usr/src/sys/kern/kern_lock.c:298 > > And here's the backtrace: > > #13 0xc54a6b00 in ntfs_ntlookup (ntmp=0xc5467800, ino=0, > ipp=0xe79a47f4) at > /usr/src/sys/modules/ntfs/../../fs/ntfs/ntfs_subr.c:408 This should fix it: Index: ntfs_subr.c =================================================================== RCS file: /host/cvs/usr/cvs/src/sys/fs/ntfs/ntfs_subr.c,v retrieving revision 1.45 diff -u -r1.45 ntfs_subr.c --- ntfs_subr.c 13 Feb 2008 13:02:12 -0000 1.45 +++ ntfs_subr.c 8 May 2008 12:36:10 -0000 @@ -405,7 +405,7 @@ VREF(ip->i_devvp); /* init lock and lock the newborn ntnode */ - lockinit(&ip->i_lock, PINOD, "ntnode", 0, LK_EXCLUSIVE); + lockinit(&ip->i_lock, PINOD, "ntnode", 0, 0); mtx_init(&ip->i_interlock, "ntnode interlock", NULL, MTX_DEF); ntfs_ntget(ip); -- John Baldwin