From owner-freebsd-current@freebsd.org Sun Oct 25 15:00:43 2015 Return-Path: Delivered-To: freebsd-current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id B4C878E97 for ; Sun, 25 Oct 2015 15:00:43 +0000 (UTC) (envelope-from theraven@FreeBSD.org) Received: from theravensnest.org (theraven.freebsd.your.org [216.14.102.27]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "cloud.theravensnest.org", Issuer "StartCom Class 1 Primary Intermediate Server CA" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 8596415B1; Sun, 25 Oct 2015 15:00:42 +0000 (UTC) (envelope-from theraven@FreeBSD.org) Received: from [192.168.0.7] (cpc16-cmbg15-2-0-cust60.5-4.cable.virginm.net [86.5.162.61]) (authenticated bits=0) by theravensnest.org (8.15.2/8.15.2) with ESMTPSA id t9PF0Usi036123 (version=TLSv1 cipher=ECDHE-RSA-AES256-SHA bits=256 verify=NO); Sun, 25 Oct 2015 15:00:34 GMT (envelope-from theraven@FreeBSD.org) X-Authentication-Warning: theravensnest.org: Host cpc16-cmbg15-2-0-cust60.5-4.cable.virginm.net [86.5.162.61] claimed to be [192.168.0.7] Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 8.2 \(2104\)) Subject: Re: dtc(1): reproducible segmentation fault From: David Chisnall In-Reply-To: <20151024230750.GB5266@barney.uniridge.com.au> Date: Sun, 25 Oct 2015 15:00:25 +0000 Cc: Ian Lepore , freebsd-current@freebsd.org Content-Transfer-Encoding: quoted-printable Message-Id: References: <562A3FE5.8020809@uniridge.com.au> <1445618437.91534.13.camel@freebsd.org> <2D772151-85F9-4D80-8074-58CD11FFF778@FreeBSD.org> <20151024230750.GB5266@barney.uniridge.com.au> To: George Abdelmalik X-Mailer: Apple Mail (2.2104) X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 25 Oct 2015 15:00:43 -0000 On 25 Oct 2015, at 00:07, George Abdelmalik = wrote: >=20 > You've beaten me to it with the fix before I could lodge the bug = report :) >=20 > In your repo I've seen that the mmap(2) call now takes the MAP_PRIVATE = flag. I > applied that change locally to my source tree and that has fixed the = problem. > I've since re-read the mmap(2) man page to find out how that change = could > be influential... >=20 > [EINVAL] None of MAP_ANON, MAP_PRIVATE, MAP_SHARED, or > MAP_STACK was specified. At least one of these = flags > must be included. >=20 > Although obvious to me now, I missed it on my previous reads. >=20 > Thanks for your assistance. I look forward to your coming set of = changes. In > my view DTC is an important tool and I would be willing contribute = effort to > making it feature parity with the GPL version if that is lacking. It=E2=80=99s now committed (r289935). Sorry for the delay - I meant to = commit the changes in January and it slipped down my to-do list. Please do test with any dts files that you have. If you find bugs, then = please report them and assign them to me. David