From owner-freebsd-rc@FreeBSD.ORG  Sat Jan  7 22:42:26 2012
Return-Path: <owner-freebsd-rc@FreeBSD.ORG>
Delivered-To: freebsd-rc@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 92583106566B;
	Sat,  7 Jan 2012 22:42:26 +0000 (UTC)
	(envelope-from pawel@dawidek.net)
Received: from mail.dawidek.net (60.wheelsystems.com [83.12.187.60])
	by mx1.freebsd.org (Postfix) with ESMTP id 422728FC13;
	Sat,  7 Jan 2012 22:42:26 +0000 (UTC)
Received: from localhost (89-73-195-149.dynamic.chello.pl [89.73.195.149])
	by mail.dawidek.net (Postfix) with ESMTPSA id 61E38348;
	Sat,  7 Jan 2012 23:42:24 +0100 (CET)
Date: Sat, 7 Jan 2012 23:41:17 +0100
From: Pawel Jakub Dawidek <pjd@FreeBSD.org>
To: Doug Barton <dougb@FreeBSD.org>
Message-ID: <20120107224116.GB1674@garage.freebsd.pl>
References: <20120106141301.GE1693@garage.freebsd.pl>
	<4F079A76.3030306@FreeBSD.org>
	<20120107112538.GC1696@garage.freebsd.pl>
	<4F08C95F.6040808@FreeBSD.org>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="JP+T4n/bALQSJXh8"
Content-Disposition: inline
In-Reply-To: <4F08C95F.6040808@FreeBSD.org>
X-OS: FreeBSD 9.0-CURRENT amd64
User-Agent: Mutt/1.5.21 (2010-09-15)
Cc: freebsd-rc@FreeBSD.org
Subject: Re: Making use of set_rcvar.
X-BeenThere: freebsd-rc@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: "Discussion related to /etc/rc.d design and implementation."
	<freebsd-rc.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-rc>,
	<mailto:freebsd-rc-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-rc>
List-Post: <mailto:freebsd-rc@freebsd.org>
List-Help: <mailto:freebsd-rc-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-rc>,
	<mailto:freebsd-rc-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 07 Jan 2012 22:42:26 -0000


--JP+T4n/bALQSJXh8
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Sat, Jan 07, 2012 at 02:38:23PM -0800, Doug Barton wrote:
> On 01/07/2012 03:25, Pawel Jakub Dawidek wrote:
> > On Fri, Jan 06, 2012 at 05:05:58PM -0800, Doug Barton wrote:
> >> On 01/06/2012 06:13, Pawel Jakub Dawidek wrote:
> >>> Any objections?
> >>>
> >>> 	http://people.freebsd.org/~pjd/patches/set_rcvar.patch
> >>>
> >>> This patch only changes scripts where set_rcvar can be used with no
> >>> arguments.
> >>
> >> Please don't do this.
> >>
> >> Jilles already pointed out the important reason, it adds pointless
> >> forks. I suggested a long time ago that we remove set_rcvar altogether
> >> but I got a lot of resistance to it, and never pursued it. Perhaps it's
> >> time to revisit that.
> >=20
> > It is a total mess now then and it is definiately not intuitive when
> > there are much more bad examples than good ones:
>=20
> I agree, which is why I previously proposed assigning them all directly
> when possible (which is in almost all cases). If no one speaks up
> opposing this idea in the next few days I'm still prepared to proceed.

Don't forget to update documentation (rc(8)).

--=20
Pawel Jakub Dawidek                       http://www.wheelsystems.com
FreeBSD committer                         http://www.FreeBSD.org
Am I Evil? Yes, I Am!                     http://yomoli.com

--JP+T4n/bALQSJXh8
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.14 (FreeBSD)

iEYEARECAAYFAk8IygwACgkQForvXbEpPzSbWACfasMixEirDarFsJWARZvgNGNf
VosAn2BP+IZDHHl0/7Mu7A69mlWTm8oD
=/w1p
-----END PGP SIGNATURE-----

--JP+T4n/bALQSJXh8--