From owner-freebsd-net@FreeBSD.ORG  Mon Mar  2 00:02:08 2015
Return-Path: <owner-freebsd-net@FreeBSD.ORG>
Delivered-To: freebsd-net@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 139FCC16
 for <freebsd-net@freebsd.org>; Mon,  2 Mar 2015 00:02:08 +0000 (UTC)
Received: from phabric-backend.isc.freebsd.org
 (phabric-backend.isc.freebsd.org [IPv6:2001:4f8:3:ffe0:406a:0:50:2])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id E8E60902
 for <freebsd-net@freebsd.org>; Mon,  2 Mar 2015 00:02:07 +0000 (UTC)
Received: from phabric-backend.isc.freebsd.org
 (phabric-backend.isc.freebsd.org [127.0.1.5])
 by phabric-backend.isc.freebsd.org (8.14.9/8.14.9) with ESMTP id
 t22027at014294
 for <freebsd-net@freebsd.org>; Mon, 2 Mar 2015 00:02:07 GMT
 (envelope-from root@phabric-backend.isc.freebsd.org)
Received: (from root@localhost)
 by phabric-backend.isc.freebsd.org (8.14.9/8.14.9/Submit) id t22027dX014293;
 Mon, 2 Mar 2015 00:02:07 GMT (envelope-from root)
Date: Mon, 2 Mar 2015 00:02:07 +0000
To: freebsd-net@freebsd.org
From: "rstone (Ryan Stone)" <phabric-noreply@FreeBSD.org>
Subject: [Differential] [Commented On] D1986: Teach lagg(4) to change MTU
Message-ID: <ac88c5358f8d1af7cba79d144f29fa51@localhost.localdomain>
X-Priority: 3
Thread-Topic: D1986: Teach lagg(4) to change MTU
X-Herald-Rules: none
X-Phabricator-To: <PHID-USER-gxjszcyr3icxaytfydyu>
X-Phabricator-To: <PHID-USER-vtlauz4uwe46gac4fu2j>
X-Phabricator-Cc: <PHID-USER-e73re76ob52gi4vjprnd>
X-Phabricator-Cc: <PHID-MLST-c3bj6mfydtlqmuethodc>
In-Reply-To: <differential-rev-PHID-DREV-i34kfg4qpajia7fo5u5l-req@FreeBSD.org>
References: <differential-rev-PHID-DREV-i34kfg4qpajia7fo5u5l-req@FreeBSD.org>
Thread-Index: ODZhMzNlYThiYzMxOTgzYmRhMDE5M2Q2Yzk4IFTzqH8=
X-Phabricator-Sent-This-Message: Yes
X-Mail-Transport-Agent: MetaMTA
X-Auto-Response-Suppress: All
X-Phabricator-Mail-Tags: <differential-comment>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain; charset="utf-8"
X-BeenThere: freebsd-net@freebsd.org
X-Mailman-Version: 2.1.18-1
Precedence: list
List-Id: Networking and TCP/IP with FreeBSD <freebsd-net.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-net>,
 <mailto:freebsd-net-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-net/>
List-Post: <mailto:freebsd-net@freebsd.org>
List-Help: <mailto:freebsd-net-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
 <mailto:freebsd-net-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 02 Mar 2015 00:02:08 -0000

rstone added inline comments.

INLINE COMMENTS
  sys/net/if_lagg.c:1772 style(9) says to not include unnecessary braces (which I personally disagree with, but what can you do?)
  sys/net/if_lagg.c:1773 style(9): put brackets around the return value:
  
  return (0);
  sys/net/if_lagg.c:1811 I find the flow control here a bit confusing (my first read through, I thought that err2 could be used unitinialized).  Given that you have a continue in the if block, I would find it clearer to not have an else here

REVISION DETAIL
  https://reviews.freebsd.org/D1986

To: rpokala-panasas.com, rstone
Cc: ae, freebsd-net