From owner-cvs-all Mon Jan 28 15:33:50 2002 Delivered-To: cvs-all@freebsd.org Received: from dragon.nuxi.com (trang.nuxi.com [66.92.13.169]) by hub.freebsd.org (Postfix) with ESMTP id F068C37B416; Mon, 28 Jan 2002 15:33:43 -0800 (PST) Received: (from obrien@localhost) by dragon.nuxi.com (8.11.6/8.11.1) id g0SNXhi73023; Mon, 28 Jan 2002 15:33:43 -0800 (PST) (envelope-from obrien) Date: Mon, 28 Jan 2002 15:33:43 -0800 From: "David O'Brien" To: Greg Lehey Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/vinum vinumconfig.c vinumioctl.c Message-ID: <20020128153343.A72981@dragon.nuxi.com> Reply-To: obrien@FreeBSD.org References: <200201270420.g0R4KrU26853@freefall.freebsd.org> <20020127145356.C41130@wantadilla.lemis.com> <20020128102214.A69546@dragon.nuxi.com> <20020129093645.H83297@wantadilla.lemis.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5i In-Reply-To: <20020129093645.H83297@wantadilla.lemis.com>; from grog@FreeBSD.org on Tue, Jan 29, 2002 at 09:36:45AM +1030 X-Operating-System: FreeBSD 5.0-CURRENT Organization: The NUXI BSD group X-Pgp-Rsa-Fingerprint: B7 4D 3E E9 11 39 5F A3 90 76 5D 69 58 D9 98 7A X-Pgp-Rsa-Keyid: 1024/34F9F9D5 Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Tue, Jan 29, 2002 at 09:36:45AM +1030, Greg Lehey wrote: > On Monday, 28 January 2002 at 10:22:14 -0800, David O'Brien wrote: > > On Sun, Jan 27, 2002 at 02:53:56PM +1030, Greg Lehey wrote: > >> On Saturday, 26 January 2002 at 20:20:53 -0800, Greg Lehey wrote: > >>> grog 2002/01/26 20:20:53 PST > >>> > >>> Modified files: > >>> sys/dev/vinum vinumconfig.c vinumioctl.c > >>> Log: > >>> vinumioctl: Fix a double fault caused by calling setjmp() without holding the config lock. The call was in fact superfluous. > >>> > >>> Revision Changes Path > >>> 1.44 +3 -1 src/sys/dev/vinum/vinumconfig.c > >>> 1.32 +0 -3 src/sys/dev/vinum/vinumioctl.c > >> > >> Grrr. Wrong text. Should be: > > > > > > cvs ci -f ??? > > Not worth it for what I had to add. Why not and how can you tell??? If it was worth it to send a follow up email (as you must have felt the information useful to *someone*) -- it is certainly proper to get that same correction in the logs. Else someone that looks at the logs 2 years from now will either forgotten or never saw the email I replied to. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message