From owner-p4-projects@FreeBSD.ORG Sun Apr 23 23:00:20 2006 Return-Path: X-Original-To: p4-projects@freebsd.org Delivered-To: p4-projects@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 32767) id 0F37A16A40E; Sun, 23 Apr 2006 23:00:20 +0000 (UTC) X-Original-To: perforce@freebsd.org Delivered-To: perforce@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id E283916A400 for ; Sun, 23 Apr 2006 23:00:19 +0000 (UTC) (envelope-from kabaev@gmail.com) Received: from wproxy.gmail.com (wproxy.gmail.com [64.233.184.238]) by mx1.FreeBSD.org (Postfix) with ESMTP id E4A9143D48 for ; Sun, 23 Apr 2006 23:00:18 +0000 (GMT) (envelope-from kabaev@gmail.com) Received: by wproxy.gmail.com with SMTP id i12so910781wra for ; Sun, 23 Apr 2006 16:00:18 -0700 (PDT) DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:date:from:to:cc:subject:message-id:in-reply-to:references:x-mailer:mime-version:content-type; b=eQVc7dATEoapEJNRlfsSOe5qIfRu4A+9lHQu8HPk1B+5imHhYoD5+IoZUVLBQ53MKHECxQeedHP1bDdQq47kkJwthw+Bk7kWIUxhWi/KpejTyTCQzPvyyy7XKXfEdWse7KxIRYghncqjTKUQR/0lQHTj9Q6cV1jCtxluaEurwY0= Received: by 10.54.110.5 with SMTP id i5mr3902100wrc; Sun, 23 Apr 2006 16:00:18 -0700 (PDT) Received: from kan.dnsalias.net ( [24.63.93.195]) by mx.gmail.com with ESMTP id 39sm3078399wrl.2006.04.23.16.00.16; Sun, 23 Apr 2006 16:00:17 -0700 (PDT) Date: Sun, 23 Apr 2006 19:00:06 -0400 From: Alexander Kabaev To: John Birrell Message-ID: <20060423190006.4b9a1587@kan.dnsalias.net> In-Reply-To: <200604232039.k3NKdqvq057837@repoman.freebsd.org> References: <200604232039.k3NKdqvq057837@repoman.freebsd.org> X-Mailer: Sylpheed-Claws 2.0.0 (GTK+ 2.8.16; i386-portbld-freebsd7.0) Mime-Version: 1.0 Content-Type: multipart/signed; boundary="Sig_9M8F/Ngu+8z3C4U5uoSayHk"; protocol="application/pgp-signature"; micalg=PGP-SHA1 Cc: Perforce Change Reviews Subject: Re: PERFORCE change 95947 for review X-BeenThere: p4-projects@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: p4 projects tree changes List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 23 Apr 2006 23:00:20 -0000 --Sig_9M8F/Ngu+8z3C4U5uoSayHk Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable On Sun, 23 Apr 2006 20:39:52 GMT John Birrell wrote: > http://perforce.freebsd.org/chv.cgi?CH=3D95947 >=20 > Change 95947 by jb@jb_freebsd2 on 2006/04/23 20:39:34 >=20 > Go back to just using the /dev/dtrace device name and clone > from that name explicitly. > =09 > Add a (temporary) debug flag for the device flags so that I > can sort out what each device is doing in the kernel. >=20 > Affected files ... >=20 > .. //depot/projects/dtrace/src/contrib/opensolaris/lib/libdtrace/common/d= t_open.c#8 > edit .. //depot/projects/dtrace/src/sys/sys/fcntl.h#2 edit >=20 > Differences ... >=20 > =3D=3D=3D=3D //depot/projects/dtrace/src/contrib/opensolaris/lib/libdtrac= e/common/dt_open.c#8 > (text) =3D=3D=3D=3D >=20 > @@ -922,7 +922,7 @@ > #if defined(sun) > dtfd =3D open("/dev/dtrace/dtrace", O_RDWR); > #else > - dtfd =3D open("/dev/dtrace0", O_RDWR); > + dtfd =3D open("/dev/dtrace", O_RDWR | O_DEBUG); > #endif > err =3D errno; /* save errno from opening dtfd */ > =20 >=20 > =3D=3D=3D=3D //depot/projects/dtrace/src/sys/sys/fcntl.h#2 (text+ko) =3D= =3D=3D=3D >=20 > @@ -113,6 +113,7 @@ > /* Attempt to bypass buffer cache */ > #define O_DIRECT 0x00010000 > #endif > +#define O_DEBUG 0x00020000 > =20 > /* > * XXX missing O_DSYNC, O_RSYNC. Nothing stops you from recognizing names with slashes in your clone event handler, so this defined(sun) is probably unnecessary. --=20 Alexander Kabaev --Sig_9M8F/Ngu+8z3C4U5uoSayHk Content-Type: application/pgp-signature; name=signature.asc Content-Disposition: attachment; filename=signature.asc -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.2.2 (FreeBSD) iD8DBQFETAb/Q6z1jMm+XZYRAt+fAJ9xVUik8tKibuMVG4rud67sgRYzvwCgoHUB /m7KnXZyT4JmlzfpcM0fIMs= =2El4 -----END PGP SIGNATURE----- --Sig_9M8F/Ngu+8z3C4U5uoSayHk--