From nobody Fri Oct 7 17:15:10 2022 X-Original-To: fs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4MkZgf4hRzz4V1gr for <fs@mlmmj.nyi.freebsd.org>; Fri, 7 Oct 2022 17:15:10 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4MkZgf3hghz3Hvr for <fs@FreeBSD.org>; Fri, 7 Oct 2022 17:15:10 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4MkZgf2m7Bzg1j for <fs@FreeBSD.org>; Fri, 7 Oct 2022 17:15:10 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 297HFAUi057369 for <fs@FreeBSD.org>; Fri, 7 Oct 2022 17:15:10 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 297HFAJX057368 for fs@FreeBSD.org; Fri, 7 Oct 2022 17:15:10 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: fs@FreeBSD.org Subject: [Bug 266236] ZFS NFS : .zfs/snapshot : Stale file handle Date: Fri, 07 Oct 2022 17:15:10 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 13.1-STABLE X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Many People X-Bugzilla-Who: florian.millet@laposte.net X-Bugzilla-Status: Open X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: fs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: <bug-266236-3630-JML3f6V7LH@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-266236-3630@https.bugs.freebsd.org/bugzilla/> References: <bug-266236-3630@https.bugs.freebsd.org/bugzilla/> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Filesystems <freebsd-fs.freebsd.org> List-Archive: https://lists.freebsd.org/archives/freebsd-fs List-Help: <mailto:freebsd-fs+help@freebsd.org> List-Post: <mailto:freebsd-fs@freebsd.org> List-Subscribe: <mailto:freebsd-fs+subscribe@freebsd.org> List-Unsubscribe: <mailto:freebsd-fs+unsubscribe@freebsd.org> Sender: owner-freebsd-fs@freebsd.org MIME-Version: 1.0 ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1665162910; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=NJeCzuEvMwMWpy3COJjHjCGsf4VfzR5AcSTLPXGCUgc=; b=Rl00y2J6Ovby2sUmP1cAuOzLXYvv4mYjbNM7ZeLelQeRyo3gMbPKr+wCTD+cNbOhhtrGPC SbVjU2Th8Rv+V5FaBHOfN5FFBr1iTogvfb+bXNJx67l0o8LhfmAJl5DZXdXIp5xxp0o8+X +dWBkAM0OgW8/vMh9UFzUdSqJ1KzZhFOJmrg1wAU4uEhQAp8wUJTS6SY9LfhKRqjPwSt6V /PCbwd/ULeEZAH34HD5LW0lOMyLMDSLRIPAPjM+Iwmmkxa+lMLo0mxDyqNWyUtYNMvX7BX GHQn7I3qoKHiGuy78EWWvoUqHRU5e7HrKY20glRTpgFRMp+w3+IAOu7DX0Ry6A== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1665162910; a=rsa-sha256; cv=none; b=pngV0Y9PsCxFT8Z6TJjSVk9rAePcrKA/O6WCGLmXeXiPXmnFjYhQGhkPcUQnwK9fUOfRTB XSwSpEWJO365uD+qnNEBT/3gn7T7jDRFkq8awc1MyPctCP36p4kJHHXy3UPKwKMOhZNh8I 1SF3AkkZ8Fln6ynARt95Pu79bYejI8gAfot/j6+7KUEgPjJh4r1PWxn/+v7kYFh5VwBR+O IgMu+lEr9J4PSlO3lWcE4+EXkueSsHfQXrlLHLn3I5GJbYGfTAhPEXm0vh9SGMvAIxJebS mKuEoCkyw9o9PN3Ap/Aoi57yvNWR4pZXqxWp5IAMcL9iR1KiWXt96X8hV8SXPw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D266236 --- Comment #22 from florian.millet@laposte.net --- (In reply to Mark Johnston from comment #21) I tried this : diff --git a/sys/contrib/openzfs/module/os/freebsd/zfs/zfs_vfsops.c b/sys/contrib/openzfs/module/os/freebsd/zfs/zfs_vfsops.c index cdd762dcbcbf..05d41d4e3b2a 100644 --- a/sys/contrib/openzfs/module/os/freebsd/zfs/zfs_vfsops.c +++ b/sys/contrib/openzfs/module/os/freebsd/zfs/zfs_vfsops.c @@ -1845,7 +1845,8 @@ zfs_fhtovp(vfs_t *vfsp, fid_t *fidp, int flags, vnode= _t **vpp) return (SET_ERROR(EINVAL)); } - if (fidp->fid_len =3D=3D LONG_FID_LEN && (fid_gen > 1 || setgen != =3D 0)) { + if (fidp->fid_len =3D=3D LONG_FID_LEN && setgen !=3D 0) { + ZFS_EXIT(zfsvfs); dprintf("snapdir fid: fid_gen (%llu) and setgen (%llu)\n", (u_longlong_t)fid_gen, (u_longlong_t)setgen); return (SET_ERROR(EINVAL)); --=20 You are receiving this mail because: You are the assignee for the bug.=