From nobody Tue Feb 3 17:20:22 2026 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4f59Gv23YPz6QS23 for ; Tue, 03 Feb 2026 17:20:23 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R13" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4f59Gt4ysSz3G3j for ; Tue, 03 Feb 2026 17:20:22 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1770139222; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=OZvw/r7KnGOcAs6MaBdYujkemZDKYgs37KRl4/lKnFs=; b=deH2F0DWYD76DxvCRf6BF4urRxCPuwcxdyYQrLkCN3SlO99iTxiCdi6MDBSaj0YAkbTV+p Tsg5x5evIxpL3HO7LQpAxEX2YJfp2pLD3YimwGtuvW54RSB0XCZ1ictELMeSGw2meQKfTQ E689coEuiRj6DJqhIthyg0acJD6y6hMbFmGbyCv16Vzy9RKgudT2wWrsWm98w+dIddCeA+ t6z82Ff59slmJSNUINkyk0ROJhhM+E3xnFYtl/SSg/hPrgKMefQRqmT2sLfrl7V6IjpItI zoQdkQTLM+7LY3DjX2pgVw+sSs/C9EJz1/8u3ddiaGkkmmNpNnQm6k8ccUQftg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1770139222; a=rsa-sha256; cv=none; b=Vjb1tdTyvx1G1LS0ZGTS31bxbCBX/jMrQETbRcfZO6lintbuucwW5tCJcT7G2Lr4rvUuxm XkNT1Jw2mEWPxVz540kSXTgE9O9mernT9yEtDRmhXEzJlXnb4oI5Tr+PYj3EApMNPHnOfh gWplBHFnQV1pd/FGtYDnF1lZl405yidluEYB0ucq/jtbnqMU5P7q1KAPfzIR3c5KgQvNwf 8jKtp0QuDwe+bT2f5PLeTh9WyZvsoS/VMLo98puErkfWM3MIA7esNN55z/2LBNHcKJdgH0 cKmNOM4eSWgWnVkfvXPGW1UN68dFoUelbQ16v+uCYmvYGGiWHLki0FD660GMVg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1770139222; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=OZvw/r7KnGOcAs6MaBdYujkemZDKYgs37KRl4/lKnFs=; b=kmmBvktdCvxKRp3VaDF65IdM6tUvn/FVoT9mGbUc5BOdVkxZlrmxOTbDLZSQ5emicsVEDA 5mEX9RDYo5cYEsGAAXgAdZXxDtQgkLowrtnXIU2Ug3Qlr61vIYkjqicQ2hMfmJEdB2lsjw Bwj8aldTCfmjq+egs+moBxPTZtzqTMlcntYzki+m1ze1Z7mjVDU7CWzuVIIbTJk9dfjkTQ JRHXlFv8y1MRbsZtdt+0+vS4qsIOxygP68HEJVkEVVGXhi7/L4/0BaWbl9x5j3xi8O72p3 pFpzFsRbZJlHdYSaiQCamRC3Eflx0t2+QSHHJWYmsEf1FLfijEkhvBQXLLN6eA== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4f59Gt4SCgz737 for ; Tue, 03 Feb 2026 17:20:22 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 1f55b by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Tue, 03 Feb 2026 17:20:22 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Olivier Certner Subject: git: e401e6d3fc91 - main - acpi: 'hw.acpi.s4bios' sysctl: Change type to bool, expand description List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: olce X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: e401e6d3fc91679b16c5cfa4c473dcb8fcadacfa Auto-Submitted: auto-generated Date: Tue, 03 Feb 2026 17:20:22 +0000 Message-Id: <69822e56.1f55b.24bf4aaf@gitrepo.freebsd.org> The branch main has been updated by olce: URL: https://cgit.FreeBSD.org/src/commit/?id=e401e6d3fc91679b16c5cfa4c473dcb8fcadacfa commit e401e6d3fc91679b16c5cfa4c473dcb8fcadacfa Author: Olivier Certner AuthorDate: 2026-01-09 09:53:39 +0000 Commit: Olivier Certner CommitDate: 2026-02-03 17:19:08 +0000 acpi: 'hw.acpi.s4bios' sysctl: Change type to bool, expand description Another boolean, indicating hardware support, will be introduced in next commit. Thanks to the previous commit modifying sysctl_handle_bool(), this change is backwards-compatible with old programs using an integer in and out of sysctl(3). Reviewed by: obiwac MFC after: 2 weeks Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D54626 --- sys/dev/acpica/acpi.c | 6 +++--- sys/dev/acpica/acpivar.h | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/sys/dev/acpica/acpi.c b/sys/dev/acpica/acpi.c index 47bb47bfb0af..58ddb0a83922 100644 --- a/sys/dev/acpica/acpi.c +++ b/sys/dev/acpica/acpi.c @@ -626,7 +626,7 @@ acpi_attach(device_t dev) /* Only enable S4BIOS by default if the FACS says it is available. */ if (AcpiGbl_FACS != NULL && AcpiGbl_FACS->Flags & ACPI_FACS_S4_BIOS_PRESENT) - sc->acpi_s4bios = 1; + sc->acpi_s4bios = true; /* * Probe all supported ACPI sleep states. Awake (S0) is always supported, @@ -754,9 +754,9 @@ acpi_attach(device_t dev) SYSCTL_ADD_INT(&sc->acpi_sysctl_ctx, SYSCTL_CHILDREN(sc->acpi_sysctl_tree), OID_AUTO, "sleep_delay", CTLFLAG_RW, &sc->acpi_sleep_delay, 0, "sleep delay in seconds"); - SYSCTL_ADD_INT(&sc->acpi_sysctl_ctx, SYSCTL_CHILDREN(sc->acpi_sysctl_tree), + SYSCTL_ADD_BOOL(&sc->acpi_sysctl_ctx, SYSCTL_CHILDREN(sc->acpi_sysctl_tree), OID_AUTO, "s4bios", CTLFLAG_RW, &sc->acpi_s4bios, 0, - "Use S4BIOS when hibernating."); + "On hibernate, have the firmware save/restore the machine state (S4BIOS)."); SYSCTL_ADD_INT(&sc->acpi_sysctl_ctx, SYSCTL_CHILDREN(sc->acpi_sysctl_tree), OID_AUTO, "verbose", CTLFLAG_RW, &sc->acpi_verbose, 0, "verbose mode"); SYSCTL_ADD_INT(&sc->acpi_sysctl_ctx, SYSCTL_CHILDREN(sc->acpi_sysctl_tree), diff --git a/sys/dev/acpica/acpivar.h b/sys/dev/acpica/acpivar.h index eea54178060f..51881c580d4b 100644 --- a/sys/dev/acpica/acpivar.h +++ b/sys/dev/acpica/acpivar.h @@ -64,7 +64,7 @@ struct acpi_softc { enum power_stype acpi_lid_switch_stype; int acpi_standby_sx; - int acpi_s4bios; + bool acpi_s4bios; int acpi_sleep_delay; int acpi_do_disable;