From owner-cvs-all@FreeBSD.ORG Mon Dec 5 12:32:21 2005 Return-Path: X-Original-To: cvs-all@FreeBSD.org Delivered-To: cvs-all@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id EE80E16A41F; Mon, 5 Dec 2005 12:32:21 +0000 (GMT) (envelope-from marius@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id BC81343D49; Mon, 5 Dec 2005 12:32:21 +0000 (GMT) (envelope-from marius@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id jB5CWLwT015823; Mon, 5 Dec 2005 12:32:21 GMT (envelope-from marius@repoman.freebsd.org) Received: (from marius@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id jB5CWLP3015822; Mon, 5 Dec 2005 12:32:21 GMT (envelope-from marius) Message-Id: <200512051232.jB5CWLP3015822@repoman.freebsd.org> From: Marius Strobl Date: Mon, 5 Dec 2005 12:32:20 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/dev/dc if_dc.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 05 Dec 2005 12:32:22 -0000 marius 2005-12-05 12:32:20 UTC FreeBSD src repository Modified files: sys/dev/dc if_dc.c Log: - Rev. 1.175 fixed compilation on sparc64 but also backed out zeroing of the eaddr array (introduced in rev. 1.174) prior to writing to it. As dc_read_eeprom() is told to write only 3 16-bit words to eaddr but eaddr in fact is somewhat larger removal of the zeroing defeated the check whether the MAC address is all zero as there can be some random garbage in eaddr past the 3 words written to it and the check verifys all bits in eaddr. Solve this by changing the check to verify only the 3 words (happenning to be ETHER_ADDR_LEN bytes) written to eaddr. - While here change the notation of "FCode" in a nearby comment to the official way. Ok'ed by: marcel, ru Revision Changes Path 1.176 +2 -5 src/sys/dev/dc/if_dc.c