From owner-cvs-all Tue Feb 12 9:40:38 2002 Delivered-To: cvs-all@freebsd.org Received: from rover.village.org (rover.bsdimp.com [204.144.255.66]) by hub.freebsd.org (Postfix) with ESMTP id B2CE737B41F; Tue, 12 Feb 2002 09:40:20 -0800 (PST) Received: from harmony.village.org (harmony.village.org [10.0.0.6]) by rover.village.org (8.11.3/8.11.3) with ESMTP id g1CHari51302; Tue, 12 Feb 2002 10:36:53 -0700 (MST) (envelope-from imp@village.org) Received: from localhost (warner@rover2.village.org [10.0.0.1]) by harmony.village.org (8.11.6/8.11.6) with ESMTP id g1CHaqL81692; Tue, 12 Feb 2002 10:36:53 -0700 (MST) (envelope-from imp@village.org) Date: Tue, 12 Feb 2002 10:36:47 -0700 (MST) Message-Id: <20020212.103647.55833195.imp@village.org> To: grog@FreeBSD.org Cc: joe@FreeBSD.org, cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/usb usbdi.c From: "M. Warner Losh" In-Reply-To: <20020212073707.N670@sydney.worldwide.lemis.com> References: <200202111009.g1BA9UP67888@freefall.freebsd.org> <20020212073707.N670@sydney.worldwide.lemis.com> X-Mailer: Mew version 2.1 on Emacs 21.1 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG In message: <20020212073707.N670@sydney.worldwide.lemis.com> Greg Lehey writes: : On Monday, 11 February 2002 at 2:09:30 -0800, Josef Karthauser wrote: : > joe 2002/02/11 02:09:30 PST : > : > Modified files: : > sys/dev/usb usbdi.c : > Log: : > Merge from NetBSD: revs 1.89 and 1.90. : > : > Also, add some 'const's to supress warnings. (Submitted back to NetBSD). : > : > The original logs from NetBSD: : > : > ---------------------------- : > revision 1.90 : > date: 2001/12/03 01:47:12; author: augustss; lines: +4 -4 : > Handle vendor/product lookup with a common routine. : > ---------------------------- : > revision 1.89 : > date: 2001/12/02 23:25:25; author: augustss; lines: +18 -2 : > Add a subroutine to search for a vendor/product pair. : > ---------------------------- : : I like this form of log message. What do other people think? I think it is a little too long for my tastes, which is why I tend to do it like so: Catch up to NetBSD: 1.156 pooka; Socket Low-Power CF WLAN 1.155 ichiro; IBM Smart Capture Card II 1.152-154 ichiro; Fujitsu CF EtherCard and FMV-181,182,182A 1.151 christos; Symbol Spectrum24 which gives people a pointer to NetBSD to look at the detailed log messages, gives proper credit to the folks on NetBSD that did the commit and saves us from having N useless ----- lines. :-) However, I don't object to it if someone wants to do it. Warner To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message