Date: Wed, 31 Oct 2012 17:55:07 +0100 From: Pietro Cerutti <gahr@FreeBSD.org> To: Joseph a Nagy Jr <jnagyjr1978@gmail.com> Cc: ports@freebsd.org, Chris Rees <utisoft@gmail.com> Subject: Re: tk85 Port Maintenance Message-ID: <20121031165507.GF90275@gahrfit.gahr.ch> In-Reply-To: <50915194.6010101@gmail.com> References: <509121B3.3040307@gmail.com> <20121031135749.GC90275@gahrfit.gahr.ch> <50913253.3060700@gmail.com> <20121031152109.GD90275@gahrfit.gahr.ch> <CADLo83_VSLt5t31bJbu3-UCuGkNuNnnBEbMXWVd2fhvVwryP5g@mail.gmail.com> <20121031153958.GE90275@gahrfit.gahr.ch> <50915194.6010101@gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--0z5c7mBtSy1wdr4F
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
On 2012-Oct-31, 11:28, Joseph a Nagy Jr wrote:
> On 10/31/12 10:39, Pietro Cerutti wrote:
> <snip>
> >> patch < tk85.diff
> > Hmm... Looks like a unified diff to me...
> > The text leading up to this was:
> > --------------------------
> > |--- Makefile.orig 2012-10-26 19:47:37.000000000 -0500
> > |+++ Makefile 2012-10-29 20:16:13.000000000 -0500
> > --------------------------
> > Patching file Makefile using Plan A...
> > Reversed (or previously applied) patch detected! Assume -R? [y] n
> > Apply anyway? [n] y
> > Hunk #1 failed at 1.
> > Hunk #2 failed at 7.
> > Hunk #3 failed at 40.
> > Hunk #4 failed at 58.
> > Hunk #5 failed at 420.
> > 5 out of 5 hunks failed--saving rejects to Makefile.rej
> > done
> >=20
>=20
> New diff[0], undoing some of the earlier changes even though portlint
> complains:
>=20
> portlint ~/port-maintenance/tk85/
> WARN: Makefile: unless this is a master port, COMMENT has to be set by
> "=3D", not by "?=3D".
This *is* a master port, so it's ok to have COMMENT?=3D
> WARN: Makefile: "LIB_DEPENDS" has to appear earlier.
This should be fixed as portlint suggests.
> WARN: Makefile: no port directory
> /usr/ports/lang/tcl${SHORT_TK_VER}-thread found, even though it is
> listed in LIB_DEPENDS.
I would try and use USE_TCL instead of LIB_DEPENDS here
> WARN: Makefile: LIB_DEPENDS don't specify the ABI version number .2 in
> Xft.2 unless it is really necessary.
This should be fixed as portlint suggests.
> 0 fatal errors and 4 warnings found.
>=20
> [0]: http://pastebin.com/apf1Y9H0
I'll have a look at it on Friday, thanks!
--=20
Pietro Cerutti
The FreeBSD Project
gahr@FreeBSD.org
PGP Public Key:
http://gahr.ch/pgp
--0z5c7mBtSy1wdr4F
Content-Type: application/pgp-signature
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.19 (FreeBSD)
iEYEARECAAYFAlCRV+IACgkQwMJqmJVx945hjwCeNYDCuB1x9g1mmEc1B9hoHPRk
fr4An0oLjDXbEOJuHoXIH4OTWojrahFA
=cANT
-----END PGP SIGNATURE-----
--0z5c7mBtSy1wdr4F--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20121031165507.GF90275>