Date: Fri, 4 Aug 2006 16:29:53 +0000 From: Prafulla Deuskar <pdeuskar@FreeBSD.org> To: Andre Oppermann <andre@freebsd.org> Cc: cvs-src@FreeBSD.org, Gleb Smirnoff <glebius@FreeBSD.org>, cvs-all@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/em if_em.c if_em.h Message-ID: <20060804162953.GA24414@hub.freebsd.org> In-Reply-To: <44D36B4B.4050605@freebsd.org> References: <200608031905.k73J55D2061870@repoman.freebsd.org> <20060804095414.GU96644@FreeBSD.org> <20060804143825.GA8797@hub.freebsd.org> <44D36B4B.4050605@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Andre Oppermann [andre@freebsd.org] wrote: > Prafulla Deuskar wrote: > >Gleb Smirnoff [glebius@FreeBSD.org] wrote: > >> Prafulla, > >> > >>On Thu, Aug 03, 2006 at 07:05:05PM +0000, Prafulla Deuskar wrote: > >>P> pdeuskar 2006-08-03 19:05:05 UTC > >>P> > >>P> FreeBSD src repository > >>P> > >>P> Modified files: > >>P> sys/dev/em if_em.c if_em.h > >>P> Log: > >>P> Revert back changes to made in rev 1.109 of if_em.c which were > >>unnecessary. > >>P> This makes it easier for us to get the changes into -current and to > >>-stable quickly. > >> > >>Can you please confirm that this was a mechanical substitution like this: > >> > >>s/sc/adapter/g > >>s/em_softc/adapter/g > >> > >>and no more additional changes? If this is true, then I hope that we > >>(FreeBSD and Intel) have finally came to a common codebase. This is good. > >>:) > >>I can stand the long unusual name for driver softc with no problems. > >> > >>I'm only a bit disappointed by the fact, that I haven't received a single > >>email about these plans. You were in the void for a long time, and > >>then began your work with a commit, w/o informing people who were > >>maintaining driver while the vendor maintanance was on a hiatus. > >> > > > >Yes - it was a mechanical substitution. > > According to jb@freebsd.org at least one non-mechanical change slipped > in breaking his Sun4v box. AFAIR some fix in/with bus_dmamap_unload() > was reverted. I have looked at the diffs again after jb@ mentioned it last night. I don't think I have made any functionality changes. Thanks, Prafulla >
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20060804162953.GA24414>