Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 15 Jan 2015 06:46:31 -0800
From:      "Chris H" <bsd-lists@bsdforge.com>
To:        Kurt Jaeger <lists@opsec.eu>
Cc:        FreeBSD Ports Mailing List <ports@freebsd.org>, John Hein <john.hein@microsemi.com>
Subject:   Re: sysutils/bbcp: Anyone interesting in helping upgrade this port?
Message-ID:  <0c18c38876c88a9e21cd7e8fc568d545@ultimatedns.net>
In-Reply-To: <20150115082729.GP44537@home.opsec.eu>
References:  <CAOjFWZ5T8g-zOKW8GrNL5u3gtntpYuFhnEFexu1J1DX8V4oOoQ@mail.gmail.com> <daccbf3a5d6a8c35d330ee90979929c0@ultimatedns.net> <CAOjFWZ7zp7q91LbpbdpThRFqoypjjUtsSfMMEgNrpiiTUyPJdg@mail.gmail.com> <3a7891f4c67a054f13f9ba97f7fcd700@ultimatedns.net> <20150113192932.GL44537@home.opsec.eu> <21685.34336.390049.238359@gromit.timing.com> <11d948f20f5fedadc2570d82b6e7ec49@ultimatedns.net> <ad2eba245e13f95c48e3ae1a72abbe45@ultimatedns.net> <c287ca96bf834fb1f939228bfb22c3b3@ultimatedns.net>, <20150115082729.GP44537@home.opsec.eu>

next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, 15 Jan 2015 09:27:29 +0100 Kurt Jaeger <lists@opsec.eu> wrote

> Hi!
> 
> > > So I won't be submitting the pr(1) until tomorrow.
> > OK killed all the errors, rolled up a release, and submitted an
> > svn diff. Please see the pr(1):
> > https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=196746
> 
> Testing @work.
> 
> > The build still emits a fair amount of warnings. but none are
> > show stoppers.
> 
> Indeed, very noisy 8-}
Linux-isms in/from errno.h && quoting issues in newer GCC's,
but mostly CLANG.
> 
> > I'll eliminate all the warnings, for the next version.
> 
> Will you report those upstream ?
As previously mentioned; upstream's code is fairly unmaintained
(messy). In fact, I removed over 3,000 extraneous new-lines from
one source file alone. Committing to maintain a port necessitated
performing a mass code cleanup. If they (upstream) will accept a
git push. Then we can still draw from upstream. Otherwise, I'll
be forced to either
1) cherry-pick from upstream
2) fork/branch && rename the port/project

After I squash the remaining warnings emitted, I submit a push
request, and see where it goes. But it will involve every file
in their source pool. So they may be reluctant. We'll see. :)

Thanks for the prompt commit, and attention to this, Kurt!
> 
> -- 
> pi@opsec.eu            +49 171 3101372                         5 years to go


--Chris

---





Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?0c18c38876c88a9e21cd7e8fc568d545>