From owner-freebsd-hackers Sat Jun 30 4: 5: 5 2001 Delivered-To: freebsd-hackers@freebsd.org Received: from ringworld.nanolink.com (diskworld.nanolink.com [195.24.48.189]) by hub.freebsd.org (Postfix) with SMTP id F019D37B403 for ; Sat, 30 Jun 2001 04:04:42 -0700 (PDT) (envelope-from roam@orbitel.bg) Received: (qmail 2036 invoked by uid 1000); 30 Jun 2001 11:09:08 -0000 Date: Sat, 30 Jun 2001 14:09:07 +0300 From: Peter Pentchev To: Igor Podlesny Cc: freebsd-hackers@FreeBSD.ORG, freebsd-isp@freebsd.org Subject: Re: Flight of the rat, living wreck..... Message-ID: <20010630140907.A947@ringworld.oblivion.bg> Mail-Followup-To: Igor Podlesny , freebsd-hackers@FreeBSD.ORG, freebsd-isp@freebsd.org References: <754836544.20010630185133@morning.ru> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5i In-Reply-To: <754836544.20010630185133@morning.ru>; from poige@morning.ru on Sat, Jun 30, 2001 at 06:51:33PM +0800 Sender: owner-freebsd-hackers@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG No real knowledge of the ipfw code or the motives behind it here, but just a comment.. On Sat, Jun 30, 2001 at 06:51:33PM +0800, Igor Podlesny wrote: [snip] > // so here we start looking through the queue > > > ia != NULL > > // sanity (I'd have written just (ia)) Yep, just (ia) would have worked, but style(9) mandates (ia != NULL), which is much easier to understand and follow at a glance (clearly showing that ia is not a flag, but a pointer). G'luck, Peter -- I am the meaning of this sentence. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-hackers" in the body of the message