From owner-freebsd-current@FreeBSD.ORG Sun Aug 3 08:34:25 2014 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id DCCA08E5 for ; Sun, 3 Aug 2014 08:34:25 +0000 (UTC) Received: from mail-qg0-x232.google.com (mail-qg0-x232.google.com [IPv6:2607:f8b0:400d:c04::232]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 9A9D32D78 for ; Sun, 3 Aug 2014 08:34:25 +0000 (UTC) Received: by mail-qg0-f50.google.com with SMTP id q108so7723932qgd.9 for ; Sun, 03 Aug 2014 01:34:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc:content-type; bh=5j4LFDF6Y1cvVOtdbP+jtClkAr0qdi6YNSEYXPmVq9Y=; b=kqSt/wq0+liwHMw09l8rtbLJwvshiwBMbq7W9/qwSNpPF0IOy4CGoRYZ+tTNZMgAeJ JHhDKi3FNBqO2Z8qJ5IUCmPHpOSTM0USaj6x6Sl7a/PLBjEr/QEgqm36+/z8MLQJgwwc yAk2nfu9VR3zVpPBU8oZe//3TDjRvaU/fTQe5vJ9rx5HC0KR66QY5ZceNu+ccm8rfeuF hAJdzQQvFDz2SAndvCslQJx/p5KMP1/QGkC48mPevEdV2Iq4aJv/GUJ+vkReRROc0SyK 0gARqqqj9AWtNU2GrQlf2r1wRxXIzWY9vozWPBM6h8Lo66smGeegXZi9Jma0noi4fet3 Mr2g== MIME-Version: 1.0 X-Received: by 10.140.92.13 with SMTP id a13mr23693822qge.88.1407054864633; Sun, 03 Aug 2014 01:34:24 -0700 (PDT) Sender: adrian.chadd@gmail.com Received: by 10.224.1.6 with HTTP; Sun, 3 Aug 2014 01:34:24 -0700 (PDT) In-Reply-To: References: <20140801193403.GE50495@funkthat.com> <20140801222118.GH50495@funkthat.com> <20140802183259.GL50495@funkthat.com> <20140802200149.GO50495@funkthat.com> Date: Sun, 3 Aug 2014 01:34:24 -0700 X-Google-Sender-Auth: 1BVHr4TAVeWCQBCrzcWnSWnOg-M Message-ID: Subject: Re: domain_add(xxx) after domainfinalize... From: Adrian Chadd To: Svatopluk Kraus Content-Type: text/plain; charset=UTF-8 Cc: John-Mark Gurney , freebsd-current X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 03 Aug 2014 08:34:25 -0000 On 3 August 2014 01:02, Svatopluk Kraus wrote: > > I agree that the warning is pointless stres for anyone but network domain > developer. And such developer knows if he/she is careful enough to ignore > it. However, I still remember time when I was starting with FreeBSD kernel > development. So much things one should be aware of. In those time, any > however small glue, which could help, was appreciated. So, put the warning > under INVARIANTS or something like that as FreeBSD is open source and > without rookies will die. And no one wants to make kernel development > harder than it is. I think putting it under INVARIANTS and maybe tweaking it to explain why it's a bad idea is .. well, a good idea. Great suggestion! -a