From owner-cvs-release  Thu Mar 19 18:57:01 1998
Return-Path: <owner-cvs-release>
Received: (from daemon@localhost)
          by hub.freebsd.org (8.8.8/8.8.8) id SAA04721
          for cvs-release-outgoing; Thu, 19 Mar 1998 18:57:01 -0800 (PST)
          (envelope-from owner-cvs-release)
Received: from dingo.cdrom.com (dingo.cdrom.com [204.216.28.145])
          by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id SAA04678;
          Thu, 19 Mar 1998 18:56:49 -0800 (PST)
          (envelope-from mike@dingo.cdrom.com)
Received: from dingo.cdrom.com (localhost [127.0.0.1])
	by dingo.cdrom.com (8.8.8/8.8.5) with ESMTP id SAA27548;
	Thu, 19 Mar 1998 18:53:02 -0800 (PST)
Message-Id: <199803200253.SAA27548@dingo.cdrom.com>
X-Mailer: exmh version 2.0zeta 7/24/97
To: "Jordan K. Hubbard" <jkh@time.cdrom.com>
cc: Eivind Eklund <eivind@yes.no>, "Jordan K. Hubbard" <jkh@FreeBSD.org>,
        cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org,
        cvs-release@FreeBSD.org
Subject: Re: cvs commit: src/release/sysinstall disks.c 
In-reply-to: Your message of "Thu, 19 Mar 1998 07:37:04 PST."
             <13801.890321824@time.cdrom.com> 
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Date: Thu, 19 Mar 1998 18:53:02 -0800
From: Mike Smith <mike@smith.net.au>
Sender: owner-cvs-release@FreeBSD.org
X-Loop: FreeBSD.org
Precedence: bulk

> > You wouldn't happen to have a clue how to handle the 're-install on
> > dangerously dedicated' case correctly?  It routinely bite people.
> 
> I'd need a lot more information on how it's biting people.  I wasn't
> aware that there was any problem with this particular scenario
> 
> > This is the case where a disk has only a BSD-bootsector on it, and
> > sysinstall never-the-less write a standard DOS MBR over it (after
> > having put up a requester asking the user if he want to, of course).
> 
> Erm.  So you're saying that the user is asking to be blown away, or
> what exactly?  I'm finding this whole message rather confusing,
> frankly. :(

Sorry if I'm missing context (150 messages down), but the case here is 
when the user is doing an upgrade.

You only set the "don't ask about the MBR" flag when the user hits 'A' 
and answers 'yes' to the "incompatible" question.  If you're upgrading 
a disk that was previously created like this, there's no attempt to 
detect this fact and set the flag accordingly.

A "more correct" approach would be to look at the first disk just 
before putting up the requester, and if the first slice inside the 
whole disk slice starts at block 1 and is a freebsd slice, ie:

	if ((disk->slices != NULL) &&
	    (disk->slices->part != NULL) &&
	    (disk->slices->part->type == freebsd) &&
	    (disk->slices->part->offset == 1)) {
		do-not-ever-install-bootmanager
	}

Finding the "first disk" is a bit of a chore; if wd0 exists use that, 
else use sd0, else forget looking.

Hope that's actually useful.

-- 
\\  Sometimes you're ahead,       \\  Mike Smith
\\  sometimes you're behind.      \\  mike@smith.net.au
\\  The race is long, and in the  \\  msmith@freebsd.org
\\  end it's only with yourself.  \\  msmith@cdrom.com