From owner-freebsd-threads@freebsd.org  Thu Aug  4 19:40:44 2016
Return-Path: <owner-freebsd-threads@freebsd.org>
Delivered-To: freebsd-threads@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id A114ABAFCE2
 for <freebsd-threads@mailman.ysv.freebsd.org>;
 Thu,  4 Aug 2016 19:40:44 +0000 (UTC)
 (envelope-from bugzilla-noreply@freebsd.org)
Received: from kenobi.freebsd.org (kenobi.freebsd.org
 [IPv6:2001:1900:2254:206a::16:76])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 9089111BD
 for <freebsd-threads@FreeBSD.org>; Thu,  4 Aug 2016 19:40:44 +0000 (UTC)
 (envelope-from bugzilla-noreply@freebsd.org)
Received: from bugs.freebsd.org ([127.0.1.118])
 by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id u74Jeikw004135
 for <freebsd-threads@FreeBSD.org>; Thu, 4 Aug 2016 19:40:44 GMT
 (envelope-from bugzilla-noreply@freebsd.org)
From: bugzilla-noreply@freebsd.org
To: freebsd-threads@FreeBSD.org
Subject: [Bug 210093] Redundant sq initialization in kern/subr_sleepqueue
Date: Thu, 04 Aug 2016 19:40:44 +0000
X-Bugzilla-Reason: AssignedTo
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: Base System
X-Bugzilla-Component: kern
X-Bugzilla-Version: CURRENT
X-Bugzilla-Keywords: 
X-Bugzilla-Severity: Affects Many People
X-Bugzilla-Who: jhb@FreeBSD.org
X-Bugzilla-Status: Closed
X-Bugzilla-Resolution: Works As Intended
X-Bugzilla-Priority: ---
X-Bugzilla-Assigned-To: freebsd-threads@FreeBSD.org
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: bug_status cc resolution
Message-ID: <bug-210093-16-WaiA10fbto@https.bugs.freebsd.org/bugzilla/>
In-Reply-To: <bug-210093-16@https.bugs.freebsd.org/bugzilla/>
References: <bug-210093-16@https.bugs.freebsd.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-BeenThere: freebsd-threads@freebsd.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: Threading on FreeBSD <freebsd-threads.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/freebsd-threads>, 
 <mailto:freebsd-threads-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-threads/>
List-Post: <mailto:freebsd-threads@freebsd.org>
List-Help: <mailto:freebsd-threads-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/freebsd-threads>, 
 <mailto:freebsd-threads-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 04 Aug 2016 19:40:44 -0000

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D210093

John Baldwin <jhb@FreeBSD.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|New                         |Closed
                 CC|                            |jhb@FreeBSD.org
         Resolution|---                         |Works As Intended

--- Comment #3 from John Baldwin <jhb@FreeBSD.org> ---
If the INVARIANTS block didn't have to define a variable we probably wouldn=
't
do it twice.  We could fix it but it would have to be a bit uglier:

#ifdef INVARIANTS
   int i;
#endif

   sq =3D td->td_sleepqueue;
#ifdef INVARIANTS
   for (i =3D 0; ...) {
   }
   ...
   sq->sq_lock =3D lock;
#endif
   ...

If our style permitted C99-type 'for (int i' that would be a simple way to
solve it, but it doesn't.

--=20
You are receiving this mail because:
You are the assignee for the bug.=