Date: Wed, 22 Aug 2012 14:44:52 +0300 From: Konstantin Belousov <kostikbel@gmail.com> To: Gleb Smirnoff <glebius@freebsd.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, "Kenneth D. Merry" <ken@freebsd.org> Subject: Re: svn commit: r238990 - in head/sys: net netinet netinet6 Message-ID: <20120822114452.GC33100@deviant.kiev.zoral.com.ua> In-Reply-To: <20120822101705.GL20560@FreeBSD.org> References: <201208021357.q72DvoFJ088426@svn.freebsd.org> <20120821185014.GA28272@nargothrond.kdm.org> <20120822101705.GL20560@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--4ehG9HxkuyoI6jtY Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Aug 22, 2012 at 02:17:05PM +0400, Gleb Smirnoff wrote: > On Tue, Aug 21, 2012 at 12:50:14PM -0600, Kenneth D. Merry wrote: > K> On Thu, Aug 02, 2012 at 13:57:50 +0000, Gleb Smirnoff wrote: > K> > Author: glebius > K> > Date: Thu Aug 2 13:57:49 2012 > K> > New Revision: 238990 > K> > URL: http://svn.freebsd.org/changeset/base/238990 > K> >=20 > K> > Log: > K> > Fix races between in_lltable_prefix_free(), lla_lookup(), > K> > llentry_free() and arptimer(): > K> > =20 > K> > o Use callout_init_rw() for lle timeout, this allows us safely > K> > disestablish them. > K> > - This allows us to simplify the arptimer() and make it > K> > race safe. > K> > o Consistently use ifp->if_afdata_lock to lock access to > K> > linked lists in the lle hashes. > K> > o Introduce new lle flag LLE_LINKED, which marks an entry that > K> > is attached to the hash. > K> > - Use LLE_LINKED to avoid double unlinking via consequent > K> > calls to llentry_free(). > K> > - Mark lle with LLE_DELETED via |=3D operation istead of =3D, > K> > so that other flags won't be lost. > K> > o Make LLE_ADDREF(), LLE_REMREF() and LLE_FREE_LOCKED() more > K> > consistent and provide more informative KASSERTs. > K> > =20 > K> > The patch is a collaborative work of all submitters and myself. > K> > =20 > K> > PR: kern/165863 > K> > Submitted by: Andrey Zonov <andrey zonov.org> > K> > Submitted by: Ryan Stone <rysto32 gmail.com> > K> > Submitted by: Eric van Gyzen <eric_van_gyzen dell.com> > K>=20 > K> I'm running into this on stable/9, any plan on when this will get MFCe= d? >=20 > I'm sorry, but after 9.1-RELEASE. Too large change to run MFC prior to > release. >=20 > I'd appreciate if you patch your stable/9 system manually and thus > perform some testing prior to merge. FYI, 9.1 was already branched. Not that I encourage you to make a commit that would diverge the stable/9 from releng/9.1 while 9.1 is still rolling. But the stall on stable/9 due to freeze was too long and IMO its longevity is damaging. --4ehG9HxkuyoI6jtY Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (FreeBSD) iEYEARECAAYFAlA0xjQACgkQC3+MBN1Mb4hYFACdHdKc9PtlFDgJnhctZHQ8m4m8 BRUAn1+Pmt4sz+d+ASkEg0eZlZJ2wAMl =vVzQ -----END PGP SIGNATURE----- --4ehG9HxkuyoI6jtY--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20120822114452.GC33100>