From owner-svn-src-all@FreeBSD.ORG Sun Aug 11 21:46:39 2013 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id E38BB90E for ; Sun, 11 Aug 2013 21:46:38 +0000 (UTC) (envelope-from scott4long@yahoo.com) Received: from nm15-vm2.bullet.mail.ne1.yahoo.com (nm15-vm2.bullet.mail.ne1.yahoo.com [98.138.91.91]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 5EC2E291C for ; Sun, 11 Aug 2013 21:46:38 +0000 (UTC) Received: from [98.138.226.176] by nm15.bullet.mail.ne1.yahoo.com with NNFMP; 11 Aug 2013 21:40:10 -0000 Received: from [98.138.84.41] by tm11.bullet.mail.ne1.yahoo.com with NNFMP; 11 Aug 2013 21:40:10 -0000 Received: from [127.0.0.1] by smtp109.mail.ne1.yahoo.com with NNFMP; 11 Aug 2013 21:40:10 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s1024; t=1376257210; bh=1JKaHRi2TFqwNaR/oRkjAeoIo4YaPmlszuCCiEuwezg=; h=X-Yahoo-Newman-Id:X-Yahoo-Newman-Property:X-YMail-OSG:X-Yahoo-SMTP:X-Rocket-Received:Content-Type:Mime-Version:Subject:From:In-Reply-To:Date:Cc:Content-Transfer-Encoding:Message-Id:References:To:X-Mailer; b=Da2LXx/D3eTaCQ2QCbtAPLQAnykLVJhdtbCjDADIaMKqIFBLNhx6opqwFrzmV/tEisx+CamxbnEPrhoBRNmo3Vy+a57H5sSh55w14COOcrSftImG8L0+kh7wD4pdwHNP7Vqp7npI0TgDvXSaEsiZSUGYOTGc+Jh0AJA71zAWrTA= X-Yahoo-Newman-Id: 399430.40155.bm@smtp109.mail.ne1.yahoo.com X-Yahoo-Newman-Property: ymail-3 X-YMail-OSG: AYw5ehIVM1m2TlALwTEmdoAwpfOeNIrVdLIwtRyFPrKCBg5 _5bDrMFEZSaRpbIN1erYshU98YDPBx7_.RvIsEN18v9IPT25mbmVwDkDX4vy ipGrJlQGbUufGgWyAhsqNMbJdBrjeDY2aPrgegA6K2q1ofGd1PA7J_zN1TmX uF6ai7TX3SBdFQsdpBUfzl4SwNE30RGCBU9pYeXCW9AH0UvDg7ohyqdtN8E3 ewUoPnytJvGP_KxehDPwlk83w4NuK78coZAgFtE4Jq.DZu_OWDtpBGhaQWOD ao0HMvefHoQ.dBN_HraZ_SrDpgBsIbngi1qA8cdCSMxx7uXllAlK53JQ8htE 4CoFwjNErdJSN5Rlr.BcBXu61qTCsLJapU2JyPZLLtwUNNVTC2uOFQ7by_US hdRN5D.WKYh4kKasX.HGyVT0h6W9IlsZCBZXe.PQdFLXCtRff9IcKpI7D7qK n_oRnyKhNb5jqeyFOpv1yBcPOxpbSp1qPcvDbf5E.uKoKk38l3JtQilb3RNS qbnLbrbLLBkvD879no5txQIo.I1LqOfot4S8Wh_AO.WUe4_V8lKVWVVIR.g- - X-Yahoo-SMTP: clhABp.swBB7fs.LwIJpv3jkWgo2NU8- X-Rocket-Received: from [192.168.254.206] (scott4long@168.103.85.57 with ) by smtp109.mail.ne1.yahoo.com with SMTP; 11 Aug 2013 14:40:10 -0700 PDT Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 6.5 \(1508\)) Subject: Re: svn commit: r253460 - head/sys/dev/mps From: Scott Long In-Reply-To: <52077D0D.8090607@FreeBSD.org> Date: Sun, 11 Aug 2013 15:40:09 -0600 Content-Transfer-Encoding: quoted-printable Message-Id: References: <201307190012.r6J0Cg1r027645@svn.freebsd.org> <52077D0D.8090607@FreeBSD.org> To: Alexander Motin X-Mailer: Apple Mail (2.1508) Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, Scott Long X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 11 Aug 2013 21:46:39 -0000 Thanks, I'll look into it. Scott On Aug 11, 2013, at 6:01 AM, Alexander Motin wrote: > On 19.07.2013 03:12, Scott Long wrote: >> Author: scottl >> Date: Fri Jul 19 00:12:41 2013 >> New Revision: 253460 >> URL: http://svnweb.freebsd.org/changeset/base/253460 >>=20 >> Log: >> Overhaul error, information, and debug logging. >>=20 >> Obtained from: Netflix >> MFC after: 3 days >>=20 >> Modified: >> head/sys/dev/mps/mps.c >> head/sys/dev/mps/mps_mapping.c >> head/sys/dev/mps/mps_pci.c >> head/sys/dev/mps/mps_sas.c >> head/sys/dev/mps/mps_sas_lsi.c >> head/sys/dev/mps/mps_table.c >> head/sys/dev/mps/mps_user.c >> head/sys/dev/mps/mpsvar.h >=20 > This change created significant CPU overhead under high I/O rate (350K = IOPS) because several functions inside mpssas_log_command() are now = writing into the buffer that is just discarded after that. The following = simple patch seems fixes the situation for me: >=20 > Index: mps_sas.c > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > --- mps_sas.c (revision 254181) > +++ mps_sas.c (working copy) > @@ -304,7 +304,7 @@ mpssas_log_command(struct mps_command *cm, u_int l > char str[192]; > char path_str[64]; >=20 > - if (cm =3D=3D NULL) > + if (cm =3D=3D NULL || (cm->cm_sc->mps_debug & level) =3D=3D 0) > return; >=20 > sbuf_new(&sb, str, sizeof(str), 0); >=20 >=20 > --=20 > Alexander Motin