From owner-freebsd-bugs@freebsd.org Wed Jan 16 19:16:12 2019 Return-Path: Delivered-To: freebsd-bugs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id B2BC114921EF for ; Wed, 16 Jan 2019 19:16:12 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id 4E10282B48 for ; Wed, 16 Jan 2019 19:16:12 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.ysv.freebsd.org (Postfix) id 0F02C14921ED; Wed, 16 Jan 2019 19:16:12 +0000 (UTC) Delivered-To: bugs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id E079614921EC for ; Wed, 16 Jan 2019 19:16:11 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.ysv.freebsd.org (mxrelay.ysv.freebsd.org [IPv6:2001:1900:2254:206a::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.ysv.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 6179982B46 for ; Wed, 16 Jan 2019 19:16:11 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.ysv.freebsd.org (Postfix) with ESMTPS id 9D2C88D74 for ; Wed, 16 Jan 2019 19:16:10 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id x0GJGA0V092545 for ; Wed, 16 Jan 2019 19:16:10 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id x0GJGA82092544 for bugs@FreeBSD.org; Wed, 16 Jan 2019 19:16:10 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: bugs@FreeBSD.org Subject: [Bug 235005] r342051 "pfsync: Performance improvement" breaks CARP when used with pfsync Date: Wed, 16 Jan 2019 19:16:10 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 12.0-STABLE X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: thomas@gibfest.dk X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status bug_severity priority component assigned_to reporter Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 16 Jan 2019 19:16:13 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D235005 Bug ID: 235005 Summary: r342051 "pfsync: Performance improvement" breaks CARP when used with pfsync Product: Base System Version: 12.0-STABLE Hardware: Any OS: Any Status: New Severity: Affects Some People Priority: --- Component: kern Assignee: bugs@FreeBSD.org Reporter: thomas@gibfest.dk After quite a few buildworlds+kernel and reboots I've managed to isolate ba= se r342051 "pfsync: Performance improvement" as the reason why lagg stopped working for me. I've been building a couple of carp+pf routers/firewalls, originally with 12-BETA2 but they were recently upgraded to 12-STABLE base r342254 which is when both carp nodes started being MASTER instead of one MASTER and one BAC= KUP node. The notes from my bisecting are below. All tests are with the same configuration. As you can see, base r342051 is the commit where it broke. 12-STABLE base r339946 MASTER/BACKUP 12-STABLE base r341100 MASTER/BACKUP 12-STABLE base r341677 MASTER/BACKUP 12-STABLE base r341965 MASTER/BACKUP 12-STABLE base r342037 MASTER/BACKUP 12-STABLE base r342050 MASTER/BACKUP 12-STABLE base r342051 MASTER/MASTER 12-STABLE base r342055 MASTER/MASTER 12-STABLE base r342073 MASTER/MASTER 12-STABLE base r342109 MASTER/MASTER 12-STABLE base r342254 MASTER/MASTER I've further confirmed pfsync to be at fault, when pfsync is not enabled the two nodes are MASTER and BACKUP as they should be. Immediately after I start pfsync the BACKUP node becomes MASTER and logs these messages: Jan 16 16:34:56 fwclu2b kernel: carp: demoted by -240 to -240 (pfsync bulk done) Jan 16 16:34:56 fwclu2b kernel: carp: 1 at lagg2.52: BACKUP -> MASTER (preempting a slower master) Jan 16 16:34:56 fwclu2b kernel: carp: 1 at lagg2.51: BACKUP -> MASTER (preempting a slower master) Jan 16 16:34:56 fwclu2b kernel: carp: 1 at lagg3: BACKUP -> MASTER (preempt= ing a slower master) ...but the MASTER also stays MASTER, and chaos ensues, nothing works on the network. Stopping pfsync doesn't resolve the situation, only a reboot with pfsync disabled restores normal carp functionality. I suggest maybe backing out base r342051 while we investigate the cause, if= a fix can't be found quickly. I suspect it could have something to do with the pfsync carp demotion code, which the log messages above seem to confirm, bu= t I don't know. Let me know if further info is needed about my configuration or anything. S= ee also this thread on -stable https://lists.freebsd.org/pipermail/freebsd-stable/2019-January/090421.html which confirms I am not the only one experiencing this. --=20 You are receiving this mail because: You are the assignee for the bug.=