From owner-svn-doc-head@freebsd.org  Thu May  2 14:18:23 2019
Return-Path: <owner-svn-doc-head@freebsd.org>
Delivered-To: svn-doc-head@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 41A9D1596F34;
 Thu,  2 May 2019 14:18:23 +0000 (UTC) (envelope-from mat@FreeBSD.org)
Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org
 [IPv6:2610:1c1:1:606c::19:3])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 server-signature RSA-PSS (4096 bits)
 client-signature RSA-PSS (4096 bits) client-digest SHA256)
 (Client CN "mxrelay.nyi.freebsd.org",
 Issuer "Let's Encrypt Authority X3" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id D31A7909C7;
 Thu,  2 May 2019 14:18:22 +0000 (UTC) (envelope-from mat@FreeBSD.org)
Received: from repo.freebsd.org (repo.freebsd.org
 [IPv6:2610:1c1:1:6068::e6a:0])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id AD744A506;
 Thu,  2 May 2019 14:18:22 +0000 (UTC) (envelope-from mat@FreeBSD.org)
Received: from repo.freebsd.org ([127.0.1.37])
 by repo.freebsd.org (8.15.2/8.15.2) with ESMTP id x42EIMwT099612;
 Thu, 2 May 2019 14:18:22 GMT (envelope-from mat@FreeBSD.org)
Received: (from mat@localhost)
 by repo.freebsd.org (8.15.2/8.15.2/Submit) id x42EIMlF099611;
 Thu, 2 May 2019 14:18:22 GMT (envelope-from mat@FreeBSD.org)
Message-Id: <201905021418.x42EIMlF099611@repo.freebsd.org>
X-Authentication-Warning: repo.freebsd.org: mat set sender to mat@FreeBSD.org
 using -f
From: Mathieu Arnold <mat@FreeBSD.org>
Date: Thu, 2 May 2019 14:18:22 +0000 (UTC)
To: doc-committers@freebsd.org, svn-doc-all@freebsd.org,
 svn-doc-head@freebsd.org
Subject: svn commit: r52974 -
 head/en_US.ISO8859-1/books/porters-handbook/makefiles
X-SVN-Group: doc-head
X-SVN-Commit-Author: mat
X-SVN-Commit-Paths: head/en_US.ISO8859-1/books/porters-handbook/makefiles
X-SVN-Commit-Revision: 52974
X-SVN-Commit-Repository: doc
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-Rspamd-Queue-Id: D31A7909C7
X-Spamd-Bar: --
Authentication-Results: mx1.freebsd.org
X-Spamd-Result: default: False [-2.98 / 15.00];
 local_wl_from(0.00)[FreeBSD.org];
 NEURAL_HAM_MEDIUM(-1.00)[-0.999,0];
 NEURAL_HAM_LONG(-1.00)[-1.000,0];
 NEURAL_HAM_SHORT(-0.98)[-0.979,0];
 ASN(0.00)[asn:11403, ipnet:2610:1c1:1::/48, country:US]
X-BeenThere: svn-doc-head@freebsd.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: SVN commit messages for the doc tree for head
 <svn-doc-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-doc-head>,
 <mailto:svn-doc-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-doc-head/>
List-Post: <mailto:svn-doc-head@freebsd.org>
List-Help: <mailto:svn-doc-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-doc-head>,
 <mailto:svn-doc-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 02 May 2019 14:18:23 -0000

Author: mat
Date: Thu May  2 14:18:22 2019
New Revision: 52974
URL: https://svnweb.freebsd.org/changeset/doc/52974

Log:
  Document that USE_GIT(HUB|LAB)=nodefault needs some special handling.
  
  PR:		235762
  Reported by:	jhb

Modified:
  head/en_US.ISO8859-1/books/porters-handbook/makefiles/chapter.xml

Modified: head/en_US.ISO8859-1/books/porters-handbook/makefiles/chapter.xml
==============================================================================
--- head/en_US.ISO8859-1/books/porters-handbook/makefiles/chapter.xml	Thu May  2 04:25:58 2019	(r52973)
+++ head/en_US.ISO8859-1/books/porters-handbook/makefiles/chapter.xml	Thu May  2 14:18:22 2019	(r52974)
@@ -2664,12 +2664,6 @@ v0.7.3-0-gc66c71d</screen>
 	  similar to <xref
 	    linkend="porting-master-sites-n"/>.</para>
 
-	<para>When fetching multiple files from GitHub, sometimes the
-	  default distribution file is not fetched from GitHub.  To disable
-	  fetching the default distribution, set:</para>
-
-	<programlisting>USE_GITHUB=	nodefault</programlisting>
-
 	<para>Multiple values are added to
 	  <varname>GH_ACCOUNT</varname>,
 	  <varname>GH_PROJECT</varname>, and
@@ -2712,6 +2706,22 @@ v0.7.3-0-gc66c71d</screen>
 	    <xref linkend="porting-master-sites-n"/></para>
 	</note>
 
+	<para>When fetching multiple files from GitHub, sometimes the
+	  default distribution file is not fetched from GitHub.  To disable
+	  fetching the default distribution, set:</para>
+
+	<programlisting>USE_GITHUB=	nodefault</programlisting>
+
+	<important>
+	  <para>When using <literal>USE_GITHUB=nodefault</literal>,
+	    the <filename>Makefile</filename> must set
+	    <varname>DISTFILES</varname> in its
+	    <link linkend="porting-order-portname">top block</link>.
+	    The definition should be:</para>
+
+	  <programlisting>DISTFILES=    ${DISTNAME}${EXTRACT_SUFX}</programlisting>
+	</important>
+
 	<example xml:id="makefile-master_sites-github-multi">
 	  <title>Use of <varname>USE_GITHUB</varname> with Multiple
 	    Distribution Files</title>
@@ -3053,12 +3063,6 @@ GL_COMMIT=	9c1669ce60c3f4f5eb43df874d7314483fb3f8a6</p
               linkend="porting-master-sites-n"/> and <xref
               linkend="makefile-master_sites-gitlab-multiple"/>.</para>
 
-          <para>When fetching multiple files using <application>GitLab</application>,
-            sometimes the default distribution file is not fetched from a <application>GitLab</application>
-            site.  To disable fetching the default distribution, set:</para>
-
-          <programlisting>USE_GITLAB=     nodefault</programlisting>
-
           <para>Multiple values are added to
             <varname>GL_SITE</varname>,
             <varname>GL_ACCOUNT</varname>,
@@ -3099,6 +3103,23 @@ GL_COMMIT=	9c1669ce60c3f4f5eb43df874d7314483fb3f8a6</p
               adhere to the restrictions on group names outlined in
               <xref linkend="porting-master-sites-n"/></para>
           </note>
+
+	<para>When fetching multiple files using <application>GitLab</application>,
+	  sometimes the default distribution file is not fetched from a <application>GitLab</application>
+	  site.  To disable fetching the default distribution, set:</para>
+
+	<programlisting>USE_GITLAB=	nodefault</programlisting>
+
+	<important>
+	  <para>When using <literal>USE_GITLAB=nodefault</literal>,
+	    the <filename>Makefile</filename> must set
+	    <varname>DISTFILES</varname> in its
+	    <link linkend="porting-order-portname">top block</link>.
+	    The definition should be:</para>
+
+	  <programlisting>DISTFILES=    ${DISTNAME}${EXTRACT_SUFX}</programlisting>
+	</important>
+
 
         <example xml:id="makefile-master_sites-gitlab-multi">
           <title>Use of <varname>USE_GITLAB</varname> with Multiple