From owner-svn-src-all@freebsd.org Wed Sep 2 13:20:37 2015 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id F0BD79C8475; Wed, 2 Sep 2015 13:20:37 +0000 (UTC) (envelope-from glebius@FreeBSD.org) Received: from cell.glebius.int.ru (glebius.int.ru [81.19.69.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "cell.glebius.int.ru", Issuer "cell.glebius.int.ru" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 5E430D9A; Wed, 2 Sep 2015 13:20:36 +0000 (UTC) (envelope-from glebius@FreeBSD.org) Received: from cell.glebius.int.ru (localhost [127.0.0.1]) by cell.glebius.int.ru (8.15.2/8.15.2) with ESMTPS id t82DKYNJ009025 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Wed, 2 Sep 2015 16:20:34 +0300 (MSK) (envelope-from glebius@FreeBSD.org) Received: (from glebius@localhost) by cell.glebius.int.ru (8.15.2/8.15.2/Submit) id t82DKYEO009024; Wed, 2 Sep 2015 16:20:34 +0300 (MSK) (envelope-from glebius@FreeBSD.org) X-Authentication-Warning: cell.glebius.int.ru: glebius set sender to glebius@FreeBSD.org using -f Date: Wed, 2 Sep 2015 16:20:34 +0300 From: Gleb Smirnoff To: Alexander Kabaev Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r287358 - head Message-ID: <20150902132034.GL1023@FreeBSD.org> References: <201509011159.t81BxCkm072208@repo.freebsd.org> <20150901224438.32e982dd@kan> <20150902125024.GH1023@FreeBSD.org> <20150902090825.619467d9@kan> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150902090825.619467d9@kan> User-Agent: Mutt/1.5.23 (2014-03-12) X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 Sep 2015 13:20:38 -0000 On Wed, Sep 02, 2015 at 09:08:25AM -0400, Alexander Kabaev wrote: A> > A> > Modified: head/Makefile.inc1 A> > A> > ============================================================================== A> > A> > --- head/Makefile.inc1 Tue Sep 1 11:46:13 2015 A> > A> > (r287357) +++ head/Makefile.inc1 Tue Sep 1 11:59:12 A> > A> > 2015 (r287358) @@ -1127,6 +1127,14 @@ reinstallkernel A> > A> > reinstallkernel.debug: _ cd ${KRNLOBJDIR}/${INSTALLKERNEL}; \ A> > A> > ${CROSSENV} PATH=${TMPPATH} \ A> > A> > ${MAKE} ${IMAKE_INSTALL} KERNEL=${INSTKERNNAME} A> > A> > ${.TARGET:S/kernel//} +.for _kernel in ${BUILDKERNELS:[2..-1]} A> > A> > + @echo A> > A> > "--------------------------------------------------------------" A> > A> > + @echo ">>> Installing kernel ${_kernel}" A> > A> > + @echo A> > A> > "--------------------------------------------------------------" A> > A> > + cd ${KRNLOBJDIR}/${_kernel}; \ A> > A> > + ${CROSSENV} PATH=${TMPPATH} \ A> > A> > + ${MAKE} ${IMAKE_INSTALL} A> > A> > KERNEL=${INSTKERNNAME}.${_kernel} ${.TARGET:S/kernel//} +.endfor A> > A> > A> > A> > distributekernel distributekernel.debug: A> > A> > .if empty(INSTALLKERNEL) A> > A> A> > A> This is probably not doing what you think it is doing. Now, when A> > A> installing my kernel, built from config file , I get it A> > A> installed into /boot/kernel, which is good and normal, and I get A> > A> an extra and highly undesired copy in boot/kernel.. That one A> > A> I didn't ask for and would rather see it gone. A> > A> > Does that happen to you, or do you just suppose that this is going to A> > happen looking at the code? A> > A> > -- A> > Totus tuus, Glebius. A> A> It does happen to me, I wouldn't bother you otherwise. A> A> 'make installworld KERNCONF=KANBSD' now results in kernel installed A> twice, once as /boot/kernel and once as /boot/kernel.KANBSD. Re-running A> it once more, I even get to have /boot/kernel.KANBSD.old. A> A> As a side point, 'make buildworld' does not suffer from same issue. installworld? Now I'm really confused. Was that typo? -- Totus tuus, Glebius.