From owner-svn-src-head@FreeBSD.ORG Tue Dec 3 22:26:39 2013 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id E64B43F5; Tue, 3 Dec 2013 22:26:38 +0000 (UTC) Received: from svn.freebsd.org (svn.freebsd.org [IPv6:2001:1900:2254:2068::e6a:0]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id D1D3F179D; Tue, 3 Dec 2013 22:26:38 +0000 (UTC) Received: from svn.freebsd.org ([127.0.1.70]) by svn.freebsd.org (8.14.7/8.14.7) with ESMTP id rB3MQccF019606; Tue, 3 Dec 2013 22:26:38 GMT (envelope-from emaste@svn.freebsd.org) Received: (from emaste@localhost) by svn.freebsd.org (8.14.7/8.14.7/Submit) id rB3MQcJ4019604; Tue, 3 Dec 2013 22:26:38 GMT (envelope-from emaste@svn.freebsd.org) Message-Id: <201312032226.rB3MQcJ4019604@svn.freebsd.org> From: Ed Maste Date: Tue, 3 Dec 2013 22:26:38 +0000 (UTC) To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: svn commit: r258897 - in head/contrib/llvm/tools/lldb/source: Breakpoint Symbol X-SVN-Group: head MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 03 Dec 2013 22:26:39 -0000 Author: emaste Date: Tue Dec 3 22:26:38 2013 New Revision: 258897 URL: http://svnweb.freebsd.org/changeset/base/258897 Log: Update LLDB to upstream r196322 snapshot Upstream revisions of note: r196298 - Fix use of std::lower_bound r196322 - Fix log message for new invalidation checks Sponsored by: DARPA, AFRL Modified: head/contrib/llvm/tools/lldb/source/Breakpoint/BreakpointLocationList.cpp head/contrib/llvm/tools/lldb/source/Symbol/UnwindPlan.cpp Directory Properties: head/contrib/llvm/tools/lldb/ (props changed) Modified: head/contrib/llvm/tools/lldb/source/Breakpoint/BreakpointLocationList.cpp ============================================================================== --- head/contrib/llvm/tools/lldb/source/Breakpoint/BreakpointLocationList.cpp Tue Dec 3 22:16:33 2013 (r258896) +++ head/contrib/llvm/tools/lldb/source/Breakpoint/BreakpointLocationList.cpp Tue Dec 3 22:26:38 2013 (r258897) @@ -86,16 +86,13 @@ Compare (BreakpointLocationSP lhs, lldb: BreakpointLocationSP BreakpointLocationList::FindByID (lldb::break_id_t break_id) const { - BreakpointLocationSP bp_loc_sp; Mutex::Locker locker (m_mutex); - - collection::const_iterator begin = m_locations.begin(), end = m_locations.end(); - collection::const_iterator result; - result = std::lower_bound(begin, end, break_id, Compare); - if (result == end) - return bp_loc_sp; + collection::const_iterator end = m_locations.end(); + collection::const_iterator pos = std::lower_bound(m_locations.begin(), end, break_id, Compare); + if (pos != end && (*pos)->GetID() == break_id) + return *(pos); else - return *(result); + return BreakpointLocationSP(); } size_t Modified: head/contrib/llvm/tools/lldb/source/Symbol/UnwindPlan.cpp ============================================================================== --- head/contrib/llvm/tools/lldb/source/Symbol/UnwindPlan.cpp Tue Dec 3 22:16:33 2013 (r258896) +++ head/contrib/llvm/tools/lldb/source/Symbol/UnwindPlan.cpp Tue Dec 3 22:26:38 2013 (r258897) @@ -379,7 +379,19 @@ UnwindPlan::PlanValidAtAddress (Address { Log *log(GetLogIfAllCategoriesSet (LIBLLDB_LOG_UNWIND)); if (log) - log->Printf ("Testing if UnwindPlan is valid at pc 0x%" PRIx64 ": No unwind rows - is invalid."); + { + StreamString s; + if (addr.Dump (&s, NULL, Address::DumpStyleSectionNameOffset)) + { + log->Printf ("UnwindPlan is invalid -- no unwind rows for UnwindPlan '%s' at address %s", + m_source_name.GetCString(), s.GetData()); + } + else + { + log->Printf ("UnwindPlan is invalid -- no unwind rows for UnwindPlan '%s'", + m_source_name.GetCString()); + } + } return false; } @@ -389,7 +401,19 @@ UnwindPlan::PlanValidAtAddress (Address { Log *log(GetLogIfAllCategoriesSet (LIBLLDB_LOG_UNWIND)); if (log) - log->Printf ("Testing if UnwindPlan is valid at pc 0x%" PRIx64 ": No CFA register - is invalid."); + { + StreamString s; + if (addr.Dump (&s, NULL, Address::DumpStyleSectionNameOffset)) + { + log->Printf ("UnwindPlan is invalid -- no CFA register defined in row 0 for UnwindPlan '%s' at address %s", + m_source_name.GetCString(), s.GetData()); + } + else + { + log->Printf ("UnwindPlan is invalid -- no CFA register defined in row 0 for UnwindPlan '%s'", + m_source_name.GetCString()); + } + } return false; }