From owner-freebsd-usb@FreeBSD.ORG  Tue Jul 20 10:49:33 2010
Return-Path: <owner-freebsd-usb@FreeBSD.ORG>
Delivered-To: freebsd-usb@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id B7A8F1065674;
	Tue, 20 Jul 2010 10:49:33 +0000 (UTC)
	(envelope-from hselasky@c2i.net)
Received: from swip.net (mailfe08.swip.net [212.247.154.225])
	by mx1.freebsd.org (Postfix) with ESMTP id E617E8FC0A;
	Tue, 20 Jul 2010 10:49:32 +0000 (UTC)
X-Cloudmark-Score: 0.000000 []
X-Cloudmark-Analysis: v=1.0 c=1 a=HRj3ij7MtkgA:10 a=8nJEP1OIZ-IA:10
	a=M8b_wTzEtboA:10 a=MnI1ikcADjEx7bvsp0jZvQ==:17
	a=8kQB0OdkAAAA:8 a=6I5d2MoRAAAA:8 a=BYtiyKqR4ApS3tB-cVAA:9
	a=Tyssu-7BCdl8jOWnyjmdT0r4CX4A:4 a=wPNLvfGTeEIA:10
	a=9aOQ2cSd83gA:10 a=SV7veod9ZcQA:10
Received: from [188.126.201.140] (account mc467741@c2i.net HELO
	laptop002.hselasky.homeunix.org)
	by mailfe08.swip.net (CommuniGate Pro SMTP 5.2.19)
	with ESMTPA id 1376044727; Tue, 20 Jul 2010 12:49:30 +0200
From: Hans Petter Selasky <hselasky@c2i.net>
To: PseudoCylon <moonlightakkiy@yahoo.ca>
Date: Tue, 20 Jul 2010 12:46:34 +0200
User-Agent: KMail/1.13.5 (FreeBSD/8.1-PRERELEASE; KDE/4.4.5; amd64; ; )
References: <201007141511.46190.hselasky@c2i.net>
	<201007192117.05034.hselasky@c2i.net>
	<504334.98385.qm@web51801.mail.re2.yahoo.com>
In-Reply-To: <504334.98385.qm@web51801.mail.re2.yahoo.com>
X-Face: +~\`s("[*<S!NI[0M*"FaghA8S>|O,="7?X@L.elg*F"OA\I/3%^p8g?ab%RN'(; _IjlA:
	hGE..Ew, XAQ*o#\/M~SC=S1-f9{EzRfT'|Hhll5Q]ha5Bt-s|oTlKMusi:1e[wJl}kd}GR
	Z0adGx-x_0zGbZj'e(Y[(UNle~)8CQWXW@:DX+9)_YlB[tIccCPN$7/L'
MIME-Version: 1.0
Content-Type: Text/Plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Message-Id: <201007201246.34654.hselasky@c2i.net>
Cc: Sam Leffler <sam@freebsd.org>, freebsd-current@freebsd.org,
	freebsd-usb@freebsd.org
Subject: Re: [panic] Race in IEEE802.11 layer towards device drivers
X-BeenThere: freebsd-usb@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: FreeBSD support for USB <freebsd-usb.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-usb>,
	<mailto:freebsd-usb-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-usb>
List-Post: <mailto:freebsd-usb@freebsd.org>
List-Help: <mailto:freebsd-usb-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-usb>,
	<mailto:freebsd-usb-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 20 Jul 2010 10:49:33 -0000

On Tuesday 20 July 2010 12:03:22 PseudoCylon wrote:
> ----- Original Message ----
> 
> > From: Hans Petter Selasky <hselasky@c2i.net>
> > To: freebsd-current@freebsd.org
> > Cc: PseudoCylon <moonlightakkiy@yahoo.ca>; Sam Leffler <sam@freebsd.org>;
> >
> >freebsd-usb@freebsd.org
> >
> > Sent: Mon, July 19, 2010 1:17:04 PM
> > Subject: Re: [panic] Race in IEEE802.11 layer towards device drivers
> > 
> > Hi AK,
> > 
> > I've committed your patches to USB P4. I've made some additional 
> > patches.
> > 
> > Can you check and verify everything?
> > 
> > http://p4web.freebsd.org/@@181189?ac=10
> 
> Hi
> 
> If we change sc->cmdq_run = RUN_CMDQ_ABORT,
> 
> -- begin excerpt --
> 
> 
> @@ -4890,7 +4877,10 @@ run_stop(void *arg)
>  ifp->if_drv_flags &= ~(IFF_DRV_RUNNING | IFF_DRV_OACTIVE);
> 
>  sc->ratectl_run = RUN_RATECTL_OFF;
> -sc->cmdq_run = RUN_CMDQ_ABORT;
> +
> +RUN_CMDQ_LOCK(sc);
> +sc->cmdq_run = sc->cmdq_key_set = RUN_CMDQ_ABORT;
> +RUN_CMDQ_UNLOCK(sc);
> 
> -- end excerpt --
> 
> 
> we also need to change this, otherwise key will be cleared.

Ok.

Try to give the second mutex a different name, and see how many warnings go 
away.

--HPS