Date: Mon, 23 Mar 2015 03:27:25 +0000 From: Alexey Dokuchaev <danfe@FreeBSD.org> To: Bryan Drewery <bdrewery@FreeBSD.org> Cc: Sunpoet Po-Chuan Hsieh <sunpoet@FreeBSD.org>, svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org Subject: Re: svn commit: r381955 - head/graphics/gdal Message-ID: <20150323032725.GA55962@FreeBSD.org> In-Reply-To: <550F8505.8010600@FreeBSD.org> References: <201503222011.t2MKBHq7091087@svn.freebsd.org> <20150323015759.GA34402@FreeBSD.org> <550F8505.8010600@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, Mar 22, 2015 at 10:14:13PM -0500, Bryan Drewery wrote: > On 3/22/2015 8:58 PM, Alexey Dokuchaev wrote: > > On Sun, Mar 22, 2015 at 08:11:17PM +0000, Sunpoet Po-Chuan Hsieh wrote: > >> New Revision: 381955 > >> URL: https://svnweb.freebsd.org/changeset/ports/381955 > >> QAT: https://qat.redports.org/buildarchive/r381955/ > >> > >> Log: > >> - Use -lpthread instead of -pthread > > > > Is -pthread going away anytime soon? I'm a bit worried of more alike > > changing one to another; since they're identical right now on FreeBSD, > > I'd rather reduce amount of patching, leaving whatever is picked by > > upstream, unless -lpthread really should be preferred over -pthread > > for some reason I'm unaware of (and ready to learn about). > > It's a pointless change. Tijl explains here > https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=198116#c4 Right; I'm aware of Tijl's excellent explanation (broader version he posted on the lists) and given that it is a pointless change, I used this occasion to remind that commits that merely change one to another should be avoided. ./danfe
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20150323032725.GA55962>