From nobody Tue Nov 25 08:46:09 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4dFx9t0xcPz6Hnq2 for ; Tue, 25 Nov 2025 08:46:10 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R12" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4dFx9s5qkFz3xZC for ; Tue, 25 Nov 2025 08:46:09 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1764060369; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=+QL691kf8e7lTKnU/VyYf+Xn3mCSS/C6LdFgEInaJ4Y=; b=RX1W8jIGPKf6GecaHv7cCc+RuJoARgTtoT3Wf/7RobG1O2HdSlqcx54D5WFS/9sDzLbU+B +++SbAxHmnXBaSCYnDaqx/T7O9JS0YaYF1CtDPe5zGMbhSu5c8bgCpRxLFDAlvBdxdVyft n8EmAPyCGIPelHJd/8zvv7IZWbLMTm3bYDwAd1jFQtq6U/9GgHhMSEVpah6mm8soripYQR W1u0sLiumiG52AQ5En/7gTawvHuicDunTKA3sDL5DLJYpKwEziSBgkfmVrothWkCcTssTB 6pxwYq1RMOsJfqz9vF+CsxDNJYHwQcSYwruNJebXBIK/CGYewFAdf+wBlPfNEg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1764060369; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=+QL691kf8e7lTKnU/VyYf+Xn3mCSS/C6LdFgEInaJ4Y=; b=nR3s38TmB4L9ncO6ul15UjpKyZPNgrS/2Ah4IyQrccCJkEW49kac/0XRVSlogb2AqEh+cp FooMgzSYipaRXCWROvN546ysaiAb/tNpS/7HHITdlRzdKQYgYBvVIV9qV6qyQ+gdqtfGkO pCUxVRZw96gbVQ3gTjL3YApVWQIbKLrzyo0OmfOPIg9yUKfE4H/57maxapiG/ynTgpqSZz hqUz0HmtexCcH7PjDwV+zEFkmnY9hzyvdw3RixikQG6SDOk5Y9IDa/DgdD4hZnzl2EzYJd 9NI9Gcfy10FBgW9V6s+VAYHpF95e1f/NhQxYD33r0dK67Vd7wGpnWH3klmnspw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1764060369; a=rsa-sha256; cv=none; b=ZP3dy+WAps9tXW9Mjd4EPyw+TIv2UChrxIjw0/u3IBI34Y08wTJllEml2bcrbhjgz3QmMr 6Z1/lRDTSAeRVNbRdnMRani/yJKYEQfuwcO6WIy/ipkBoB0VfYssAj8AssUsxic6LbBFMW BNGCYFfWpxJHIQ4lX1dHFjaB8+ziI72qQqTMHJ/THnjeT8idk+Rawjm9XA2AodXJ6VUCJn yqOW60Koit2mlMd9hCQIFQQpeNS3CfGoeTIQAAZc/2JOvSrjC6PzoIvL+n44jBIv2N/3eb ulX/C/7a69J5PkKm68ZiTVirXb8/N3f91Qp7HFXaMhmMwbJ44M1UKNOKxWcJ2Q== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4dFx9s58ckztQG for ; Tue, 25 Nov 2025 08:46:09 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 2d876 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Tue, 25 Nov 2025 08:46:09 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Ruslan Bukin Subject: git: b87f6330013f - main - nvme(4): Increase HMB alignment. List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: br X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: b87f6330013f2d04ef83c453f95db5cd3247e6e1 Auto-Submitted: auto-generated Date: Tue, 25 Nov 2025 08:46:09 +0000 Message-Id: <69256cd1.2d876.36d668be@gitrepo.freebsd.org> The branch main has been updated by br: URL: https://cgit.FreeBSD.org/src/commit/?id=b87f6330013f2d04ef83c453f95db5cd3247e6e1 commit b87f6330013f2d04ef83c453f95db5cd3247e6e1 Author: Ruslan Bukin AuthorDate: 2025-11-25 08:38:37 +0000 Commit: Ruslan Bukin CommitDate: 2025-11-25 08:38:37 +0000 nvme(4): Increase HMB alignment. The NVME controller in Crucial P310 disk does not accept 16-byte aligned host memory buffer on Codasip Prime platform, but works fine on PAGE_SIZE aligned memory. Instead of adding a quirk, just increase alignment for everyone. Reviewed by: jhb Discussed with: imp Sponsored by: CHERI Research Centre Differential Revision: https://reviews.freebsd.org/D53296 --- sys/dev/nvme/nvme_ctrlr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sys/dev/nvme/nvme_ctrlr.c b/sys/dev/nvme/nvme_ctrlr.c index 41542d24c107..1ad4735cbef8 100644 --- a/sys/dev/nvme/nvme_ctrlr.c +++ b/sys/dev/nvme/nvme_ctrlr.c @@ -907,7 +907,7 @@ again: size = sizeof(struct nvme_hmb_desc) * ctrlr->hmb_nchunks; err = bus_dma_tag_create(bus_get_dma_tag(ctrlr->dev), - 16, 0, BUS_SPACE_MAXADDR, BUS_SPACE_MAXADDR, NULL, NULL, + PAGE_SIZE, 0, BUS_SPACE_MAXADDR, BUS_SPACE_MAXADDR, NULL, NULL, size, 1, size, 0, NULL, NULL, &ctrlr->hmb_desc_tag); if (err != 0) { nvme_printf(ctrlr, "HMB desc tag create failed %d\n", err);