From nobody Tue Aug 16 10:46:37 2022 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4M6SWK2rpgz4Ykr3; Tue, 16 Aug 2022 10:46:37 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4M6SWK2MWvz42Wm; Tue, 16 Aug 2022 10:46:37 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1660646797; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=XT8PdMH5DMb1jP/MP4pU4d339bldpOAm8Am6CUeWoHQ=; b=jHq+6Y//QZKg1OUizfWwP2PanHrvZPTdsMl31ipbLt/Zp9INLCGdgm2tl9GGGN2VEkacdV VFmAxrUwCKecGgFBm5gFtYpPLHrcKpBDA3ikgh1OTqWx0RPyYtnWJsE6PIYjWaMMZWu9bB ztriVOplAnd8S0hXWuGeLU/TmykQs1T+A0vPpmGUzP3qqIgoAxND2G0SByW1lxSdDDCbzB b42BOCzuo9ad1OdSQqrA8I0AJeuoyLya7+aKL17Uma5Lbr+9i6m9ZJfO8ClcaIRpFC5VJx +7s6pSnBLG7bYhS1+eGD5lFOPpbBU4Zh7XZ9Vr+xjaxS9VwyfvQCGILjMsOmjQ== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4M6SWK18wGz15rD; Tue, 16 Aug 2022 10:46:37 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 27GAkbtp080908; Tue, 16 Aug 2022 10:46:37 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 27GAkbH8080907; Tue, 16 Aug 2022 10:46:37 GMT (envelope-from git) Date: Tue, 16 Aug 2022 10:46:37 GMT Message-Id: <202208161046.27GAkbH8080907@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Mateusz Guzik Subject: git: 84a0be4a239b - main - vfs: plug a dead store in kern_linkat_vp List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: mjg X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 84a0be4a239bc3ed08a3cb5a74b1d768d705b8d7 Auto-Submitted: auto-generated ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1660646797; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=XT8PdMH5DMb1jP/MP4pU4d339bldpOAm8Am6CUeWoHQ=; b=TrZ3cZwSGixUBvPcSFbXLtmK3o1CLXZsh8Zwued4Vu4YemRoQAhGOu5PLj7q41DC6oEQ/X PAfLji/SKDku34GtNjLaJnFwPgt14nVegD5X2B2EXfx0qfD3OWMlkD30PE6XlhsZOflVWC 8mQWFzKEmHnspL6ZWKBNvlmhkzCak8PkNAvaaspCsbQ4HcL1a4JS4YMmQmpkxjPw0gDHz5 /oAju2X8mWA/+ttcKuzjaXJSrxwAbCfCrnWM+mZzbRtqAzorMc+CDxToMq8ll1+8LxxZYN 7ghhGZ+EBRek/EDJEySo/GwwFakAqNVowSi9Y3iPMCgDVrjDZrD05YDLruMdGg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1660646797; a=rsa-sha256; cv=none; b=DoCROS7MfZRqNTStD2xVh+Xu9YIAnzGveEdAIGWjx+4pprHr3WpCp5vVum8As1i1nlMZaM 5WeIaqDPOjlxyxo3qhpKuQamaL4qT/bxQtls1QwhSqPZ/Fkcb1N4ztsASjAE/PjvwuvpH8 XYmmxAjG7OR5Fidwl89D1qcn/J4GtroDwOq0RO+1B7ZJeoATZ/aFiK/hI2mvf38xeLcKtX RoDds8Me9D5Dir532ethwX09rIdM6pqh+67HJA3MGn4F08yGYWoMPbYpBEHLA0dhFYXZwx 8LL62vVt9t7SbM/vfTnmSKgEiUrIf5/SlSZ58yDnb2+NK9rSZSSvwOIz/HbslA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N The branch main has been updated by mjg: URL: https://cgit.FreeBSD.org/src/commit/?id=84a0be4a239bc3ed08a3cb5a74b1d768d705b8d7 commit 84a0be4a239bc3ed08a3cb5a74b1d768d705b8d7 Author: Mateusz Guzik AuthorDate: 2022-08-16 10:45:48 +0000 Commit: Mateusz Guzik CommitDate: 2022-08-16 10:46:29 +0000 vfs: plug a dead store in kern_linkat_vp Reported by: clang --analyze --- sys/kern/vfs_syscalls.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sys/kern/vfs_syscalls.c b/sys/kern/vfs_syscalls.c index ba62fdb7e81e..c40d1092574e 100644 --- a/sys/kern/vfs_syscalls.c +++ b/sys/kern/vfs_syscalls.c @@ -1643,7 +1643,7 @@ kern_linkat_vp(struct thread *td, struct vnode *vp, int fd, const char *path, vput(nd.ni_dvp); vrele(vp); return (EXDEV); - } else if ((error = vn_lock(vp, LK_EXCLUSIVE)) == 0) { + } else if (vn_lock(vp, LK_EXCLUSIVE) == 0) { error = can_hardlink(vp, td->td_ucred); #ifdef MAC if (error == 0)