From owner-p4-projects@FreeBSD.ORG  Tue Aug 15 02:03:06 2006
Return-Path: <owner-p4-projects@FreeBSD.ORG>
X-Original-To: p4-projects@freebsd.org
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id 9E82016A4E1; Tue, 15 Aug 2006 02:03:06 +0000 (UTC)
X-Original-To: perforce@freebsd.org
Delivered-To: perforce@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 7B05416A4DD
	for <perforce@freebsd.org>; Tue, 15 Aug 2006 02:03:06 +0000 (UTC)
	(envelope-from jb@freebsd.org)
Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 021EF43D5A
	for <perforce@freebsd.org>; Tue, 15 Aug 2006 02:03:05 +0000 (GMT)
	(envelope-from jb@freebsd.org)
Received: from repoman.freebsd.org (localhost [127.0.0.1])
	by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k7F235CP082092
	for <perforce@freebsd.org>; Tue, 15 Aug 2006 02:03:05 GMT
	(envelope-from jb@freebsd.org)
Received: (from perforce@localhost)
	by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k7F235d5082081
	for perforce@freebsd.org; Tue, 15 Aug 2006 02:03:05 GMT
	(envelope-from jb@freebsd.org)
Date: Tue, 15 Aug 2006 02:03:05 GMT
Message-Id: <200608150203.k7F235d5082081@repoman.freebsd.org>
X-Authentication-Warning: repoman.freebsd.org: perforce set sender to
	jb@freebsd.org using -f
From: John Birrell <jb@FreeBSD.org>
To: Perforce Change Reviews <perforce@freebsd.org>
Cc: 
Subject: PERFORCE change 103937 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 15 Aug 2006 02:03:06 -0000

http://perforce.freebsd.org/chv.cgi?CH=103937

Change 103937 by jb@jb_freebsd2 on 2006/08/15 02:02:10

	Jack the compile warning level up to encourage people to write
	clean code.
	
	It would be nice if the OpenSolaris people would stop wearing the
	"we compile our tree with gcc" as a badge of honour because that
	means very little if you don't use even the most basic gcc warning
	levels.
	
	I was once shouted down by a gcc developer for asking that code
	compile cleanly. He said: "we'll never let a compiler tell us
	how to write code".
	
	I disagree. If the warnings make sense, then they should be used.
	All all the 'const' override casts in OpenSolaris code fall into
	that category. If a developer goes to the trouble of declaring
	something 'const', then it's supposed to be _CONSTANT_ and that
	doesn't give you the right to override that.
	
	[ Little rant there. 8-) ]

Affected files ...

.. //depot/projects/dtrace/src/cddl/Makefile.inc#4 edit

Differences ...

==== //depot/projects/dtrace/src/cddl/Makefile.inc#4 (text+ko) ====

@@ -7,3 +7,5 @@
 CFLAGS+=	-D_SOLARIS_C_SOURCE
 
 IGNORE_PRAGMA=	1
+
+WARNS?=		6